public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com,
	nrb@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 3/5] lib: s390x: sie: Set guest memory pointer
Date: Wed, 23 Nov 2022 13:46:30 +0100	[thread overview]
Message-ID: <20221123134630.0f67da2d@p-imbrenda> (raw)
In-Reply-To: <20221123084656.19864-4-frankja@linux.ibm.com>

On Wed, 23 Nov 2022 08:46:54 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Seems like it was introduced but never set. It's nicer to have a
> pointer than to cast the MSO of a VM.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  lib/s390x/sie.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/s390x/sie.c b/lib/s390x/sie.c
> index a71985b6..9241b4b4 100644
> --- a/lib/s390x/sie.c
> +++ b/lib/s390x/sie.c
> @@ -93,6 +93,7 @@ void sie_guest_create(struct vm *vm, uint64_t guest_mem, uint64_t guest_mem_len)
>  
>  	/* Guest memory chunks are always 1MB */
>  	assert(!(guest_mem_len & ~HPAGE_MASK));
> +	vm->guest_mem = (uint8_t *)guest_mem;
>  	/* For non-PV guests we re-use the host's ASCE for ease of use */
>  	vm->save_area.guest.asce = stctg(1);
>  	/* Currently MSO/MSL is the easiest option */


  parent reply	other threads:[~2022-11-23 13:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  8:46 [kvm-unit-tests PATCH 0/5] s390x: Snippet fixes Janosch Frank
2022-11-23  8:46 ` [kvm-unit-tests PATCH 1/5] s390x: Add a linker script to assembly snippets Janosch Frank
2022-11-23 12:45   ` Claudio Imbrenda
2022-11-24 14:28     ` Janosch Frank
2022-11-24 20:42   ` Janis Schoetterl-Glausch
2022-11-25 10:07     ` Janosch Frank
2022-11-23  8:46 ` [kvm-unit-tests PATCH 2/5] s390x: snippets: Fix SET_PSW_NEW_ADDR macro Janosch Frank
2022-11-23 10:58   ` Nico Boehr
2022-11-23 13:05   ` Claudio Imbrenda
2022-11-23  8:46 ` [kvm-unit-tests PATCH 3/5] lib: s390x: sie: Set guest memory pointer Janosch Frank
2022-11-23 11:01   ` Nico Boehr
2022-11-23 12:46   ` Claudio Imbrenda [this message]
2022-11-23  8:46 ` [kvm-unit-tests PATCH 4/5] s390x: Clear first stack frame and end backtrace early Janosch Frank
2022-11-23 11:05   ` Nico Boehr
2022-11-23 12:47   ` Claudio Imbrenda
2022-11-23  8:46 ` [kvm-unit-tests PATCH 5/5] lib: s390x: Handle debug prints for SIE exceptions correctly Janosch Frank
2022-11-23 13:01   ` Claudio Imbrenda
2022-11-30 14:38     ` Janosch Frank
2022-11-30 14:46       ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123134630.0f67da2d@p-imbrenda \
    --to=imbrenda@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=seiden@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox