From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com,
nrb@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 5/5] lib: s390x: Handle debug prints for SIE exceptions correctly
Date: Wed, 30 Nov 2022 15:46:06 +0100 [thread overview]
Message-ID: <20221130154606.758b1087@p-imbrenda> (raw)
In-Reply-To: <44870720-bd9c-47b2-f08e-6ece37410498@linux.ibm.com>
On Wed, 30 Nov 2022 15:38:53 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:
> On 11/23/22 14:01, Claudio Imbrenda wrote:
> > On Wed, 23 Nov 2022 08:46:56 +0000
> > Janosch Frank <frankja@linux.ibm.com> wrote:
> >
> >> When we leave SIE due to an exception, we'll still have guest values
> >> in registers 0 - 13 and that's not clearly portraied in our debug
> >> prints. So let's fix that.
> >
> > wouldn't it be cleaner to restore the registers in the interrupt
> > handler? (I thought we were already doing it)
>
> You mean RESTORE_REGS_STACK? Please don't make me write this in assembly...
>
> RESTORE_REGS_STACK is doing test/pgm register swapping, it doesn't care
> if the test registers are "host" or "guest" registers.
fair enough :)
prev parent reply other threads:[~2022-11-30 14:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 8:46 [kvm-unit-tests PATCH 0/5] s390x: Snippet fixes Janosch Frank
2022-11-23 8:46 ` [kvm-unit-tests PATCH 1/5] s390x: Add a linker script to assembly snippets Janosch Frank
2022-11-23 12:45 ` Claudio Imbrenda
2022-11-24 14:28 ` Janosch Frank
2022-11-24 20:42 ` Janis Schoetterl-Glausch
2022-11-25 10:07 ` Janosch Frank
2022-11-23 8:46 ` [kvm-unit-tests PATCH 2/5] s390x: snippets: Fix SET_PSW_NEW_ADDR macro Janosch Frank
2022-11-23 10:58 ` Nico Boehr
2022-11-23 13:05 ` Claudio Imbrenda
2022-11-23 8:46 ` [kvm-unit-tests PATCH 3/5] lib: s390x: sie: Set guest memory pointer Janosch Frank
2022-11-23 11:01 ` Nico Boehr
2022-11-23 12:46 ` Claudio Imbrenda
2022-11-23 8:46 ` [kvm-unit-tests PATCH 4/5] s390x: Clear first stack frame and end backtrace early Janosch Frank
2022-11-23 11:05 ` Nico Boehr
2022-11-23 12:47 ` Claudio Imbrenda
2022-11-23 8:46 ` [kvm-unit-tests PATCH 5/5] lib: s390x: Handle debug prints for SIE exceptions correctly Janosch Frank
2022-11-23 13:01 ` Claudio Imbrenda
2022-11-30 14:38 ` Janosch Frank
2022-11-30 14:46 ` Claudio Imbrenda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130154606.758b1087@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox