From: Pierre Morel <pmorel@linux.ibm.com>
To: linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, thuth@redhat.com, kvm@vger.kernel.org,
imbrenda@linux.ibm.com, david@redhat.com, nrb@linux.ibm.com,
nsg@linux.ibm.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH v3 0/2] Fixing infinite loop on SCLP READ SCP INFO error
Date: Tue, 30 May 2023 14:40:54 +0200 [thread overview]
Message-ID: <20230530124056.18332-1-pmorel@linux.ibm.com> (raw)
Aborting on SCLP READ SCP INFO error leads to a deadloop.
The loop is:
abort() -> exit() -> smp_teardown() -> smp_query_num_cpus() ->
sclp_get_cpu_num() -> assert() -> abort()
Since smp_setup() is done after sclp_read_info() inside setup() this
loop only happens when only the start processor is running.
Let sclp_get_cpu_num() return 1 in this case.
Also implement the SCLP_RC_INSUFFICIENT_SCCB_LENGTH handling and
repeat the sclp command.
Pierre Morel (2):
s390x: sclp: consider monoprocessor on read_info error
s390x: sclp: Implement SCLP_RC_INSUFFICIENT_SCCB_LENGTH
lib/s390x/sclp.c | 64 ++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 56 insertions(+), 8 deletions(-)
--
2.31.1
since v2:
- use tabs in first patch
(Nico)
- Added comments
- Added SCLP_RC_INSUFFICIENT_SCCB_LENGTH handling
next reply other threads:[~2023-05-30 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 12:40 Pierre Morel [this message]
2023-05-30 12:40 ` [kvm-unit-tests PATCH v3 1/2] s390x: sclp: consider monoprocessor on read_info error Pierre Morel
2023-06-01 11:52 ` Nico Boehr
2023-06-01 12:32 ` Pierre Morel
2023-05-30 12:40 ` [kvm-unit-tests PATCH v3 2/2] s390x: sclp: Implement SCLP_RC_INSUFFICIENT_SCCB_LENGTH Pierre Morel
2023-06-01 8:03 ` Janosch Frank
2023-06-01 10:15 ` Pierre Morel
2023-06-01 11:59 ` Nico Boehr
2023-06-01 12:55 ` Pierre Morel
2023-06-01 13:32 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530124056.18332-1-pmorel@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox