From: Janosch Frank <frankja@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>,
linux-s390@vger.kernel.org
Cc: thuth@redhat.com, kvm@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, nsg@linux.ibm.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 2/2] s390x: sclp: Implement SCLP_RC_INSUFFICIENT_SCCB_LENGTH
Date: Thu, 1 Jun 2023 15:32:29 +0200 [thread overview]
Message-ID: <7da25454-bee4-2d4c-a5c2-ac98a44edff0@linux.ibm.com> (raw)
In-Reply-To: <5d0ddebd-22ab-f916-2339-5edc880e5001@linux.ibm.com>
On 6/1/23 14:55, Pierre Morel wrote:
>
> On 6/1/23 13:59, Nico Boehr wrote:
>> Quoting Janosch Frank (2023-06-01 10:03:06)
>>> On 5/30/23 14:40, Pierre Morel wrote:
>>>> If SCLP_CMDW_READ_SCP_INFO fails due to a short buffer, retry
>>>> with a greater buffer.
>>>>
>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> Janosch, I think it makes sense if Pierre picks up Claudios suggestion from here:
>> https://lore.kernel.org/all/20230530173544.378a63c6@p-imbrenda/
>>
>> Do you agree?
>
> from my side:
>
> It simplifies greatly the code and tested without problem.
>
> The documentation says the SCCB length is "at least"... so we can use a
> greater size from the beginning.
>
>
Sounds good
prev parent reply other threads:[~2023-06-01 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 12:40 [kvm-unit-tests PATCH v3 0/2] Fixing infinite loop on SCLP READ SCP INFO error Pierre Morel
2023-05-30 12:40 ` [kvm-unit-tests PATCH v3 1/2] s390x: sclp: consider monoprocessor on read_info error Pierre Morel
2023-06-01 11:52 ` Nico Boehr
2023-06-01 12:32 ` Pierre Morel
2023-05-30 12:40 ` [kvm-unit-tests PATCH v3 2/2] s390x: sclp: Implement SCLP_RC_INSUFFICIENT_SCCB_LENGTH Pierre Morel
2023-06-01 8:03 ` Janosch Frank
2023-06-01 10:15 ` Pierre Morel
2023-06-01 11:59 ` Nico Boehr
2023-06-01 12:55 ` Pierre Morel
2023-06-01 13:32 ` Janosch Frank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da25454-bee4-2d4c-a5c2-ac98a44edff0@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox