[PATCH 0/6] tty: remove unused structure members

[PATCH 0/6] tty: remove unused structure members

[Jiri Slaby (SUSE)]

I wrote a little indexer at https://github.com/jirislaby/clang-struct.
And it found there are few unused structure members inside tty. This
series removes them.

Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: David Sterba <dsterba@suse.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: linux-s390@vger.kernel.org
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>

Jiri Slaby (SUSE) (6):
  tty: con3215: drop raw3215_info::ubuffer
  tty: ipwireless: remove unused ipw_dev::attribute_memory
  tty: jsm: remove unused members from struct board_ops
  tty: jsm: remove unused struct jsm_board members
  tty: rp2: remove unused rp2_uart_port::ignore_rx
  tty: serial_cs: remove unused struct serial_cfg_mem

 drivers/s390/char/con3215.c         |  1 -
 drivers/tty/ipwireless/main.h       |  3 ---
 drivers/tty/serial/8250/serial_cs.c |  6 -----
 drivers/tty/serial/jsm/jsm.h        |  5 ----
 drivers/tty/serial/jsm/jsm_cls.c    | 36 --------------------------
 drivers/tty/serial/jsm/jsm_neo.c    | 40 -----------------------------
 drivers/tty/serial/rp2.c            |  1 -
 7 files changed, 92 deletions(-)

-- 
2.42.1

[PATCH 1/6] tty: con3215: drop raw3215_info::ubuffer

[Jiri Slaby (SUSE)]

clang-struct [1] found raw3215_info::ubuffer unused.

It's actually not used since 2004 when we switched to kernel buffers.

[1] https://github.com/jirislaby/clang-struct

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
---
 drivers/s390/char/con3215.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index 99361618c31f..34bc343dcfcc 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -89,7 +89,6 @@ struct raw3215_info {
 	wait_queue_head_t empty_wait; /* wait queue for flushing */
 	struct timer_list timer;      /* timer for delayed output */
 	int line_pos;		      /* position on the line (for tabs) */
-	char ubuffer[80];	      /* copy_from_user buffer */
 };
 
 /* array of 3215 devices structures */
-- 
2.42.1

Re: [PATCH 0/6] tty: remove unused structure members

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

On Tue, 21 Nov 2023, Jiri Slaby (SUSE) wrote:

> I wrote a little indexer at https://github.com/jirislaby/clang-struct.
> And it found there are few unused structure members inside tty. This
> series removes them.

> Jiri Slaby (SUSE) (6):
>   tty: con3215: drop raw3215_info::ubuffer
>   tty: ipwireless: remove unused ipw_dev::attribute_memory
>   tty: jsm: remove unused members from struct board_ops
>   tty: jsm: remove unused struct jsm_board members
>   tty: rp2: remove unused rp2_uart_port::ignore_rx
>   tty: serial_cs: remove unused struct serial_cfg_mem

For the whole series,

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

Re: [PATCH 1/6] tty: con3215: drop raw3215_info::ubuffer

[Alexander Gordeev]

On Tue, Nov 21, 2023 at 11:36:21AM +0100, Jiri Slaby (SUSE) wrote:
> clang-struct [1] found raw3215_info::ubuffer unused.
> 
> It's actually not used since 2004 when we switched to kernel buffers.
> 
> [1] https://github.com/jirislaby/clang-struct
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---
>  drivers/s390/char/con3215.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index 99361618c31f..34bc343dcfcc 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -89,7 +89,6 @@ struct raw3215_info {
>  	wait_queue_head_t empty_wait; /* wait queue for flushing */
>  	struct timer_list timer;      /* timer for delayed output */
>  	int line_pos;		      /* position on the line (for tabs) */
> -	char ubuffer[80];	      /* copy_from_user buffer */
>  };
>  
>  /* array of 3215 devices structures */

Acked-by: Alexander Gordeev <agordeev@linux.ibm.com>