From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
thuth@redhat.com, david@redhat.com, nsg@linux.ibm.com,
nrb@linux.ibm.com
Subject: [kvm-unit-tests RFC 1/2] lib: s390x: sigp: Name inline assembly arguments
Date: Thu, 1 Feb 2024 14:23:55 +0000 [thread overview]
Message-ID: <20240201142356.534783-2-frankja@linux.ibm.com> (raw)
In-Reply-To: <20240201142356.534783-1-frankja@linux.ibm.com>
Less need to count the operands makes the code easier to read.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
lib/s390x/asm/sigp.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/s390x/asm/sigp.h b/lib/s390x/asm/sigp.h
index 4eae95d0..c9af2c49 100644
--- a/lib/s390x/asm/sigp.h
+++ b/lib/s390x/asm/sigp.h
@@ -54,11 +54,11 @@ static inline int sigp(uint16_t addr, uint8_t order, unsigned long parm,
asm volatile(
" tmll %[bogus_cc],3\n"
- " sigp %1,%2,0(%3)\n"
- " ipm %0\n"
- " srl %0,28\n"
- : "=d" (cc), "+d" (reg1)
- : "d" (addr), "a" (order), [bogus_cc] "d" (bogus_cc)
+ " sigp %[reg1],%[addr],0(%[order])\n"
+ " ipm %[cc]\n"
+ " srl %[cc],28\n"
+ : [cc] "=d" (cc), [reg1] "+d" (reg1)
+ : [addr] "d" (addr), [order] "a" (order), [bogus_cc] "d" (bogus_cc)
: "cc");
if (status)
*status = reg1;
--
2.40.1
next prev parent reply other threads:[~2024-02-01 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 14:23 [kvm-unit-tests RFC 0/2] lib: s390x: Inline asm cleanup Janosch Frank
2024-02-01 14:23 ` Janosch Frank [this message]
2024-02-01 17:52 ` [kvm-unit-tests RFC 1/2] lib: s390x: sigp: Name inline assembly arguments Claudio Imbrenda
2024-02-01 14:23 ` [kvm-unit-tests RFC 2/2] lib: s390x: css: Name inline assembly arguments and clean them up Janosch Frank
2024-04-22 7:43 ` Nico Boehr
2024-04-22 10:57 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201142356.534783-2-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox