Re: [kvm-unit-tests RFC 1/2] lib: s390x: sigp: Name inline assembly arguments

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Thu,  1 Feb 2024 14:23:55 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Less need to count the operands makes the code easier to read.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  lib/s390x/asm/sigp.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/s390x/asm/sigp.h b/lib/s390x/asm/sigp.h
> index 4eae95d0..c9af2c49 100644
> --- a/lib/s390x/asm/sigp.h
> +++ b/lib/s390x/asm/sigp.h
> @@ -54,11 +54,11 @@ static inline int sigp(uint16_t addr, uint8_t order, unsigned long parm,
>  
>  	asm volatile(
>  		"	tmll	%[bogus_cc],3\n"
> -		"	sigp	%1,%2,0(%3)\n"
> -		"	ipm	%0\n"
> -		"	srl	%0,28\n"
> -		: "=d" (cc), "+d" (reg1)
> -		: "d" (addr), "a" (order), [bogus_cc] "d" (bogus_cc)
> +		"	sigp	%[reg1],%[addr],0(%[order])\n"
> +		"	ipm	%[cc]\n"
> +		"	srl	%[cc],28\n"
> +		: [cc] "=d" (cc), [reg1] "+d" (reg1)
> +		: [addr] "d" (addr), [order] "a" (order), [bogus_cc] "d" (bogus_cc)
>  		: "cc");
>  	if (status)
>  		*status = reg1;