* [PATCH 5/5] ptdump: add state parameter for non-leaf callback [not found] <20240416122254.868007168-1-mbland@motorola.com> @ 2024-04-15 19:51 ` Maxwell Bland 2024-04-16 19:18 ` [PATCH 5/5 RESEND] " Maxwell Bland 2024-04-16 20:11 ` [PATCH 5/5] " Andrew Morton 2024-04-16 19:18 ` [PATCH 3/5 RESEND] mm: add vaddr param to pmd_populate_kernel Maxwell Bland 1 sibling, 2 replies; 6+ messages in thread From: Maxwell Bland @ 2024-04-15 19:51 UTC (permalink / raw) To: linux-mm Cc: Maxwell Bland, Catalin Marinas, Will Deacon, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Aneesh Kumar K.V, Naveen N. Rao, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexander Gordeev, Gerald Schaefer, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Sven Schnelle, Dave Hansen, Andy Lutomirski, Peter Zijlstra, Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86, H. Peter Anvin, Andrew Morton, Ard Biesheuvel, Mark Rutland, Maxwell Bland, Alexandre Ghiti, Yu Chien Peter Lin, Song Shuai, linux-arm-kernel, linux-kernel, linuxppc-dev, linux-riscv, linux-s390 ptdump can now note non-leaf descriptor entries, a useful addition for debugging table descriptor permissions when working on related code Signed-off-by: Maxwell Bland <mbland@motorola.com> --- arch/arm64/mm/ptdump.c | 6 ++++-- arch/powerpc/mm/ptdump/ptdump.c | 2 ++ arch/riscv/mm/ptdump.c | 6 ++++-- arch/s390/mm/dump_pagetables.c | 6 ++++-- arch/x86/mm/dump_pagetables.c | 3 ++- include/linux/ptdump.h | 1 + mm/ptdump.c | 13 +++++++++++++ 7 files changed, 30 insertions(+), 7 deletions(-) diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c index 796231a4fd63..1a6f4a3513e5 100644 --- a/arch/arm64/mm/ptdump.c +++ b/arch/arm64/mm/ptdump.c @@ -299,7 +299,8 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info) .range = (struct ptdump_range[]){ {info->base_addr, end}, {0, 0} - } + }, + .note_non_leaf = false } }; @@ -335,7 +336,8 @@ bool ptdump_check_wx(void) .range = (struct ptdump_range[]) { {_PAGE_OFFSET(vabits_actual), ~0UL}, {0, 0} - } + }, + .note_non_leaf = false } }; diff --git a/arch/powerpc/mm/ptdump/ptdump.c b/arch/powerpc/mm/ptdump/ptdump.c index 9dc239967b77..89e673f5fd3d 100644 --- a/arch/powerpc/mm/ptdump/ptdump.c +++ b/arch/powerpc/mm/ptdump/ptdump.c @@ -307,6 +307,7 @@ static int ptdump_show(struct seq_file *m, void *v) .ptdump = { .note_page = note_page, .range = ptdump_range, + .note_non_leaf = false } }; @@ -340,6 +341,7 @@ bool ptdump_check_wx(void) .ptdump = { .note_page = note_page, .range = ptdump_range, + .note_non_leaf = false } }; diff --git a/arch/riscv/mm/ptdump.c b/arch/riscv/mm/ptdump.c index 1289cc6d3700..b355633afcaf 100644 --- a/arch/riscv/mm/ptdump.c +++ b/arch/riscv/mm/ptdump.c @@ -328,7 +328,8 @@ static void ptdump_walk(struct seq_file *s, struct ptd_mm_info *pinfo) .range = (struct ptdump_range[]) { {pinfo->base_addr, pinfo->end}, {0, 0} - } + }, + .note_non_leaf = false } }; @@ -350,7 +351,8 @@ bool ptdump_check_wx(void) .range = (struct ptdump_range[]) { {KERN_VIRT_START, ULONG_MAX}, {0, 0} - } + }, + .note_non_leaf = false } }; diff --git a/arch/s390/mm/dump_pagetables.c b/arch/s390/mm/dump_pagetables.c index ffd07ed7b4af..6468cfd53e2a 100644 --- a/arch/s390/mm/dump_pagetables.c +++ b/arch/s390/mm/dump_pagetables.c @@ -200,7 +200,8 @@ bool ptdump_check_wx(void) .range = (struct ptdump_range[]) { {.start = 0, .end = max_addr}, {.start = 0, .end = 0}, - } + }, + .note_non_leaf = false }, .seq = NULL, .level = -1, @@ -239,7 +240,8 @@ static int ptdump_show(struct seq_file *m, void *v) .range = (struct ptdump_range[]) { {.start = 0, .end = max_addr}, {.start = 0, .end = 0}, - } + }, + .note_non_leaf = false }, .seq = m, .level = -1, diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index 89079ea73e65..43f00dfb955f 100644 --- a/arch/x86/mm/dump_pagetables.c +++ b/arch/x86/mm/dump_pagetables.c @@ -380,7 +380,8 @@ bool ptdump_walk_pgd_level_core(struct seq_file *m, .ptdump = { .note_page = note_page, .effective_prot = effective_prot, - .range = ptdump_ranges + .range = ptdump_ranges, + .note_non_leaf = false }, .level = -1, .to_dmesg = dmesg, diff --git a/include/linux/ptdump.h b/include/linux/ptdump.h index 8dbd51ea8626..b3e793a5c77f 100644 --- a/include/linux/ptdump.h +++ b/include/linux/ptdump.h @@ -16,6 +16,7 @@ struct ptdump_state { int level, u64 val); void (*effective_prot)(struct ptdump_state *st, int level, u64 val); const struct ptdump_range *range; + bool note_non_leaf; }; bool ptdump_walk_pgd_level_core(struct seq_file *m, diff --git a/mm/ptdump.c b/mm/ptdump.c index 106e1d66e9f9..97da7a765b22 100644 --- a/mm/ptdump.c +++ b/mm/ptdump.c @@ -41,6 +41,9 @@ static int ptdump_pgd_entry(pgd_t *pgd, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 0, pgd_val(val)); + if (st->note_non_leaf && !pgd_leaf(val)) + st->note_page(st, addr, 0, pgd_val(val)); + if (pgd_leaf(val)) { st->note_page(st, addr, 0, pgd_val(val)); walk->action = ACTION_CONTINUE; @@ -64,6 +67,9 @@ static int ptdump_p4d_entry(p4d_t *p4d, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 1, p4d_val(val)); + if (st->note_non_leaf && !p4d_leaf(val)) + st->note_page(st, addr, 1, p4d_val(val)); + if (p4d_leaf(val)) { st->note_page(st, addr, 1, p4d_val(val)); walk->action = ACTION_CONTINUE; @@ -87,6 +93,9 @@ static int ptdump_pud_entry(pud_t *pud, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 2, pud_val(val)); + if (st->note_non_leaf && !pud_leaf(val)) + st->note_page(st, addr, 2, pud_val(val)); + if (pud_leaf(val)) { st->note_page(st, addr, 2, pud_val(val)); walk->action = ACTION_CONTINUE; @@ -108,6 +117,10 @@ static int ptdump_pmd_entry(pmd_t *pmd, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 3, pmd_val(val)); + + if (st->note_non_leaf && !pmd_leaf(val)) + st->note_page(st, addr, 3, pmd_val(val)); + if (pmd_leaf(val)) { st->note_page(st, addr, 3, pmd_val(val)); walk->action = ACTION_CONTINUE; -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 5/5 RESEND] ptdump: add state parameter for non-leaf callback 2024-04-15 19:51 ` [PATCH 5/5] ptdump: add state parameter for non-leaf callback Maxwell Bland @ 2024-04-16 19:18 ` Maxwell Bland 2024-04-16 20:11 ` [PATCH 5/5] " Andrew Morton 1 sibling, 0 replies; 6+ messages in thread From: Maxwell Bland @ 2024-04-16 19:18 UTC (permalink / raw) To: linux-mm Cc: Maxwell Bland, Catalin Marinas, Will Deacon, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Aneesh Kumar K.V, Naveen N. Rao, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexander Gordeev, Gerald Schaefer, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Sven Schnelle, Dave Hansen, Andy Lutomirski, Peter Zijlstra, Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86, H. Peter Anvin, Andrew Morton, Ard Biesheuvel, Mark Rutland, Maxwell Bland, Alexandre Ghiti, Yu Chien Peter Lin, Song Shuai, linux-arm-kernel, linux-kernel, linuxppc-dev, linux-riscv, Mark Rutland, Greg Kroah-Hartman, Christoph Hellwig, Christophe Leroy, David Hildenbrand, Conor Dooley, linux-s390 ptdump can now note non-leaf descriptor entries, a useful addition for debugging table descriptor permissions when working on related code Signed-off-by: Maxwell Bland <mbland@motorola.com> --- arch/arm64/mm/ptdump.c | 6 ++++-- arch/powerpc/mm/ptdump/ptdump.c | 2 ++ arch/riscv/mm/ptdump.c | 6 ++++-- arch/s390/mm/dump_pagetables.c | 6 ++++-- arch/x86/mm/dump_pagetables.c | 3 ++- include/linux/ptdump.h | 1 + mm/ptdump.c | 13 +++++++++++++ 7 files changed, 30 insertions(+), 7 deletions(-) diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c index 796231a4fd63..1a6f4a3513e5 100644 --- a/arch/arm64/mm/ptdump.c +++ b/arch/arm64/mm/ptdump.c @@ -299,7 +299,8 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info) .range = (struct ptdump_range[]){ {info->base_addr, end}, {0, 0} - } + }, + .note_non_leaf = false } }; @@ -335,7 +336,8 @@ bool ptdump_check_wx(void) .range = (struct ptdump_range[]) { {_PAGE_OFFSET(vabits_actual), ~0UL}, {0, 0} - } + }, + .note_non_leaf = false } }; diff --git a/arch/powerpc/mm/ptdump/ptdump.c b/arch/powerpc/mm/ptdump/ptdump.c index 9dc239967b77..89e673f5fd3d 100644 --- a/arch/powerpc/mm/ptdump/ptdump.c +++ b/arch/powerpc/mm/ptdump/ptdump.c @@ -307,6 +307,7 @@ static int ptdump_show(struct seq_file *m, void *v) .ptdump = { .note_page = note_page, .range = ptdump_range, + .note_non_leaf = false } }; @@ -340,6 +341,7 @@ bool ptdump_check_wx(void) .ptdump = { .note_page = note_page, .range = ptdump_range, + .note_non_leaf = false } }; diff --git a/arch/riscv/mm/ptdump.c b/arch/riscv/mm/ptdump.c index 1289cc6d3700..b355633afcaf 100644 --- a/arch/riscv/mm/ptdump.c +++ b/arch/riscv/mm/ptdump.c @@ -328,7 +328,8 @@ static void ptdump_walk(struct seq_file *s, struct ptd_mm_info *pinfo) .range = (struct ptdump_range[]) { {pinfo->base_addr, pinfo->end}, {0, 0} - } + }, + .note_non_leaf = false } }; @@ -350,7 +351,8 @@ bool ptdump_check_wx(void) .range = (struct ptdump_range[]) { {KERN_VIRT_START, ULONG_MAX}, {0, 0} - } + }, + .note_non_leaf = false } }; diff --git a/arch/s390/mm/dump_pagetables.c b/arch/s390/mm/dump_pagetables.c index ffd07ed7b4af..6468cfd53e2a 100644 --- a/arch/s390/mm/dump_pagetables.c +++ b/arch/s390/mm/dump_pagetables.c @@ -200,7 +200,8 @@ bool ptdump_check_wx(void) .range = (struct ptdump_range[]) { {.start = 0, .end = max_addr}, {.start = 0, .end = 0}, - } + }, + .note_non_leaf = false }, .seq = NULL, .level = -1, @@ -239,7 +240,8 @@ static int ptdump_show(struct seq_file *m, void *v) .range = (struct ptdump_range[]) { {.start = 0, .end = max_addr}, {.start = 0, .end = 0}, - } + }, + .note_non_leaf = false }, .seq = m, .level = -1, diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index 89079ea73e65..43f00dfb955f 100644 --- a/arch/x86/mm/dump_pagetables.c +++ b/arch/x86/mm/dump_pagetables.c @@ -380,7 +380,8 @@ bool ptdump_walk_pgd_level_core(struct seq_file *m, .ptdump = { .note_page = note_page, .effective_prot = effective_prot, - .range = ptdump_ranges + .range = ptdump_ranges, + .note_non_leaf = false }, .level = -1, .to_dmesg = dmesg, diff --git a/include/linux/ptdump.h b/include/linux/ptdump.h index 8dbd51ea8626..b3e793a5c77f 100644 --- a/include/linux/ptdump.h +++ b/include/linux/ptdump.h @@ -16,6 +16,7 @@ struct ptdump_state { int level, u64 val); void (*effective_prot)(struct ptdump_state *st, int level, u64 val); const struct ptdump_range *range; + bool note_non_leaf; }; bool ptdump_walk_pgd_level_core(struct seq_file *m, diff --git a/mm/ptdump.c b/mm/ptdump.c index 106e1d66e9f9..97da7a765b22 100644 --- a/mm/ptdump.c +++ b/mm/ptdump.c @@ -41,6 +41,9 @@ static int ptdump_pgd_entry(pgd_t *pgd, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 0, pgd_val(val)); + if (st->note_non_leaf && !pgd_leaf(val)) + st->note_page(st, addr, 0, pgd_val(val)); + if (pgd_leaf(val)) { st->note_page(st, addr, 0, pgd_val(val)); walk->action = ACTION_CONTINUE; @@ -64,6 +67,9 @@ static int ptdump_p4d_entry(p4d_t *p4d, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 1, p4d_val(val)); + if (st->note_non_leaf && !p4d_leaf(val)) + st->note_page(st, addr, 1, p4d_val(val)); + if (p4d_leaf(val)) { st->note_page(st, addr, 1, p4d_val(val)); walk->action = ACTION_CONTINUE; @@ -87,6 +93,9 @@ static int ptdump_pud_entry(pud_t *pud, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 2, pud_val(val)); + if (st->note_non_leaf && !pud_leaf(val)) + st->note_page(st, addr, 2, pud_val(val)); + if (pud_leaf(val)) { st->note_page(st, addr, 2, pud_val(val)); walk->action = ACTION_CONTINUE; @@ -108,6 +117,10 @@ static int ptdump_pmd_entry(pmd_t *pmd, unsigned long addr, if (st->effective_prot) st->effective_prot(st, 3, pmd_val(val)); + + if (st->note_non_leaf && !pmd_leaf(val)) + st->note_page(st, addr, 3, pmd_val(val)); + if (pmd_leaf(val)) { st->note_page(st, addr, 3, pmd_val(val)); walk->action = ACTION_CONTINUE; -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] ptdump: add state parameter for non-leaf callback 2024-04-15 19:51 ` [PATCH 5/5] ptdump: add state parameter for non-leaf callback Maxwell Bland 2024-04-16 19:18 ` [PATCH 5/5 RESEND] " Maxwell Bland @ 2024-04-16 20:11 ` Andrew Morton 2024-04-16 21:01 ` Maxwell Bland 1 sibling, 1 reply; 6+ messages in thread From: Andrew Morton @ 2024-04-16 20:11 UTC (permalink / raw) To: Maxwell Bland Cc: linux-mm, Catalin Marinas, Will Deacon, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Aneesh Kumar K.V, Naveen N. Rao, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexander Gordeev, Gerald Schaefer, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Sven Schnelle, Dave Hansen, Andy Lutomirski, Peter Zijlstra, Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86, H. Peter Anvin, Ard Biesheuvel, Mark Rutland, Alexandre Ghiti, Yu Chien Peter Lin, Song Shuai, linux-arm-kernel, linux-kernel, linuxppc-dev, linux-riscv, linux-s390 On Mon, 15 Apr 2024 14:51:32 -0500 Maxwell Bland <mbland@motorola.com> wrote: > ptdump can now note non-leaf descriptor entries, a useful addition for > debugging table descriptor permissions when working on related code > > Signed-off-by: Maxwell Bland <mbland@motorola.com> > --- > arch/arm64/mm/ptdump.c | 6 ++++-- > arch/powerpc/mm/ptdump/ptdump.c | 2 ++ > arch/riscv/mm/ptdump.c | 6 ++++-- > arch/s390/mm/dump_pagetables.c | 6 ++++-- > arch/x86/mm/dump_pagetables.c | 3 ++- > include/linux/ptdump.h | 1 + > mm/ptdump.c | 13 +++++++++++++ > 7 files changed, 30 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c > index 796231a4fd63..1a6f4a3513e5 100644 > --- a/arch/arm64/mm/ptdump.c > +++ b/arch/arm64/mm/ptdump.c > @@ -299,7 +299,8 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info) > .range = (struct ptdump_range[]){ > {info->base_addr, end}, > {0, 0} > - } > + }, > + .note_non_leaf = false > } It would be acceptable to omit all of these and rely upon the runtime zeroing which the compiler will emit. Documentation/arch/arm64/ptdump.rst might need updating. Please include sample output in the changelog so we can better understand the user's view of this change. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] ptdump: add state parameter for non-leaf callback 2024-04-16 20:11 ` [PATCH 5/5] " Andrew Morton @ 2024-04-16 21:01 ` Maxwell Bland 0 siblings, 0 replies; 6+ messages in thread From: Maxwell Bland @ 2024-04-16 21:01 UTC (permalink / raw) To: Andrew Morton Cc: linux-mm@kvack.org, Catalin Marinas, Will Deacon, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Aneesh Kumar K.V, Naveen N. Rao, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexander Gordeev, Gerald Schaefer, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Sven Schnelle, Dave Hansen, Andy Lutomirski, Peter Zijlstra, Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86@kernel.org, H. Peter Anvin, Ard Biesheuvel, Mark Rutland, Alexandre Ghiti, Yu Chien Peter Lin, Song Shuai, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org > On Tuesday, April 16, 2024 3:11 PM, Andrew Morton wrote: > On Mon, 15 Apr 2024 14:51:32 -0500 Maxwell Bland <mbland@motorola.com> > wrote: > > > arch/arm64/mm/ptdump.c | 6 ++++-- > > arch/powerpc/mm/ptdump/ptdump.c | 2 ++ > > arch/riscv/mm/ptdump.c | 6 ++++-- > > arch/s390/mm/dump_pagetables.c | 6 ++++-- > > arch/x86/mm/dump_pagetables.c | 3 ++- > > include/linux/ptdump.h | 1 + > > mm/ptdump.c | 13 +++++++++++++ > > 7 files changed, 30 insertions(+), 7 deletions(-) > > > > diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c > > index 796231a4fd63..1a6f4a3513e5 100644 > > --- a/arch/arm64/mm/ptdump.c > > +++ b/arch/arm64/mm/ptdump.c > > @@ -299,7 +299,8 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info > *info) > > .range = (struct ptdump_range[]){ > > {info->base_addr, end}, > > {0, 0} > > - } > > + }, > > + .note_non_leaf = false > > } > > It would be acceptable to omit all of these and rely upon the runtime > zeroing which the compiler will emit. Ah, thank you for the pointer to C99 6.7.8.21. I had always figured since structs are stack allocated they are potentially non-initialized! > Documentation/arch/arm64/ptdump.rst might need updating. > > Please include sample output in the changelog so we can better > understand the user's view of this change. Thanks, I will do both in the next few days everything permitting! Right now this patch results in no change until note_non_leaf = true is adopted for each arch. My plan: I will polish then include output of my personal fixes for arm64. Specifically, printing expanded PMD flags and tab indenting the layout according to each level. Hopefully just adding arm64 support for now is OK, unless maybe we want to default this to true on all arches? IMO default true would be sweet, but I wasn't sure everyone would agree. BRs, Maxwell Bland ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/5 RESEND] mm: add vaddr param to pmd_populate_kernel [not found] <20240416122254.868007168-1-mbland@motorola.com> 2024-04-15 19:51 ` [PATCH 5/5] ptdump: add state parameter for non-leaf callback Maxwell Bland @ 2024-04-16 19:18 ` Maxwell Bland 2024-04-05 18:37 ` [PATCH 3/5] " Maxwell Bland 1 sibling, 1 reply; 6+ messages in thread From: Maxwell Bland @ 2024-04-16 19:18 UTC (permalink / raw) To: linux-mm Cc: Maxwell Bland, Richard Henderson, Ivan Kokshaysky, Matt Turner, Vineet Gupta, Alexander Potapenko, Marco Elver, Dmitry Vyukov, Russell King, Andrey Ryabinin, Andrey Konovalov, Vincenzo Frascino, Catalin Marinas, Will Deacon, Guo Ren, Brian Cain, Huacai Chen, WANG Xuerui, Geert Uytterhoeven, Sam Creasey, Michal Simek, Thomas Bogendoerfer, Dinh Nguyen, Jonas Bonn, Stefan Kristiansson, Stafford Horne, James E.J. Bottomley, Helge Deller, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Aneesh Kumar K.V, Naveen N. Rao, Paul Walmsley, Palmer Dabbelt, Albert Ou, Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Christian Borntraeger, Sven Schnelle, Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz, David S. Miller, Andreas Larsson, Richard Weinberger, Anton Ivanov, Johannes Berg, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin, Andy Lutomirski, Peter Zijlstra, Chris Zankel, Max Filippov, Andrew Morton, Muchun Song, Dennis Zhou, Tejun Heo, Christoph Lameter, Maxwell Bland, Linus Walleij, David Hildenbrand, Arnd Bergmann, Ard Biesheuvel, Ryan Roberts, Mark Rutland, Nikhil V, Rick Edgecombe, Baolin Wang, Bibo Mao, Tianrui Zhao, Randy Dunlap, Vlastimil Babka, Kent Overstreet, Peter Xu, Jiangfeng Xiao, Alexandre Ghiti, Jisheng Zhang, Conor Dooley, Mason Huo, Sia Jee Heng, Song Shuai, Gerald Schaefer, Qi Zheng, Hugh Dickins, Jason Gunthorpe, Breno Leitao, Josh Poimboeuf, linux-alpha, linux-kernel, linux-snps-arc, kasan-dev, linux-arm-kernel, linux-csky, linux-hexagon, loongarch, linux-m68k, linux-mips, kvm, linux-openrisc, linux-parisc, linuxppc-dev, linux-riscv, linux-s390, linux-sh, sparclinux, Mark Rutland, Greg Kroah-Hartman, Christoph Hellwig, Christophe Leroy, David Hildenbrand, Conor Dooley, linux-um This patch affords each architecture the ability to condition the population of page middle directory entries on the virtual address being allocated, matching existing PTE infrastructure, easing the necessity of performing a reverse page table walk in cases where the population context is not readily accessible, i.e. dynamic vmalloc calls on arm64. To achieve this goal, it modifies every call and implementation of the pmd_populate_kernel function across architectures, ensuring uniform adoption across all kernel deployments. Signed-off-by: Maxwell Bland <mbland@motorola.com> --- Hi all, Thank you for taking the time to review this change. This effects many subarchitectures so the maintainers list is large. Apologies in advance if there is a specific maintainer I should have spoken with directly for deployment across subprojects. The reason for such a sweeping change is from lore.kernel.org/all/cf5409c3-254a-459b-8969-429db2ec6439@redhat.com It is my understanding as well that some subarchitectures may have separate "next" or development branches ahead of the main upstream linux. Please let me know if a cherry-pick to that branch is desired and I will do my best to check out and deploy it as possible. arch/alpha/include/asm/pgalloc.h | 5 +++-- arch/arc/include/asm/pgalloc.h | 3 ++- arch/arc/mm/highmem.c | 2 +- arch/arm/include/asm/kfence.h | 2 +- arch/arm/include/asm/pgalloc.h | 3 ++- arch/arm/mm/kasan_init.c | 2 +- arch/arm/mm/mmu.c | 2 +- arch/arm64/include/asm/pgalloc.h | 3 ++- arch/arm64/mm/trans_pgd.c | 2 +- arch/csky/include/asm/pgalloc.h | 2 +- arch/hexagon/include/asm/pgalloc.h | 2 +- arch/loongarch/include/asm/pgalloc.h | 3 ++- arch/loongarch/mm/init.c | 2 +- arch/loongarch/mm/kasan_init.c | 2 +- arch/m68k/include/asm/mcf_pgalloc.h | 2 +- arch/m68k/include/asm/motorola_pgalloc.h | 3 ++- arch/m68k/include/asm/sun3_pgalloc.h | 3 ++- arch/microblaze/include/asm/pgalloc.h | 2 +- arch/mips/include/asm/pgalloc.h | 2 +- arch/mips/kvm/mmu.c | 2 +- arch/nios2/include/asm/pgalloc.h | 2 +- arch/openrisc/include/asm/pgalloc.h | 2 +- arch/parisc/include/asm/pgalloc.h | 5 +++-- arch/parisc/mm/init.c | 6 +++--- arch/powerpc/include/asm/book3s/32/pgalloc.h | 2 +- arch/powerpc/include/asm/book3s/64/pgalloc.h | 2 +- arch/powerpc/include/asm/nohash/32/pgalloc.h | 2 +- arch/powerpc/include/asm/nohash/64/pgalloc.h | 2 +- arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +- arch/powerpc/mm/kasan/init_32.c | 4 ++-- arch/powerpc/mm/kasan/init_book3e_64.c | 9 ++++++--- arch/powerpc/mm/kasan/init_book3s_64.c | 7 +++++-- arch/powerpc/mm/nohash/book3e_pgtable.c | 2 +- arch/powerpc/mm/pgtable_32.c | 4 ++-- arch/riscv/include/asm/pgalloc.h | 2 +- arch/riscv/kernel/hibernate.c | 2 +- arch/s390/include/asm/pgalloc.h | 2 +- arch/sh/include/asm/pgalloc.h | 2 +- arch/sh/mm/init.c | 2 +- arch/sparc/include/asm/pgalloc_32.h | 3 ++- arch/sparc/include/asm/pgalloc_64.h | 4 ++-- arch/sparc/mm/init_64.c | 8 ++++---- arch/um/include/asm/pgalloc.h | 4 ++-- arch/x86/include/asm/pgalloc.h | 3 ++- arch/x86/mm/init_64.c | 14 +++++++++++--- arch/x86/mm/ioremap.c | 2 +- arch/x86/mm/kasan_init_64.c | 2 +- arch/xtensa/include/asm/pgalloc.h | 2 +- include/linux/mm.h | 4 ++-- mm/hugetlb_vmemmap.c | 4 ++-- mm/kasan/init.c | 14 +++++++++----- mm/memory.c | 4 ++-- mm/percpu.c | 2 +- mm/pgalloc-track.h | 3 ++- mm/sparse-vmemmap.c | 2 +- 55 files changed, 107 insertions(+), 78 deletions(-) diff --git a/arch/alpha/include/asm/pgalloc.h b/arch/alpha/include/asm/pgalloc.h index 68be7adbfe58..1d3d86cad3cc 100644 --- a/arch/alpha/include/asm/pgalloc.h +++ b/arch/alpha/include/asm/pgalloc.h @@ -7,7 +7,7 @@ #include <asm-generic/pgalloc.h> -/* +/* * Allocate and free page tables. The xxx_kernel() versions are * used to allocate a kernel page table - this turns on ASN bits * if any. @@ -20,7 +20,8 @@ pmd_populate(struct mm_struct *mm, pmd_t *pmd, pgtable_t pte) } static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { pmd_set(pmd, pte); } diff --git a/arch/arc/include/asm/pgalloc.h b/arch/arc/include/asm/pgalloc.h index 096b8ef58edb..c0ebfa44b204 100644 --- a/arch/arc/include/asm/pgalloc.h +++ b/arch/arc/include/asm/pgalloc.h @@ -34,7 +34,8 @@ #include <asm-generic/pgalloc.h> static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { /* * The cast to long below is OK in 32-bit PAE40 regime with long long pte diff --git a/arch/arc/mm/highmem.c b/arch/arc/mm/highmem.c index c79912a6b196..2d327cf35722 100644 --- a/arch/arc/mm/highmem.c +++ b/arch/arc/mm/highmem.c @@ -57,7 +57,7 @@ static noinline pte_t * __init alloc_kmap_pgtable(unsigned long kvaddr) panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__, PAGE_SIZE, PAGE_SIZE); - pmd_populate_kernel(&init_mm, pmd_k, pte_k); + pmd_populate_kernel(&init_mm, pmd_k, pte_k, kvaddr); return pte_k; } diff --git a/arch/arm/include/asm/kfence.h b/arch/arm/include/asm/kfence.h index 7980d0f2271f..dd4e4325d354 100644 --- a/arch/arm/include/asm/kfence.h +++ b/arch/arm/include/asm/kfence.h @@ -19,7 +19,7 @@ static inline int split_pmd_page(pmd_t *pmd, unsigned long addr) for (i = 0; i < PTRS_PER_PTE; i++) set_pte_ext(pte + i, pfn_pte(pfn + i, PAGE_KERNEL), 0); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, addr); flush_tlb_kernel_range(addr, addr + PMD_SIZE); return 0; diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h index a17f01235c29..0a88346db17e 100644 --- a/arch/arm/include/asm/pgalloc.h +++ b/arch/arm/include/asm/pgalloc.h @@ -122,7 +122,8 @@ static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t pte, * Ensure that we always set both PMD entries. */ static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep, + unsigned long vaddr) { /* * The pmd must be loaded with the physical address of the PTE table diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c index 111d4f703136..9b3af2dce71e 100644 --- a/arch/arm/mm/kasan_init.c +++ b/arch/arm/mm/kasan_init.c @@ -111,7 +111,7 @@ static void __init kasan_pmd_populate(pud_t *pudp, unsigned long addr, __func__, addr); return; } - pmd_populate_kernel(&init_mm, pmdp, p); + pmd_populate_kernel(&init_mm, pmdp, p, addr); flush_pmd_entry(pmdp); } diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index c24e29c0b9a4..3cfed8dc4a19 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -384,7 +384,7 @@ void __init early_fixmap_init(void) != FIXADDR_TOP >> PMD_SHIFT); pmd = fixmap_pmd(FIXADDR_TOP); - pmd_populate_kernel(&init_mm, pmd, bm_pte); + pmd_populate_kernel(&init_mm, pmd, bm_pte, __fix_to_virt(FIXADDR_TOP)); pte_offset_fixmap = pte_offset_early_fixmap; } diff --git a/arch/arm64/include/asm/pgalloc.h b/arch/arm64/include/asm/pgalloc.h index 8ff5f2a2579e..5785272144e8 100644 --- a/arch/arm64/include/asm/pgalloc.h +++ b/arch/arm64/include/asm/pgalloc.h @@ -124,7 +124,8 @@ static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t ptep, * of the mm address space. */ static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep, + unsigned long vaddr) { VM_BUG_ON(mm && mm != &init_mm); __pmd_populate(pmdp, __pa(ptep), PMD_TYPE_TABLE | PMD_TABLE_UXN); diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c index 5139a28130c0..f84244d13099 100644 --- a/arch/arm64/mm/trans_pgd.c +++ b/arch/arm64/mm/trans_pgd.c @@ -69,7 +69,7 @@ static int copy_pte(struct trans_pgd_info *info, pmd_t *dst_pmdp, dst_ptep = trans_alloc(info); if (!dst_ptep) return -ENOMEM; - pmd_populate_kernel(NULL, dst_pmdp, dst_ptep); + pmd_populate_kernel(NULL, dst_pmdp, dst_ptep, addr); dst_ptep = pte_offset_kernel(dst_pmdp, start); src_ptep = pte_offset_kernel(src_pmdp, start); diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h index 9c84c9012e53..f2c244c58acf 100644 --- a/arch/csky/include/asm/pgalloc.h +++ b/arch/csky/include/asm/pgalloc.h @@ -11,7 +11,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd(__pa(pte))); } diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h index 55988625e6fb..2be773a5ffeb 100644 --- a/arch/hexagon/include/asm/pgalloc.h +++ b/arch/hexagon/include/asm/pgalloc.h @@ -62,7 +62,7 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, * kernel map of the active thread who's calling pmd_populate_kernel... */ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { extern spinlock_t kmap_gen_lock; pmd_t *ppmd; diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h index 4e2d6b7ca2ee..6384391e69bd 100644 --- a/arch/loongarch/include/asm/pgalloc.h +++ b/arch/loongarch/include/asm/pgalloc.h @@ -13,7 +13,8 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, - pmd_t *pmd, pte_t *pte) + pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c index 4dd53427f657..b8952899b120 100644 --- a/arch/loongarch/mm/init.c +++ b/arch/loongarch/mm/init.c @@ -200,7 +200,7 @@ pte_t * __init populate_kernel_pte(unsigned long addr) pte = memblock_alloc(PAGE_SIZE, PAGE_SIZE); if (!pte) panic("%s: Failed to allocate memory\n", __func__); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, addr); } return pte_offset_kernel(pmd, addr); diff --git a/arch/loongarch/mm/kasan_init.c b/arch/loongarch/mm/kasan_init.c index c608adc99845..51d40ff43aa9 100644 --- a/arch/loongarch/mm/kasan_init.c +++ b/arch/loongarch/mm/kasan_init.c @@ -110,7 +110,7 @@ static pte_t *__init kasan_pte_offset(pmd_t *pmdp, unsigned long addr, int node, __pa_symbol(kasan_early_shadow_pte) : kasan_alloc_zeroed_page(node); if (!early) memcpy(__va(pte_phys), kasan_early_shadow_pte, sizeof(kasan_early_shadow_pte)); - pmd_populate_kernel(NULL, pmdp, (pte_t *)__va(pte_phys)); + pmd_populate_kernel(NULL, pmdp, (pte_t *)__va(pte_phys), addr); } return pte_offset_kernel(pmdp, addr); diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h index 302c5bf67179..989a1aaa8aa1 100644 --- a/arch/m68k/include/asm/mcf_pgalloc.h +++ b/arch/m68k/include/asm/mcf_pgalloc.h @@ -30,7 +30,7 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) #define pmd_populate(mm, pmd, pte) (pmd_val(*pmd) = (unsigned long)(pte)) -#define pmd_populate_kernel pmd_populate +#define pmd_populate_kernel(mm, pmd, pte, vaddr) pmd_populate(mm, pmd, pte) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pgtable, unsigned long address) diff --git a/arch/m68k/include/asm/motorola_pgalloc.h b/arch/m68k/include/asm/motorola_pgalloc.h index 74a817d9387f..74aec6965981 100644 --- a/arch/m68k/include/asm/motorola_pgalloc.h +++ b/arch/m68k/include/asm/motorola_pgalloc.h @@ -79,7 +79,8 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) } -static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, + pte_t *pte, unsigned long vaddr) { pmd_set(pmd, pte); } diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index 4a137eecb6fe..550283e8bf4d 100644 --- a/arch/m68k/include/asm/sun3_pgalloc.h +++ b/arch/m68k/include/asm/sun3_pgalloc.h @@ -23,7 +23,8 @@ do { \ tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) -static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, + pte_t *pte, unsigned long vaddr) { pmd_val(*pmd) = __pa((unsigned long)pte); } diff --git a/arch/microblaze/include/asm/pgalloc.h b/arch/microblaze/include/asm/pgalloc.h index 6c33b05f730f..b3cc2cd8fc50 100644 --- a/arch/microblaze/include/asm/pgalloc.h +++ b/arch/microblaze/include/asm/pgalloc.h @@ -35,7 +35,7 @@ extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm); #define pmd_populate(mm, pmd, pte) \ (pmd_val(*(pmd)) = (unsigned long)page_address(pte)) -#define pmd_populate_kernel(mm, pmd, pte) \ +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ (pmd_val(*(pmd)) = (unsigned long) (pte)) #endif /* _ASM_MICROBLAZE_PGALLOC_H */ diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index f4440edcd8fe..fb71c8776a04 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -19,7 +19,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c index 467ee6b95ae1..47f48929a124 100644 --- a/arch/mips/kvm/mmu.c +++ b/arch/mips/kvm/mmu.c @@ -133,7 +133,7 @@ static pte_t *kvm_mips_walk_pgd(pgd_t *pgd, struct kvm_mmu_memory_cache *cache, return NULL; new_pte = kvm_mmu_memory_cache_alloc(cache); clear_page(new_pte); - pmd_populate_kernel(NULL, pmd, new_pte); + pmd_populate_kernel(NULL, pmd, new_pte, addr); } return pte_offset_kernel(pmd, addr); } diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h index ce6bb8e74271..ea99d36a6fdd 100644 --- a/arch/nios2/include/asm/pgalloc.h +++ b/arch/nios2/include/asm/pgalloc.h @@ -15,7 +15,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/openrisc/include/asm/pgalloc.h b/arch/openrisc/include/asm/pgalloc.h index c6a73772a546..304cf8955bec 100644 --- a/arch/openrisc/include/asm/pgalloc.h +++ b/arch/openrisc/include/asm/pgalloc.h @@ -25,7 +25,7 @@ extern int mem_init_done; -#define pmd_populate_kernel(mm, pmd, pte) \ +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ set_pmd(pmd, __pmd(_KERNPG_TABLE + __pa(pte))) static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, diff --git a/arch/parisc/include/asm/pgalloc.h b/arch/parisc/include/asm/pgalloc.h index e3e142b1c5c5..cba92c90a62a 100644 --- a/arch/parisc/include/asm/pgalloc.h +++ b/arch/parisc/include/asm/pgalloc.h @@ -61,13 +61,14 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) #endif static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((PxD_FLAG_PRESENT | PxD_FLAG_VALID) + (__u32)(__pa((unsigned long)pte) >> PxD_VALUE_SHIFT))); } #define pmd_populate(mm, pmd, pte_page) \ - pmd_populate_kernel(mm, pmd, page_address(pte_page)) + pmd_populate_kernel(mm, pmd, page_address(pte_page), \ + (unsigned long)page_to_virt(pte_page)) #endif diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c index f876af56e13f..1cf3aae67023 100644 --- a/arch/parisc/mm/init.c +++ b/arch/parisc/mm/init.c @@ -390,7 +390,7 @@ static void __ref map_pages(unsigned long start_vaddr, pg_table = memblock_alloc(PAGE_SIZE, PAGE_SIZE); if (!pg_table) panic("page table allocation failed\n"); - pmd_populate_kernel(NULL, pmd, pg_table); + pmd_populate_kernel(NULL, pmd, pg_table, vaddr); } pg_table = pte_offset_kernel(pmd, vaddr); @@ -481,7 +481,7 @@ void free_initmem(void) /* finally dump all the instructions which were cached, since the * pages are no-longer executable */ flush_icache_range(init_begin, init_end); - + free_initmem_default(POISON_FREE_INITMEM); /* set up a new led state on systems shipped LED State panel */ @@ -694,7 +694,7 @@ static void __init fixmap_init(void) if (!pte) panic("fixmap: pte allocation failed.\n"); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, addr); addr += PAGE_SIZE; } while (addr < end); diff --git a/arch/powerpc/include/asm/book3s/32/pgalloc.h b/arch/powerpc/include/asm/book3s/32/pgalloc.h index dc5c039eb28e..b85105158686 100644 --- a/arch/powerpc/include/asm/book3s/32/pgalloc.h +++ b/arch/powerpc/include/asm/book3s/32/pgalloc.h @@ -26,7 +26,7 @@ static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) /* #define pgd_populate(mm, pmd, pte) BUG() */ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { *pmdp = __pmd(__pa(pte) | _PMD_PRESENT); } diff --git a/arch/powerpc/include/asm/book3s/64/pgalloc.h b/arch/powerpc/include/asm/book3s/64/pgalloc.h index dd2cff53a111..061c4be60166 100644 --- a/arch/powerpc/include/asm/book3s/64/pgalloc.h +++ b/arch/powerpc/include/asm/book3s/64/pgalloc.h @@ -156,7 +156,7 @@ static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, } static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { *pmd = __pmd(__pgtable_ptr_val(pte) | PMD_VAL_BITS); } diff --git a/arch/powerpc/include/asm/nohash/32/pgalloc.h b/arch/powerpc/include/asm/nohash/32/pgalloc.h index 11eac371e7e0..2788ce005b95 100644 --- a/arch/powerpc/include/asm/nohash/32/pgalloc.h +++ b/arch/powerpc/include/asm/nohash/32/pgalloc.h @@ -15,7 +15,7 @@ /* #define pgd_populate(mm, pmd, pte) BUG() */ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { if (IS_ENABLED(CONFIG_BOOKE)) *pmdp = __pmd((unsigned long)pte | _PMD_PRESENT); diff --git a/arch/powerpc/include/asm/nohash/64/pgalloc.h b/arch/powerpc/include/asm/nohash/64/pgalloc.h index e50b211becb3..d069443b4014 100644 --- a/arch/powerpc/include/asm/nohash/64/pgalloc.h +++ b/arch/powerpc/include/asm/nohash/64/pgalloc.h @@ -37,7 +37,7 @@ static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd) } static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { pmd_set(pmd, (unsigned long)pte); } diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c index 15e88f1439ec..a70063cd6f64 100644 --- a/arch/powerpc/mm/book3s64/radix_pgtable.c +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c @@ -104,7 +104,7 @@ static int early_map_kernel_page(unsigned long ea, unsigned long pa, if (!pmd_present(*pmdp)) { ptep = early_alloc_pgtable(PAGE_SIZE, nid, region_start, region_end); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, ea); } ptep = pte_offset_kernel(pmdp, ea); diff --git a/arch/powerpc/mm/kasan/init_32.c b/arch/powerpc/mm/kasan/init_32.c index aa9aa11927b2..22df07fd1af5 100644 --- a/arch/powerpc/mm/kasan/init_32.c +++ b/arch/powerpc/mm/kasan/init_32.c @@ -47,7 +47,7 @@ int __init kasan_init_shadow_page_tables(unsigned long k_start, unsigned long k_ if (!new) return -ENOMEM; kasan_populate_pte(new, PAGE_KERNEL); - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, k_cur); } return 0; } @@ -187,6 +187,6 @@ void __init kasan_early_init(void) do { next = pgd_addr_end(addr, end); - pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte); + pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte, addr); } while (pmd++, addr = next, addr != end); } diff --git a/arch/powerpc/mm/kasan/init_book3e_64.c b/arch/powerpc/mm/kasan/init_book3e_64.c index 11519e88dc6b..05ccdb88ff51 100644 --- a/arch/powerpc/mm/kasan/init_book3e_64.c +++ b/arch/powerpc/mm/kasan/init_book3e_64.c @@ -54,7 +54,7 @@ static int __init kasan_map_kernel_page(unsigned long ea, unsigned long pa, pgpr if (kasan_pte_table(*pmdp)) { ptep = memblock_alloc(PTE_TABLE_SIZE, PTE_TABLE_SIZE); memcpy(ptep, kasan_early_shadow_pte, PTE_TABLE_SIZE); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, ea); } ptep = pte_offset_kernel(pmdp, ea); @@ -93,9 +93,12 @@ void __init kasan_early_init(void) __set_pte_at(&init_mm, (unsigned long)kasan_early_shadow_page, &kasan_early_shadow_pte[i], zero_pte, 0); - for (i = 0; i < PTRS_PER_PMD; i++) + addr = KASAN_SHADOW_START + for (i = 0; i < PTRS_PER_PMD; i++) { pmd_populate_kernel(&init_mm, &kasan_early_shadow_pmd[i], - kasan_early_shadow_pte); + kasan_early_shadow_pte, addr); + addr += PMD_SIZE; + } for (i = 0; i < PTRS_PER_PUD; i++) pud_populate(&init_mm, &kasan_early_shadow_pud[i], diff --git a/arch/powerpc/mm/kasan/init_book3s_64.c b/arch/powerpc/mm/kasan/init_book3s_64.c index 9300d641cf9a..79569734dc29 100644 --- a/arch/powerpc/mm/kasan/init_book3s_64.c +++ b/arch/powerpc/mm/kasan/init_book3s_64.c @@ -55,6 +55,7 @@ void __init kasan_init(void) phys_addr_t start, end; u64 i; pte_t zero_pte = pfn_pte(virt_to_pfn(kasan_early_shadow_page), PAGE_KERNEL); + void *vaddr_start = __va(start); if (!early_radix_enabled()) { pr_warn("KASAN not enabled as it requires radix!"); @@ -68,9 +69,11 @@ void __init kasan_init(void) __set_pte_at(&init_mm, (unsigned long)kasan_early_shadow_page, &kasan_early_shadow_pte[i], zero_pte, 0); - for (i = 0; i < PTRS_PER_PMD; i++) + for (i = 0; i < PTRS_PER_PMD; i++) { pmd_populate_kernel(&init_mm, &kasan_early_shadow_pmd[i], - kasan_early_shadow_pte); + kasan_early_shadow_pte, + vaddr_start + i * PMD_SIZE); + } for (i = 0; i < PTRS_PER_PUD; i++) pud_populate(&init_mm, &kasan_early_shadow_pud[i], diff --git a/arch/powerpc/mm/nohash/book3e_pgtable.c b/arch/powerpc/mm/nohash/book3e_pgtable.c index 1c5e4ecbebeb..930bdd7a3774 100644 --- a/arch/powerpc/mm/nohash/book3e_pgtable.c +++ b/arch/powerpc/mm/nohash/book3e_pgtable.c @@ -107,7 +107,7 @@ int __ref map_kernel_page(unsigned long ea, phys_addr_t pa, pgprot_t prot) pmdp = pmd_offset(pudp, ea); if (!pmd_present(*pmdp)) { ptep = early_alloc_pgtable(PTE_TABLE_SIZE); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, ea); } ptep = pte_offset_kernel(pmdp, ea); } diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c index cfd622ebf774..e6fbaf3e9072 100644 --- a/arch/powerpc/mm/pgtable_32.c +++ b/arch/powerpc/mm/pgtable_32.c @@ -43,7 +43,7 @@ notrace void __init early_ioremap_init(void) for (; (s32)(FIXADDR_TOP - addr) > 0; addr += PGDIR_SIZE, ptep += PTRS_PER_PTE, pmdp++) - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, addr); early_ioremap_setup(); } @@ -64,7 +64,7 @@ pte_t __init *early_pte_alloc_kernel(pmd_t *pmdp, unsigned long va) if (pmd_none(*pmdp)) { pte_t *ptep = early_alloc_pgtable(PTE_FRAG_SIZE); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, va); } return pte_offset_kernel(pmdp, va); } diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h index deaf971253a2..d619daeded7f 100644 --- a/arch/riscv/include/asm/pgalloc.h +++ b/arch/riscv/include/asm/pgalloc.h @@ -16,7 +16,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, - pmd_t *pmd, pte_t *pte) + pmd_t *pmd, pte_t *pte, unsigned long vaddr) { unsigned long pfn = virt_to_pfn(pte); diff --git a/arch/riscv/kernel/hibernate.c b/arch/riscv/kernel/hibernate.c index 671b686c0158..085123ad4fa8 100644 --- a/arch/riscv/kernel/hibernate.c +++ b/arch/riscv/kernel/hibernate.c @@ -176,7 +176,7 @@ static int temp_pgtable_map_pte(pmd_t *dst_pmdp, pmd_t *src_pmdp, unsigned long if (!dst_ptep) return -ENOMEM; - pmd_populate_kernel(NULL, dst_pmdp, dst_ptep); + pmd_populate_kernel(NULL, dst_pmdp, dst_ptep, 0); } dst_ptep = pte_offset_kernel(dst_pmdp, start); diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h index 7b84ef6dc4b6..4143b3f9d610 100644 --- a/arch/s390/include/asm/pgalloc.h +++ b/arch/s390/include/asm/pgalloc.h @@ -131,7 +131,7 @@ static inline void pmd_populate(struct mm_struct *mm, set_pmd(pmd, __pmd(_SEGMENT_ENTRY | __pa(pte))); } -#define pmd_populate_kernel(mm, pmd, pte) pmd_populate(mm, pmd, pte) +#define pmd_populate_kernel(mm, pmd, pte, vaddr) pmd_populate(mm, pmd, pte) /* * page table entry allocation/free routines. diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index 5d8577ab1591..04b29eb9712b 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -21,7 +21,7 @@ extern void pmd_free(struct mm_struct *mm, pmd_t *pmd); #endif static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c index bf1b54055316..c862572dbec8 100644 --- a/arch/sh/mm/init.c +++ b/arch/sh/mm/init.c @@ -157,7 +157,7 @@ static pte_t * __init one_page_table_init(pmd_t *pmd) if (!pte) panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__, PAGE_SIZE, PAGE_SIZE); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, 0); BUG_ON(pte != pte_offset_kernel(pmd, 0)); } diff --git a/arch/sparc/include/asm/pgalloc_32.h b/arch/sparc/include/asm/pgalloc_32.h index 4f73e87b22a3..558afcbd9016 100644 --- a/arch/sparc/include/asm/pgalloc_32.h +++ b/arch/sparc/include/asm/pgalloc_32.h @@ -53,7 +53,8 @@ static inline void free_pmd_fast(pmd_t * pmd) #define pmd_populate(mm, pmd, pte) pmd_set(pmd, pte) void pmd_set(pmd_t *pmdp, pte_t *ptep); -#define pmd_populate_kernel pmd_populate +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ + pmd_populate(mm, pmd, pte) pgtable_t pte_alloc_one(struct mm_struct *mm); diff --git a/arch/sparc/include/asm/pgalloc_64.h b/arch/sparc/include/asm/pgalloc_64.h index caa7632be4c2..185ad9637442 100644 --- a/arch/sparc/include/asm/pgalloc_64.h +++ b/arch/sparc/include/asm/pgalloc_64.h @@ -69,8 +69,8 @@ void pte_free(struct mm_struct *mm, pgtable_t ptepage); #define pte_free_defer pte_free_defer void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable); -#define pmd_populate_kernel(MM, PMD, PTE) pmd_set(MM, PMD, PTE) -#define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) +#define pmd_populate_kernel(MM, PMD, PTE, VADDR) pmd_set(MM, PMD, PTE) +#define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) void pgtable_free(void *table, bool is_page); diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 1ca9054d9b97..32b3c89f869d 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -5,7 +5,7 @@ * Copyright (C) 1996-1999 David S. Miller (davem@caip.rutgers.edu) * Copyright (C) 1997-1999 Jakub Jelinek (jj@sunsite.mff.cuni.cz) */ - + #include <linux/extable.h> #include <linux/kernel.h> #include <linux/sched.h> @@ -1843,7 +1843,7 @@ static unsigned long __ref kernel_map_range(unsigned long pstart, if (!new) goto err_alloc; alloc_bytes += PAGE_SIZE; - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, vstart); } pte = pte_offset_kernel(pmd, vstart); @@ -2404,11 +2404,11 @@ void __init paging_init(void) * work. */ init_mm.pgd += ((shift) / (sizeof(pgd_t))); - + memset(swapper_pg_dir, 0, sizeof(swapper_pg_dir)); inherit_prom_mappings(); - + /* Ok, we can use our TLB miss and window trap handlers safely. */ setup_tba(); diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h index de5e31c64793..300431ff61bb 100644 --- a/arch/um/include/asm/pgalloc.h +++ b/arch/um/include/asm/pgalloc.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 */ -/* +/* * Copyright (C) 2000, 2001, 2002 Jeff Dike (jdike@karaya.com) * Copyright 2003 PathScale, Inc. * Derived from include/asm-i386/pgalloc.h and include/asm-i386/pgtable.h @@ -12,7 +12,7 @@ #include <asm-generic/pgalloc.h> -#define pmd_populate_kernel(mm, pmd, pte) \ +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ set_pmd(pmd, __pmd(_PAGE_TABLE + (unsigned long) __pa(pte))) #define pmd_populate(mm, pmd, pte) \ diff --git a/arch/x86/include/asm/pgalloc.h b/arch/x86/include/asm/pgalloc.h index dcd836b59beb..3bc5e0cc7b38 100644 --- a/arch/x86/include/asm/pgalloc.h +++ b/arch/x86/include/asm/pgalloc.h @@ -62,7 +62,8 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte, } static inline void pmd_populate_kernel(struct mm_struct *mm, - pmd_t *pmd, pte_t *pte) + pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { paravirt_alloc_pte(mm, __pa(pte) >> PAGE_SHIFT); set_pmd(pmd, __pmd(__pa(pte) | _PAGE_TABLE)); diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 7e177856ee4f..ee4a73842466 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -73,7 +73,15 @@ static inline void fname##_init(struct mm_struct *mm, \ DEFINE_POPULATE(p4d_populate, p4d, pud, init) DEFINE_POPULATE(pgd_populate, pgd, p4d, init) DEFINE_POPULATE(pud_populate, pud, pmd, init) -DEFINE_POPULATE(pmd_populate_kernel, pmd, pte, init) + +static inline void pmd_populate_kernel_init(struct mm_struct *mm, + pmd_t *arg1, pte_t *arg2, unsigned long arg3, bool init) +{ + if (init) + pmd_populate_kernel_safe(mm, arg1, arg2); + else + pmd_populate_kernel(mm, arg1, arg2, arg3); +} #define DEFINE_ENTRY(type1, type2, init) \ static inline void set_##type1##_init(type1##_t *arg1, \ @@ -286,7 +294,7 @@ static pte_t *fill_pte(pmd_t *pmd, unsigned long vaddr) { if (pmd_none(*pmd)) { pte_t *pte = (pte_t *) spp_getpage(); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, vaddr); if (pte != pte_offset_kernel(pmd, 0)) printk(KERN_ERR "PAGETABLE BUG #03!\n"); } @@ -575,7 +583,7 @@ phys_pmd_init(pmd_t *pmd_page, unsigned long paddr, unsigned long paddr_end, paddr_last = phys_pte_init(pte, paddr, paddr_end, new_prot, init); spin_lock(&init_mm.page_table_lock); - pmd_populate_kernel_init(&init_mm, pmd, pte, init); + pmd_populate_kernel_init(&init_mm, pmd, pte, init, __va(paddr)); spin_unlock(&init_mm.page_table_lock); } update_page_count(PG_LEVEL_2M, pages); diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index aa7d279321ea..8844047fdaad 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -888,7 +888,7 @@ void __init early_ioremap_init(void) pmd = early_ioremap_pmd(fix_to_virt(FIX_BTMAP_BEGIN)); memset(bm_pte, 0, sizeof(bm_pte)); - pmd_populate_kernel(&init_mm, pmd, bm_pte); + pmd_populate_kernel(&init_mm, pmd, bm_pte, fix_to_virt(FIX_BTMAP_BEGIN)); /* * The boot-ioremap range spans multiple pmds, for which diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c index 9dddf19a5571..95ae9e12fe41 100644 --- a/arch/x86/mm/kasan_init_64.c +++ b/arch/x86/mm/kasan_init_64.c @@ -53,7 +53,7 @@ static void __init kasan_populate_pmd(pmd_t *pmd, unsigned long addr, } p = early_alloc(PAGE_SIZE, nid, true); - pmd_populate_kernel(&init_mm, pmd, p); + pmd_populate_kernel(&init_mm, pmd, p, addr); } pte = pte_offset_kernel(pmd, addr); diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h index 7fc0f9126dd3..5359e4091b9a 100644 --- a/arch/xtensa/include/asm/pgalloc.h +++ b/arch/xtensa/include/asm/pgalloc.h @@ -21,7 +21,7 @@ * inside the pgd, so has no extra memory associated with it. */ -#define pmd_populate_kernel(mm, pmdp, ptep) \ +#define pmd_populate_kernel(mm, pmdp, ptep, vaddr) \ (pmd_val(*(pmdp)) = ((unsigned long)ptep)) #define pmd_populate(mm, pmdp, page) \ (pmd_val(*(pmdp)) = ((unsigned long)page_to_virt(page))) diff --git a/include/linux/mm.h b/include/linux/mm.h index 7b0ee64225de..7162667c0e37 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2802,7 +2802,7 @@ static inline void mm_dec_nr_ptes(struct mm_struct *mm) {} #endif int __pte_alloc(struct mm_struct *mm, pmd_t *pmd); -int __pte_alloc_kernel(pmd_t *pmd); +int __pte_alloc_kernel(pmd_t *pmd, unsigned long vaddr); #if defined(CONFIG_MMU) @@ -2997,7 +2997,7 @@ pte_t *pte_offset_map_nolock(struct mm_struct *mm, pmd_t *pmd, NULL : pte_offset_map_lock(mm, pmd, address, ptlp)) #define pte_alloc_kernel(pmd, address) \ - ((unlikely(pmd_none(*(pmd))) && __pte_alloc_kernel(pmd))? \ + ((unlikely(pmd_none(*(pmd))) && __pte_alloc_kernel(pmd, address))? \ NULL: pte_offset_kernel(pmd, address)) #if USE_SPLIT_PMD_PTLOCKS diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index da177e49d956..cfbe3695fffb 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -58,7 +58,7 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start, if (!pgtable) return -ENOMEM; - pmd_populate_kernel(&init_mm, &__pmd, pgtable); + pmd_populate_kernel(&init_mm, &__pmd, pgtable, start); for (i = 0; i < PTRS_PER_PTE; i++, addr += PAGE_SIZE) { pte_t entry, *pte; @@ -81,7 +81,7 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start, /* Make pte visible before pmd. See comment in pmd_install(). */ smp_wmb(); - pmd_populate_kernel(&init_mm, pmd, pgtable); + pmd_populate_kernel(&init_mm, pmd, pgtable, start); if (!(walk->flags & VMEMMAP_SPLIT_NO_TLB_FLUSH)) flush_tlb_kernel_range(start, start + PMD_SIZE); } else { diff --git a/mm/kasan/init.c b/mm/kasan/init.c index 89895f38f722..813f8e8a801c 100644 --- a/mm/kasan/init.c +++ b/mm/kasan/init.c @@ -117,7 +117,8 @@ static int __ref zero_pmd_populate(pud_t *pud, unsigned long addr, if (IS_ALIGNED(addr, PMD_SIZE) && end - addr >= PMD_SIZE) { pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } @@ -131,7 +132,7 @@ static int __ref zero_pmd_populate(pud_t *pud, unsigned long addr, if (!p) return -ENOMEM; - pmd_populate_kernel(&init_mm, pmd, p); + pmd_populate_kernel(&init_mm, pmd, p, addr); } zero_pte_populate(pmd, addr, next); } while (pmd++, addr = next, addr != end); @@ -158,7 +159,8 @@ static int __ref zero_pud_populate(p4d_t *p4d, unsigned long addr, lm_alias(kasan_early_shadow_pmd)); pmd = pmd_offset(pud, addr); pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } @@ -204,7 +206,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr, lm_alias(kasan_early_shadow_pmd)); pmd = pmd_offset(pud, addr); pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } @@ -267,7 +270,8 @@ int __ref kasan_populate_early_shadow(const void *shadow_start, lm_alias(kasan_early_shadow_pmd)); pmd = pmd_offset(pud, addr); pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } diff --git a/mm/memory.c b/mm/memory.c index d2155ced45f8..67807ade9a0e 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -447,7 +447,7 @@ int __pte_alloc(struct mm_struct *mm, pmd_t *pmd) return 0; } -int __pte_alloc_kernel(pmd_t *pmd) +int __pte_alloc_kernel(pmd_t *pmd, unsigned long vaddr) { pte_t *new = pte_alloc_one_kernel(&init_mm); if (!new) @@ -456,7 +456,7 @@ int __pte_alloc_kernel(pmd_t *pmd) spin_lock(&init_mm.page_table_lock); if (likely(pmd_none(*pmd))) { /* Has another populated it ? */ smp_wmb(); /* See comment in pmd_install() */ - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, vaddr); new = NULL; } spin_unlock(&init_mm.page_table_lock); diff --git a/mm/percpu.c b/mm/percpu.c index 4e11fc1e6def..fc83cf64baf6 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -3238,7 +3238,7 @@ void __init __weak pcpu_populate_pte(unsigned long addr) new = memblock_alloc(PTE_TABLE_SIZE, PTE_TABLE_SIZE); if (!new) goto err_alloc; - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, addr); } return; diff --git a/mm/pgalloc-track.h b/mm/pgalloc-track.h index e9e879de8649..ac983705a054 100644 --- a/mm/pgalloc-track.h +++ b/mm/pgalloc-track.h @@ -45,7 +45,8 @@ static inline pmd_t *pmd_alloc_track(struct mm_struct *mm, pud_t *pud, #define pte_alloc_kernel_track(pmd, address, mask) \ ((unlikely(pmd_none(*(pmd))) && \ - (__pte_alloc_kernel(pmd) || ({*(mask)|=PGTBL_PMD_MODIFIED;0;})))?\ + (__pte_alloc_kernel(pmd, address) || \ + ({*(mask)|=PGTBL_PMD_MODIFIED;0;})))?\ NULL: pte_offset_kernel(pmd, address)) #endif /* _LINUX_PGALLOC_TRACK_H */ diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index a2cbe44c48e1..6085c8339b65 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -191,7 +191,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node) void *p = vmemmap_alloc_block_zero(PAGE_SIZE, node); if (!p) return NULL; - pmd_populate_kernel(&init_mm, pmd, p); + pmd_populate_kernel(&init_mm, pmd, p, addr); } return pmd; } -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/5] mm: add vaddr param to pmd_populate_kernel 2024-04-16 19:18 ` [PATCH 3/5 RESEND] mm: add vaddr param to pmd_populate_kernel Maxwell Bland @ 2024-04-05 18:37 ` Maxwell Bland 0 siblings, 0 replies; 6+ messages in thread From: Maxwell Bland @ 2024-04-05 18:37 UTC (permalink / raw) To: linux-mm Cc: Maxwell Bland, Richard Henderson, Ivan Kokshaysky, Matt Turner, Vineet Gupta, Alexander Potapenko, Marco Elver, Dmitry Vyukov, Russell King, Andrey Ryabinin, Andrey Konovalov, Vincenzo Frascino, Catalin Marinas, Will Deacon, Guo Ren, Brian Cain, Huacai Chen, WANG Xuerui, Geert Uytterhoeven, Sam Creasey, Michal Simek, Thomas Bogendoerfer, Dinh Nguyen, Jonas Bonn, Stefan Kristiansson, Stafford Horne, James E.J. Bottomley, Helge Deller, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Aneesh Kumar K.V, Naveen N. Rao, Paul Walmsley, Palmer Dabbelt, Albert Ou, Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Christian Borntraeger, Sven Schnelle, Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz, David S. Miller, Andreas Larsson, Richard Weinberger, Anton Ivanov, Johannes Berg, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin, Andy Lutomirski, Peter Zijlstra, Chris Zankel, Max Filippov, Andrew Morton, Muchun Song, Dennis Zhou, Tejun Heo, Christoph Lameter, Maxwell Bland, Linus Walleij, David Hildenbrand, Arnd Bergmann, Ard Biesheuvel, Ryan Roberts, Mark Rutland, Nikhil V, Rick Edgecombe, Baolin Wang, Bibo Mao, Tianrui Zhao, Randy Dunlap, Vlastimil Babka, Kent Overstreet, Peter Xu, Jiangfeng Xiao, Alexandre Ghiti, Jisheng Zhang, Conor Dooley, Mason Huo, Sia Jee Heng, Song Shuai, Gerald Schaefer, Qi Zheng, Hugh Dickins, Jason Gunthorpe, Breno Leitao, Josh Poimboeuf, linux-alpha, linux-kernel, linux-snps-arc, kasan-dev, linux-arm-kernel, linux-csky, linux-hexagon, loongarch, linux-m68k, linux-mips, kvm, linux-openrisc, linux-parisc, linuxppc-dev, linux-riscv, linux-s390, linux-sh, sparclinux, linux-um This patch affords each architecture the ability to condition the population of page middle directory entries on the virtual address being allocated, matching existing PTE infrastructure, easing the necessity of performing a reverse page table walk in cases where the population context is not readily accessible, i.e. dynamic vmalloc calls on arm64. To achieve this goal, it modifies every call and implementation of the pmd_populate_kernel function across architectures, ensuring uniform adoption across all kernel deployments. Signed-off-by: Maxwell Bland <mbland@motorola.com> --- Hi all, Thank you for taking the time to review this change. This effects many subarchitectures so the maintainers list is large. Apologies in advance if there is a specific maintainer I should have spoken with directly for deployment across subprojects. The reason for such a sweeping change is from lore.kernel.org/all/cf5409c3-254a-459b-8969-429db2ec6439@redhat.com It is my understanding as well that some subarchitectures may have separate "next" or development branches ahead of the main upstream linux. Please let me know if a cherry-pick to that branch is desired and I will do my best to check out and deploy it as possible. arch/alpha/include/asm/pgalloc.h | 5 +++-- arch/arc/include/asm/pgalloc.h | 3 ++- arch/arc/mm/highmem.c | 2 +- arch/arm/include/asm/kfence.h | 2 +- arch/arm/include/asm/pgalloc.h | 3 ++- arch/arm/mm/kasan_init.c | 2 +- arch/arm/mm/mmu.c | 2 +- arch/arm64/include/asm/pgalloc.h | 3 ++- arch/arm64/mm/trans_pgd.c | 2 +- arch/csky/include/asm/pgalloc.h | 2 +- arch/hexagon/include/asm/pgalloc.h | 2 +- arch/loongarch/include/asm/pgalloc.h | 3 ++- arch/loongarch/mm/init.c | 2 +- arch/loongarch/mm/kasan_init.c | 2 +- arch/m68k/include/asm/mcf_pgalloc.h | 2 +- arch/m68k/include/asm/motorola_pgalloc.h | 3 ++- arch/m68k/include/asm/sun3_pgalloc.h | 3 ++- arch/microblaze/include/asm/pgalloc.h | 2 +- arch/mips/include/asm/pgalloc.h | 2 +- arch/mips/kvm/mmu.c | 2 +- arch/nios2/include/asm/pgalloc.h | 2 +- arch/openrisc/include/asm/pgalloc.h | 2 +- arch/parisc/include/asm/pgalloc.h | 5 +++-- arch/parisc/mm/init.c | 6 +++--- arch/powerpc/include/asm/book3s/32/pgalloc.h | 2 +- arch/powerpc/include/asm/book3s/64/pgalloc.h | 2 +- arch/powerpc/include/asm/nohash/32/pgalloc.h | 2 +- arch/powerpc/include/asm/nohash/64/pgalloc.h | 2 +- arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +- arch/powerpc/mm/kasan/init_32.c | 4 ++-- arch/powerpc/mm/kasan/init_book3e_64.c | 9 ++++++--- arch/powerpc/mm/kasan/init_book3s_64.c | 7 +++++-- arch/powerpc/mm/nohash/book3e_pgtable.c | 2 +- arch/powerpc/mm/pgtable_32.c | 4 ++-- arch/riscv/include/asm/pgalloc.h | 2 +- arch/riscv/kernel/hibernate.c | 2 +- arch/s390/include/asm/pgalloc.h | 2 +- arch/sh/include/asm/pgalloc.h | 2 +- arch/sh/mm/init.c | 2 +- arch/sparc/include/asm/pgalloc_32.h | 3 ++- arch/sparc/include/asm/pgalloc_64.h | 4 ++-- arch/sparc/mm/init_64.c | 8 ++++---- arch/um/include/asm/pgalloc.h | 4 ++-- arch/x86/include/asm/pgalloc.h | 3 ++- arch/x86/mm/init_64.c | 14 +++++++++++--- arch/x86/mm/ioremap.c | 2 +- arch/x86/mm/kasan_init_64.c | 2 +- arch/xtensa/include/asm/pgalloc.h | 2 +- include/linux/mm.h | 4 ++-- mm/hugetlb_vmemmap.c | 4 ++-- mm/kasan/init.c | 14 +++++++++----- mm/memory.c | 4 ++-- mm/percpu.c | 2 +- mm/pgalloc-track.h | 3 ++- mm/sparse-vmemmap.c | 2 +- 55 files changed, 107 insertions(+), 78 deletions(-) diff --git a/arch/alpha/include/asm/pgalloc.h b/arch/alpha/include/asm/pgalloc.h index 68be7adbfe58..1d3d86cad3cc 100644 --- a/arch/alpha/include/asm/pgalloc.h +++ b/arch/alpha/include/asm/pgalloc.h @@ -7,7 +7,7 @@ #include <asm-generic/pgalloc.h> -/* +/* * Allocate and free page tables. The xxx_kernel() versions are * used to allocate a kernel page table - this turns on ASN bits * if any. @@ -20,7 +20,8 @@ pmd_populate(struct mm_struct *mm, pmd_t *pmd, pgtable_t pte) } static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { pmd_set(pmd, pte); } diff --git a/arch/arc/include/asm/pgalloc.h b/arch/arc/include/asm/pgalloc.h index 096b8ef58edb..c0ebfa44b204 100644 --- a/arch/arc/include/asm/pgalloc.h +++ b/arch/arc/include/asm/pgalloc.h @@ -34,7 +34,8 @@ #include <asm-generic/pgalloc.h> static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { /* * The cast to long below is OK in 32-bit PAE40 regime with long long pte diff --git a/arch/arc/mm/highmem.c b/arch/arc/mm/highmem.c index c79912a6b196..2d327cf35722 100644 --- a/arch/arc/mm/highmem.c +++ b/arch/arc/mm/highmem.c @@ -57,7 +57,7 @@ static noinline pte_t * __init alloc_kmap_pgtable(unsigned long kvaddr) panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__, PAGE_SIZE, PAGE_SIZE); - pmd_populate_kernel(&init_mm, pmd_k, pte_k); + pmd_populate_kernel(&init_mm, pmd_k, pte_k, kvaddr); return pte_k; } diff --git a/arch/arm/include/asm/kfence.h b/arch/arm/include/asm/kfence.h index 7980d0f2271f..dd4e4325d354 100644 --- a/arch/arm/include/asm/kfence.h +++ b/arch/arm/include/asm/kfence.h @@ -19,7 +19,7 @@ static inline int split_pmd_page(pmd_t *pmd, unsigned long addr) for (i = 0; i < PTRS_PER_PTE; i++) set_pte_ext(pte + i, pfn_pte(pfn + i, PAGE_KERNEL), 0); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, addr); flush_tlb_kernel_range(addr, addr + PMD_SIZE); return 0; diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h index a17f01235c29..0a88346db17e 100644 --- a/arch/arm/include/asm/pgalloc.h +++ b/arch/arm/include/asm/pgalloc.h @@ -122,7 +122,8 @@ static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t pte, * Ensure that we always set both PMD entries. */ static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep, + unsigned long vaddr) { /* * The pmd must be loaded with the physical address of the PTE table diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c index 111d4f703136..9b3af2dce71e 100644 --- a/arch/arm/mm/kasan_init.c +++ b/arch/arm/mm/kasan_init.c @@ -111,7 +111,7 @@ static void __init kasan_pmd_populate(pud_t *pudp, unsigned long addr, __func__, addr); return; } - pmd_populate_kernel(&init_mm, pmdp, p); + pmd_populate_kernel(&init_mm, pmdp, p, addr); flush_pmd_entry(pmdp); } diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index c24e29c0b9a4..3cfed8dc4a19 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -384,7 +384,7 @@ void __init early_fixmap_init(void) != FIXADDR_TOP >> PMD_SHIFT); pmd = fixmap_pmd(FIXADDR_TOP); - pmd_populate_kernel(&init_mm, pmd, bm_pte); + pmd_populate_kernel(&init_mm, pmd, bm_pte, __fix_to_virt(FIXADDR_TOP)); pte_offset_fixmap = pte_offset_early_fixmap; } diff --git a/arch/arm64/include/asm/pgalloc.h b/arch/arm64/include/asm/pgalloc.h index 8ff5f2a2579e..5785272144e8 100644 --- a/arch/arm64/include/asm/pgalloc.h +++ b/arch/arm64/include/asm/pgalloc.h @@ -124,7 +124,8 @@ static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t ptep, * of the mm address space. */ static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep, + unsigned long vaddr) { VM_BUG_ON(mm && mm != &init_mm); __pmd_populate(pmdp, __pa(ptep), PMD_TYPE_TABLE | PMD_TABLE_UXN); diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c index 5139a28130c0..f84244d13099 100644 --- a/arch/arm64/mm/trans_pgd.c +++ b/arch/arm64/mm/trans_pgd.c @@ -69,7 +69,7 @@ static int copy_pte(struct trans_pgd_info *info, pmd_t *dst_pmdp, dst_ptep = trans_alloc(info); if (!dst_ptep) return -ENOMEM; - pmd_populate_kernel(NULL, dst_pmdp, dst_ptep); + pmd_populate_kernel(NULL, dst_pmdp, dst_ptep, addr); dst_ptep = pte_offset_kernel(dst_pmdp, start); src_ptep = pte_offset_kernel(src_pmdp, start); diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h index 9c84c9012e53..f2c244c58acf 100644 --- a/arch/csky/include/asm/pgalloc.h +++ b/arch/csky/include/asm/pgalloc.h @@ -11,7 +11,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd(__pa(pte))); } diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h index 55988625e6fb..2be773a5ffeb 100644 --- a/arch/hexagon/include/asm/pgalloc.h +++ b/arch/hexagon/include/asm/pgalloc.h @@ -62,7 +62,7 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, * kernel map of the active thread who's calling pmd_populate_kernel... */ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { extern spinlock_t kmap_gen_lock; pmd_t *ppmd; diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h index 4e2d6b7ca2ee..6384391e69bd 100644 --- a/arch/loongarch/include/asm/pgalloc.h +++ b/arch/loongarch/include/asm/pgalloc.h @@ -13,7 +13,8 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, - pmd_t *pmd, pte_t *pte) + pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c index 4dd53427f657..b8952899b120 100644 --- a/arch/loongarch/mm/init.c +++ b/arch/loongarch/mm/init.c @@ -200,7 +200,7 @@ pte_t * __init populate_kernel_pte(unsigned long addr) pte = memblock_alloc(PAGE_SIZE, PAGE_SIZE); if (!pte) panic("%s: Failed to allocate memory\n", __func__); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, addr); } return pte_offset_kernel(pmd, addr); diff --git a/arch/loongarch/mm/kasan_init.c b/arch/loongarch/mm/kasan_init.c index c608adc99845..51d40ff43aa9 100644 --- a/arch/loongarch/mm/kasan_init.c +++ b/arch/loongarch/mm/kasan_init.c @@ -110,7 +110,7 @@ static pte_t *__init kasan_pte_offset(pmd_t *pmdp, unsigned long addr, int node, __pa_symbol(kasan_early_shadow_pte) : kasan_alloc_zeroed_page(node); if (!early) memcpy(__va(pte_phys), kasan_early_shadow_pte, sizeof(kasan_early_shadow_pte)); - pmd_populate_kernel(NULL, pmdp, (pte_t *)__va(pte_phys)); + pmd_populate_kernel(NULL, pmdp, (pte_t *)__va(pte_phys), addr); } return pte_offset_kernel(pmdp, addr); diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h index 302c5bf67179..989a1aaa8aa1 100644 --- a/arch/m68k/include/asm/mcf_pgalloc.h +++ b/arch/m68k/include/asm/mcf_pgalloc.h @@ -30,7 +30,7 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) #define pmd_populate(mm, pmd, pte) (pmd_val(*pmd) = (unsigned long)(pte)) -#define pmd_populate_kernel pmd_populate +#define pmd_populate_kernel(mm, pmd, pte, vaddr) pmd_populate(mm, pmd, pte) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pgtable, unsigned long address) diff --git a/arch/m68k/include/asm/motorola_pgalloc.h b/arch/m68k/include/asm/motorola_pgalloc.h index 74a817d9387f..74aec6965981 100644 --- a/arch/m68k/include/asm/motorola_pgalloc.h +++ b/arch/m68k/include/asm/motorola_pgalloc.h @@ -79,7 +79,8 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) } -static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, + pte_t *pte, unsigned long vaddr) { pmd_set(pmd, pte); } diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index 4a137eecb6fe..550283e8bf4d 100644 --- a/arch/m68k/include/asm/sun3_pgalloc.h +++ b/arch/m68k/include/asm/sun3_pgalloc.h @@ -23,7 +23,8 @@ do { \ tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) -static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, + pte_t *pte, unsigned long vaddr) { pmd_val(*pmd) = __pa((unsigned long)pte); } diff --git a/arch/microblaze/include/asm/pgalloc.h b/arch/microblaze/include/asm/pgalloc.h index 6c33b05f730f..b3cc2cd8fc50 100644 --- a/arch/microblaze/include/asm/pgalloc.h +++ b/arch/microblaze/include/asm/pgalloc.h @@ -35,7 +35,7 @@ extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm); #define pmd_populate(mm, pmd, pte) \ (pmd_val(*(pmd)) = (unsigned long)page_address(pte)) -#define pmd_populate_kernel(mm, pmd, pte) \ +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ (pmd_val(*(pmd)) = (unsigned long) (pte)) #endif /* _ASM_MICROBLAZE_PGALLOC_H */ diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index f4440edcd8fe..fb71c8776a04 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -19,7 +19,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c index 467ee6b95ae1..47f48929a124 100644 --- a/arch/mips/kvm/mmu.c +++ b/arch/mips/kvm/mmu.c @@ -133,7 +133,7 @@ static pte_t *kvm_mips_walk_pgd(pgd_t *pgd, struct kvm_mmu_memory_cache *cache, return NULL; new_pte = kvm_mmu_memory_cache_alloc(cache); clear_page(new_pte); - pmd_populate_kernel(NULL, pmd, new_pte); + pmd_populate_kernel(NULL, pmd, new_pte, addr); } return pte_offset_kernel(pmd, addr); } diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h index ce6bb8e74271..ea99d36a6fdd 100644 --- a/arch/nios2/include/asm/pgalloc.h +++ b/arch/nios2/include/asm/pgalloc.h @@ -15,7 +15,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/openrisc/include/asm/pgalloc.h b/arch/openrisc/include/asm/pgalloc.h index c6a73772a546..304cf8955bec 100644 --- a/arch/openrisc/include/asm/pgalloc.h +++ b/arch/openrisc/include/asm/pgalloc.h @@ -25,7 +25,7 @@ extern int mem_init_done; -#define pmd_populate_kernel(mm, pmd, pte) \ +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ set_pmd(pmd, __pmd(_KERNPG_TABLE + __pa(pte))) static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, diff --git a/arch/parisc/include/asm/pgalloc.h b/arch/parisc/include/asm/pgalloc.h index e3e142b1c5c5..cba92c90a62a 100644 --- a/arch/parisc/include/asm/pgalloc.h +++ b/arch/parisc/include/asm/pgalloc.h @@ -61,13 +61,14 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) #endif static inline void -pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) +pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((PxD_FLAG_PRESENT | PxD_FLAG_VALID) + (__u32)(__pa((unsigned long)pte) >> PxD_VALUE_SHIFT))); } #define pmd_populate(mm, pmd, pte_page) \ - pmd_populate_kernel(mm, pmd, page_address(pte_page)) + pmd_populate_kernel(mm, pmd, page_address(pte_page), \ + (unsigned long)page_to_virt(pte_page)) #endif diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c index f876af56e13f..1cf3aae67023 100644 --- a/arch/parisc/mm/init.c +++ b/arch/parisc/mm/init.c @@ -390,7 +390,7 @@ static void __ref map_pages(unsigned long start_vaddr, pg_table = memblock_alloc(PAGE_SIZE, PAGE_SIZE); if (!pg_table) panic("page table allocation failed\n"); - pmd_populate_kernel(NULL, pmd, pg_table); + pmd_populate_kernel(NULL, pmd, pg_table, vaddr); } pg_table = pte_offset_kernel(pmd, vaddr); @@ -481,7 +481,7 @@ void free_initmem(void) /* finally dump all the instructions which were cached, since the * pages are no-longer executable */ flush_icache_range(init_begin, init_end); - + free_initmem_default(POISON_FREE_INITMEM); /* set up a new led state on systems shipped LED State panel */ @@ -694,7 +694,7 @@ static void __init fixmap_init(void) if (!pte) panic("fixmap: pte allocation failed.\n"); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, addr); addr += PAGE_SIZE; } while (addr < end); diff --git a/arch/powerpc/include/asm/book3s/32/pgalloc.h b/arch/powerpc/include/asm/book3s/32/pgalloc.h index dc5c039eb28e..b85105158686 100644 --- a/arch/powerpc/include/asm/book3s/32/pgalloc.h +++ b/arch/powerpc/include/asm/book3s/32/pgalloc.h @@ -26,7 +26,7 @@ static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) /* #define pgd_populate(mm, pmd, pte) BUG() */ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { *pmdp = __pmd(__pa(pte) | _PMD_PRESENT); } diff --git a/arch/powerpc/include/asm/book3s/64/pgalloc.h b/arch/powerpc/include/asm/book3s/64/pgalloc.h index dd2cff53a111..061c4be60166 100644 --- a/arch/powerpc/include/asm/book3s/64/pgalloc.h +++ b/arch/powerpc/include/asm/book3s/64/pgalloc.h @@ -156,7 +156,7 @@ static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, } static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { *pmd = __pmd(__pgtable_ptr_val(pte) | PMD_VAL_BITS); } diff --git a/arch/powerpc/include/asm/nohash/32/pgalloc.h b/arch/powerpc/include/asm/nohash/32/pgalloc.h index 11eac371e7e0..2788ce005b95 100644 --- a/arch/powerpc/include/asm/nohash/32/pgalloc.h +++ b/arch/powerpc/include/asm/nohash/32/pgalloc.h @@ -15,7 +15,7 @@ /* #define pgd_populate(mm, pmd, pte) BUG() */ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { if (IS_ENABLED(CONFIG_BOOKE)) *pmdp = __pmd((unsigned long)pte | _PMD_PRESENT); diff --git a/arch/powerpc/include/asm/nohash/64/pgalloc.h b/arch/powerpc/include/asm/nohash/64/pgalloc.h index e50b211becb3..d069443b4014 100644 --- a/arch/powerpc/include/asm/nohash/64/pgalloc.h +++ b/arch/powerpc/include/asm/nohash/64/pgalloc.h @@ -37,7 +37,7 @@ static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd) } static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { pmd_set(pmd, (unsigned long)pte); } diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c index 15e88f1439ec..a70063cd6f64 100644 --- a/arch/powerpc/mm/book3s64/radix_pgtable.c +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c @@ -104,7 +104,7 @@ static int early_map_kernel_page(unsigned long ea, unsigned long pa, if (!pmd_present(*pmdp)) { ptep = early_alloc_pgtable(PAGE_SIZE, nid, region_start, region_end); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, ea); } ptep = pte_offset_kernel(pmdp, ea); diff --git a/arch/powerpc/mm/kasan/init_32.c b/arch/powerpc/mm/kasan/init_32.c index aa9aa11927b2..22df07fd1af5 100644 --- a/arch/powerpc/mm/kasan/init_32.c +++ b/arch/powerpc/mm/kasan/init_32.c @@ -47,7 +47,7 @@ int __init kasan_init_shadow_page_tables(unsigned long k_start, unsigned long k_ if (!new) return -ENOMEM; kasan_populate_pte(new, PAGE_KERNEL); - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, k_cur); } return 0; } @@ -187,6 +187,6 @@ void __init kasan_early_init(void) do { next = pgd_addr_end(addr, end); - pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte); + pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte, addr); } while (pmd++, addr = next, addr != end); } diff --git a/arch/powerpc/mm/kasan/init_book3e_64.c b/arch/powerpc/mm/kasan/init_book3e_64.c index 11519e88dc6b..05ccdb88ff51 100644 --- a/arch/powerpc/mm/kasan/init_book3e_64.c +++ b/arch/powerpc/mm/kasan/init_book3e_64.c @@ -54,7 +54,7 @@ static int __init kasan_map_kernel_page(unsigned long ea, unsigned long pa, pgpr if (kasan_pte_table(*pmdp)) { ptep = memblock_alloc(PTE_TABLE_SIZE, PTE_TABLE_SIZE); memcpy(ptep, kasan_early_shadow_pte, PTE_TABLE_SIZE); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, ea); } ptep = pte_offset_kernel(pmdp, ea); @@ -93,9 +93,12 @@ void __init kasan_early_init(void) __set_pte_at(&init_mm, (unsigned long)kasan_early_shadow_page, &kasan_early_shadow_pte[i], zero_pte, 0); - for (i = 0; i < PTRS_PER_PMD; i++) + addr = KASAN_SHADOW_START + for (i = 0; i < PTRS_PER_PMD; i++) { pmd_populate_kernel(&init_mm, &kasan_early_shadow_pmd[i], - kasan_early_shadow_pte); + kasan_early_shadow_pte, addr); + addr += PMD_SIZE; + } for (i = 0; i < PTRS_PER_PUD; i++) pud_populate(&init_mm, &kasan_early_shadow_pud[i], diff --git a/arch/powerpc/mm/kasan/init_book3s_64.c b/arch/powerpc/mm/kasan/init_book3s_64.c index 9300d641cf9a..79569734dc29 100644 --- a/arch/powerpc/mm/kasan/init_book3s_64.c +++ b/arch/powerpc/mm/kasan/init_book3s_64.c @@ -55,6 +55,7 @@ void __init kasan_init(void) phys_addr_t start, end; u64 i; pte_t zero_pte = pfn_pte(virt_to_pfn(kasan_early_shadow_page), PAGE_KERNEL); + void *vaddr_start = __va(start); if (!early_radix_enabled()) { pr_warn("KASAN not enabled as it requires radix!"); @@ -68,9 +69,11 @@ void __init kasan_init(void) __set_pte_at(&init_mm, (unsigned long)kasan_early_shadow_page, &kasan_early_shadow_pte[i], zero_pte, 0); - for (i = 0; i < PTRS_PER_PMD; i++) + for (i = 0; i < PTRS_PER_PMD; i++) { pmd_populate_kernel(&init_mm, &kasan_early_shadow_pmd[i], - kasan_early_shadow_pte); + kasan_early_shadow_pte, + vaddr_start + i * PMD_SIZE); + } for (i = 0; i < PTRS_PER_PUD; i++) pud_populate(&init_mm, &kasan_early_shadow_pud[i], diff --git a/arch/powerpc/mm/nohash/book3e_pgtable.c b/arch/powerpc/mm/nohash/book3e_pgtable.c index 1c5e4ecbebeb..930bdd7a3774 100644 --- a/arch/powerpc/mm/nohash/book3e_pgtable.c +++ b/arch/powerpc/mm/nohash/book3e_pgtable.c @@ -107,7 +107,7 @@ int __ref map_kernel_page(unsigned long ea, phys_addr_t pa, pgprot_t prot) pmdp = pmd_offset(pudp, ea); if (!pmd_present(*pmdp)) { ptep = early_alloc_pgtable(PTE_TABLE_SIZE); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, ea); } ptep = pte_offset_kernel(pmdp, ea); } diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c index cfd622ebf774..e6fbaf3e9072 100644 --- a/arch/powerpc/mm/pgtable_32.c +++ b/arch/powerpc/mm/pgtable_32.c @@ -43,7 +43,7 @@ notrace void __init early_ioremap_init(void) for (; (s32)(FIXADDR_TOP - addr) > 0; addr += PGDIR_SIZE, ptep += PTRS_PER_PTE, pmdp++) - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, addr); early_ioremap_setup(); } @@ -64,7 +64,7 @@ pte_t __init *early_pte_alloc_kernel(pmd_t *pmdp, unsigned long va) if (pmd_none(*pmdp)) { pte_t *ptep = early_alloc_pgtable(PTE_FRAG_SIZE); - pmd_populate_kernel(&init_mm, pmdp, ptep); + pmd_populate_kernel(&init_mm, pmdp, ptep, va); } return pte_offset_kernel(pmdp, va); } diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h index deaf971253a2..d619daeded7f 100644 --- a/arch/riscv/include/asm/pgalloc.h +++ b/arch/riscv/include/asm/pgalloc.h @@ -16,7 +16,7 @@ #include <asm-generic/pgalloc.h> static inline void pmd_populate_kernel(struct mm_struct *mm, - pmd_t *pmd, pte_t *pte) + pmd_t *pmd, pte_t *pte, unsigned long vaddr) { unsigned long pfn = virt_to_pfn(pte); diff --git a/arch/riscv/kernel/hibernate.c b/arch/riscv/kernel/hibernate.c index 671b686c0158..085123ad4fa8 100644 --- a/arch/riscv/kernel/hibernate.c +++ b/arch/riscv/kernel/hibernate.c @@ -176,7 +176,7 @@ static int temp_pgtable_map_pte(pmd_t *dst_pmdp, pmd_t *src_pmdp, unsigned long if (!dst_ptep) return -ENOMEM; - pmd_populate_kernel(NULL, dst_pmdp, dst_ptep); + pmd_populate_kernel(NULL, dst_pmdp, dst_ptep, 0); } dst_ptep = pte_offset_kernel(dst_pmdp, start); diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h index 7b84ef6dc4b6..4143b3f9d610 100644 --- a/arch/s390/include/asm/pgalloc.h +++ b/arch/s390/include/asm/pgalloc.h @@ -131,7 +131,7 @@ static inline void pmd_populate(struct mm_struct *mm, set_pmd(pmd, __pmd(_SEGMENT_ENTRY | __pa(pte))); } -#define pmd_populate_kernel(mm, pmd, pte) pmd_populate(mm, pmd, pte) +#define pmd_populate_kernel(mm, pmd, pte, vaddr) pmd_populate(mm, pmd, pte) /* * page table entry allocation/free routines. diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index 5d8577ab1591..04b29eb9712b 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -21,7 +21,7 @@ extern void pmd_free(struct mm_struct *mm, pmd_t *pmd); #endif static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, - pte_t *pte) + pte_t *pte, unsigned long vaddr) { set_pmd(pmd, __pmd((unsigned long)pte)); } diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c index bf1b54055316..c862572dbec8 100644 --- a/arch/sh/mm/init.c +++ b/arch/sh/mm/init.c @@ -157,7 +157,7 @@ static pte_t * __init one_page_table_init(pmd_t *pmd) if (!pte) panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__, PAGE_SIZE, PAGE_SIZE); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, 0); BUG_ON(pte != pte_offset_kernel(pmd, 0)); } diff --git a/arch/sparc/include/asm/pgalloc_32.h b/arch/sparc/include/asm/pgalloc_32.h index 4f73e87b22a3..558afcbd9016 100644 --- a/arch/sparc/include/asm/pgalloc_32.h +++ b/arch/sparc/include/asm/pgalloc_32.h @@ -53,7 +53,8 @@ static inline void free_pmd_fast(pmd_t * pmd) #define pmd_populate(mm, pmd, pte) pmd_set(pmd, pte) void pmd_set(pmd_t *pmdp, pte_t *ptep); -#define pmd_populate_kernel pmd_populate +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ + pmd_populate(mm, pmd, pte) pgtable_t pte_alloc_one(struct mm_struct *mm); diff --git a/arch/sparc/include/asm/pgalloc_64.h b/arch/sparc/include/asm/pgalloc_64.h index caa7632be4c2..185ad9637442 100644 --- a/arch/sparc/include/asm/pgalloc_64.h +++ b/arch/sparc/include/asm/pgalloc_64.h @@ -69,8 +69,8 @@ void pte_free(struct mm_struct *mm, pgtable_t ptepage); #define pte_free_defer pte_free_defer void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable); -#define pmd_populate_kernel(MM, PMD, PTE) pmd_set(MM, PMD, PTE) -#define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) +#define pmd_populate_kernel(MM, PMD, PTE, VADDR) pmd_set(MM, PMD, PTE) +#define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) void pgtable_free(void *table, bool is_page); diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 1ca9054d9b97..32b3c89f869d 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -5,7 +5,7 @@ * Copyright (C) 1996-1999 David S. Miller (davem@caip.rutgers.edu) * Copyright (C) 1997-1999 Jakub Jelinek (jj@sunsite.mff.cuni.cz) */ - + #include <linux/extable.h> #include <linux/kernel.h> #include <linux/sched.h> @@ -1843,7 +1843,7 @@ static unsigned long __ref kernel_map_range(unsigned long pstart, if (!new) goto err_alloc; alloc_bytes += PAGE_SIZE; - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, vstart); } pte = pte_offset_kernel(pmd, vstart); @@ -2404,11 +2404,11 @@ void __init paging_init(void) * work. */ init_mm.pgd += ((shift) / (sizeof(pgd_t))); - + memset(swapper_pg_dir, 0, sizeof(swapper_pg_dir)); inherit_prom_mappings(); - + /* Ok, we can use our TLB miss and window trap handlers safely. */ setup_tba(); diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h index de5e31c64793..300431ff61bb 100644 --- a/arch/um/include/asm/pgalloc.h +++ b/arch/um/include/asm/pgalloc.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 */ -/* +/* * Copyright (C) 2000, 2001, 2002 Jeff Dike (jdike@karaya.com) * Copyright 2003 PathScale, Inc. * Derived from include/asm-i386/pgalloc.h and include/asm-i386/pgtable.h @@ -12,7 +12,7 @@ #include <asm-generic/pgalloc.h> -#define pmd_populate_kernel(mm, pmd, pte) \ +#define pmd_populate_kernel(mm, pmd, pte, vaddr) \ set_pmd(pmd, __pmd(_PAGE_TABLE + (unsigned long) __pa(pte))) #define pmd_populate(mm, pmd, pte) \ diff --git a/arch/x86/include/asm/pgalloc.h b/arch/x86/include/asm/pgalloc.h index dcd836b59beb..3bc5e0cc7b38 100644 --- a/arch/x86/include/asm/pgalloc.h +++ b/arch/x86/include/asm/pgalloc.h @@ -62,7 +62,8 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte, } static inline void pmd_populate_kernel(struct mm_struct *mm, - pmd_t *pmd, pte_t *pte) + pmd_t *pmd, pte_t *pte, + unsigned long vaddr) { paravirt_alloc_pte(mm, __pa(pte) >> PAGE_SHIFT); set_pmd(pmd, __pmd(__pa(pte) | _PAGE_TABLE)); diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 7e177856ee4f..ee4a73842466 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -73,7 +73,15 @@ static inline void fname##_init(struct mm_struct *mm, \ DEFINE_POPULATE(p4d_populate, p4d, pud, init) DEFINE_POPULATE(pgd_populate, pgd, p4d, init) DEFINE_POPULATE(pud_populate, pud, pmd, init) -DEFINE_POPULATE(pmd_populate_kernel, pmd, pte, init) + +static inline void pmd_populate_kernel_init(struct mm_struct *mm, + pmd_t *arg1, pte_t *arg2, unsigned long arg3, bool init) +{ + if (init) + pmd_populate_kernel_safe(mm, arg1, arg2); + else + pmd_populate_kernel(mm, arg1, arg2, arg3); +} #define DEFINE_ENTRY(type1, type2, init) \ static inline void set_##type1##_init(type1##_t *arg1, \ @@ -286,7 +294,7 @@ static pte_t *fill_pte(pmd_t *pmd, unsigned long vaddr) { if (pmd_none(*pmd)) { pte_t *pte = (pte_t *) spp_getpage(); - pmd_populate_kernel(&init_mm, pmd, pte); + pmd_populate_kernel(&init_mm, pmd, pte, vaddr); if (pte != pte_offset_kernel(pmd, 0)) printk(KERN_ERR "PAGETABLE BUG #03!\n"); } @@ -575,7 +583,7 @@ phys_pmd_init(pmd_t *pmd_page, unsigned long paddr, unsigned long paddr_end, paddr_last = phys_pte_init(pte, paddr, paddr_end, new_prot, init); spin_lock(&init_mm.page_table_lock); - pmd_populate_kernel_init(&init_mm, pmd, pte, init); + pmd_populate_kernel_init(&init_mm, pmd, pte, init, __va(paddr)); spin_unlock(&init_mm.page_table_lock); } update_page_count(PG_LEVEL_2M, pages); diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index aa7d279321ea..8844047fdaad 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -888,7 +888,7 @@ void __init early_ioremap_init(void) pmd = early_ioremap_pmd(fix_to_virt(FIX_BTMAP_BEGIN)); memset(bm_pte, 0, sizeof(bm_pte)); - pmd_populate_kernel(&init_mm, pmd, bm_pte); + pmd_populate_kernel(&init_mm, pmd, bm_pte, fix_to_virt(FIX_BTMAP_BEGIN)); /* * The boot-ioremap range spans multiple pmds, for which diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c index 9dddf19a5571..95ae9e12fe41 100644 --- a/arch/x86/mm/kasan_init_64.c +++ b/arch/x86/mm/kasan_init_64.c @@ -53,7 +53,7 @@ static void __init kasan_populate_pmd(pmd_t *pmd, unsigned long addr, } p = early_alloc(PAGE_SIZE, nid, true); - pmd_populate_kernel(&init_mm, pmd, p); + pmd_populate_kernel(&init_mm, pmd, p, addr); } pte = pte_offset_kernel(pmd, addr); diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h index 7fc0f9126dd3..5359e4091b9a 100644 --- a/arch/xtensa/include/asm/pgalloc.h +++ b/arch/xtensa/include/asm/pgalloc.h @@ -21,7 +21,7 @@ * inside the pgd, so has no extra memory associated with it. */ -#define pmd_populate_kernel(mm, pmdp, ptep) \ +#define pmd_populate_kernel(mm, pmdp, ptep, vaddr) \ (pmd_val(*(pmdp)) = ((unsigned long)ptep)) #define pmd_populate(mm, pmdp, page) \ (pmd_val(*(pmdp)) = ((unsigned long)page_to_virt(page))) diff --git a/include/linux/mm.h b/include/linux/mm.h index 7b0ee64225de..7162667c0e37 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2802,7 +2802,7 @@ static inline void mm_dec_nr_ptes(struct mm_struct *mm) {} #endif int __pte_alloc(struct mm_struct *mm, pmd_t *pmd); -int __pte_alloc_kernel(pmd_t *pmd); +int __pte_alloc_kernel(pmd_t *pmd, unsigned long vaddr); #if defined(CONFIG_MMU) @@ -2997,7 +2997,7 @@ pte_t *pte_offset_map_nolock(struct mm_struct *mm, pmd_t *pmd, NULL : pte_offset_map_lock(mm, pmd, address, ptlp)) #define pte_alloc_kernel(pmd, address) \ - ((unlikely(pmd_none(*(pmd))) && __pte_alloc_kernel(pmd))? \ + ((unlikely(pmd_none(*(pmd))) && __pte_alloc_kernel(pmd, address))? \ NULL: pte_offset_kernel(pmd, address)) #if USE_SPLIT_PMD_PTLOCKS diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index da177e49d956..cfbe3695fffb 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -58,7 +58,7 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start, if (!pgtable) return -ENOMEM; - pmd_populate_kernel(&init_mm, &__pmd, pgtable); + pmd_populate_kernel(&init_mm, &__pmd, pgtable, start); for (i = 0; i < PTRS_PER_PTE; i++, addr += PAGE_SIZE) { pte_t entry, *pte; @@ -81,7 +81,7 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start, /* Make pte visible before pmd. See comment in pmd_install(). */ smp_wmb(); - pmd_populate_kernel(&init_mm, pmd, pgtable); + pmd_populate_kernel(&init_mm, pmd, pgtable, start); if (!(walk->flags & VMEMMAP_SPLIT_NO_TLB_FLUSH)) flush_tlb_kernel_range(start, start + PMD_SIZE); } else { diff --git a/mm/kasan/init.c b/mm/kasan/init.c index 89895f38f722..813f8e8a801c 100644 --- a/mm/kasan/init.c +++ b/mm/kasan/init.c @@ -117,7 +117,8 @@ static int __ref zero_pmd_populate(pud_t *pud, unsigned long addr, if (IS_ALIGNED(addr, PMD_SIZE) && end - addr >= PMD_SIZE) { pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } @@ -131,7 +132,7 @@ static int __ref zero_pmd_populate(pud_t *pud, unsigned long addr, if (!p) return -ENOMEM; - pmd_populate_kernel(&init_mm, pmd, p); + pmd_populate_kernel(&init_mm, pmd, p, addr); } zero_pte_populate(pmd, addr, next); } while (pmd++, addr = next, addr != end); @@ -158,7 +159,8 @@ static int __ref zero_pud_populate(p4d_t *p4d, unsigned long addr, lm_alias(kasan_early_shadow_pmd)); pmd = pmd_offset(pud, addr); pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } @@ -204,7 +206,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr, lm_alias(kasan_early_shadow_pmd)); pmd = pmd_offset(pud, addr); pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } @@ -267,7 +270,8 @@ int __ref kasan_populate_early_shadow(const void *shadow_start, lm_alias(kasan_early_shadow_pmd)); pmd = pmd_offset(pud, addr); pmd_populate_kernel(&init_mm, pmd, - lm_alias(kasan_early_shadow_pte)); + lm_alias(kasan_early_shadow_pte), + addr); continue; } diff --git a/mm/memory.c b/mm/memory.c index d2155ced45f8..67807ade9a0e 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -447,7 +447,7 @@ int __pte_alloc(struct mm_struct *mm, pmd_t *pmd) return 0; } -int __pte_alloc_kernel(pmd_t *pmd) +int __pte_alloc_kernel(pmd_t *pmd, unsigned long vaddr) { pte_t *new = pte_alloc_one_kernel(&init_mm); if (!new) @@ -456,7 +456,7 @@ int __pte_alloc_kernel(pmd_t *pmd) spin_lock(&init_mm.page_table_lock); if (likely(pmd_none(*pmd))) { /* Has another populated it ? */ smp_wmb(); /* See comment in pmd_install() */ - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, vaddr); new = NULL; } spin_unlock(&init_mm.page_table_lock); diff --git a/mm/percpu.c b/mm/percpu.c index 4e11fc1e6def..fc83cf64baf6 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -3238,7 +3238,7 @@ void __init __weak pcpu_populate_pte(unsigned long addr) new = memblock_alloc(PTE_TABLE_SIZE, PTE_TABLE_SIZE); if (!new) goto err_alloc; - pmd_populate_kernel(&init_mm, pmd, new); + pmd_populate_kernel(&init_mm, pmd, new, addr); } return; diff --git a/mm/pgalloc-track.h b/mm/pgalloc-track.h index e9e879de8649..ac983705a054 100644 --- a/mm/pgalloc-track.h +++ b/mm/pgalloc-track.h @@ -45,7 +45,8 @@ static inline pmd_t *pmd_alloc_track(struct mm_struct *mm, pud_t *pud, #define pte_alloc_kernel_track(pmd, address, mask) \ ((unlikely(pmd_none(*(pmd))) && \ - (__pte_alloc_kernel(pmd) || ({*(mask)|=PGTBL_PMD_MODIFIED;0;})))?\ + (__pte_alloc_kernel(pmd, address) || \ + ({*(mask)|=PGTBL_PMD_MODIFIED;0;})))?\ NULL: pte_offset_kernel(pmd, address)) #endif /* _LINUX_PGALLOC_TRACK_H */ diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index a2cbe44c48e1..6085c8339b65 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -191,7 +191,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node) void *p = vmemmap_alloc_block_zero(PAGE_SIZE, node); if (!p) return NULL; - pmd_populate_kernel(&init_mm, pmd, p); + pmd_populate_kernel(&init_mm, pmd, p, addr); } return pmd; } -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-16 21:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240416122254.868007168-1-mbland@motorola.com>
2024-04-15 19:51 ` [PATCH 5/5] ptdump: add state parameter for non-leaf callback Maxwell Bland
2024-04-16 19:18 ` [PATCH 5/5 RESEND] " Maxwell Bland
2024-04-16 20:11 ` [PATCH 5/5] " Andrew Morton
2024-04-16 21:01 ` Maxwell Bland
2024-04-16 19:18 ` [PATCH 3/5 RESEND] mm: add vaddr param to pmd_populate_kernel Maxwell Bland
2024-04-05 18:37 ` [PATCH 3/5] " Maxwell Bland
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox