* [PATCH v1 1/1] KVM: s390: remove useless include
@ 2024-07-02 15:56 Claudio Imbrenda
2024-07-03 10:24 ` Nico Boehr
2024-07-03 10:40 ` Janosch Frank
0 siblings, 2 replies; 3+ messages in thread
From: Claudio Imbrenda @ 2024-07-02 15:56 UTC (permalink / raw)
To: kvm; +Cc: linux-kernel, linux-s390, frankja, borntraeger, nrb, nsg, seiden,
david
arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but
linux/kvm_host.h includes asm/kvm_host.h .
It turns out that arch/s390/include/asm/kvm_host.h only needs
linux/kvm_types.h, which it already includes.
Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .
Due to the #ifdef guards, the code works as it is today, but it's ugly
and it will get in the way of future patches.
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
arch/s390/include/asm/kvm_host.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_host.h
index 95990461888f..736cc88f497d 100644
--- a/arch/s390/include/asm/kvm_host.h
+++ b/arch/s390/include/asm/kvm_host.h
@@ -15,7 +15,6 @@
#include <linux/hrtimer.h>
#include <linux/interrupt.h>
#include <linux/kvm_types.h>
-#include <linux/kvm_host.h>
#include <linux/kvm.h>
#include <linux/seqlock.h>
#include <linux/module.h>
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] KVM: s390: remove useless include
2024-07-02 15:56 [PATCH v1 1/1] KVM: s390: remove useless include Claudio Imbrenda
@ 2024-07-03 10:24 ` Nico Boehr
2024-07-03 10:40 ` Janosch Frank
1 sibling, 0 replies; 3+ messages in thread
From: Nico Boehr @ 2024-07-03 10:24 UTC (permalink / raw)
To: Claudio Imbrenda, kvm
Cc: linux-kernel, linux-s390, frankja, borntraeger, nsg, seiden,
david
Quoting Claudio Imbrenda (2024-07-02 17:56:06)
> arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but
> linux/kvm_host.h includes asm/kvm_host.h .
>
> It turns out that arch/s390/include/asm/kvm_host.h only needs
> linux/kvm_types.h, which it already includes.
>
> Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .
>
> Due to the #ifdef guards, the code works as it is today, but it's ugly
> and it will get in the way of future patches.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] KVM: s390: remove useless include
2024-07-02 15:56 [PATCH v1 1/1] KVM: s390: remove useless include Claudio Imbrenda
2024-07-03 10:24 ` Nico Boehr
@ 2024-07-03 10:40 ` Janosch Frank
1 sibling, 0 replies; 3+ messages in thread
From: Janosch Frank @ 2024-07-03 10:40 UTC (permalink / raw)
To: Claudio Imbrenda, kvm
Cc: linux-kernel, linux-s390, borntraeger, nrb, nsg, seiden, david
On 7/2/24 17:56, Claudio Imbrenda wrote:
> arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but
> linux/kvm_host.h includes asm/kvm_host.h .
>
> It turns out that arch/s390/include/asm/kvm_host.h only needs
> linux/kvm_types.h, which it already includes.
>
> Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .
>
> Due to the #ifdef guards, the code works as it is today, but it's ugly
> and it will get in the way of future patches.
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-03 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-02 15:56 [PATCH v1 1/1] KVM: s390: remove useless include Claudio Imbrenda
2024-07-03 10:24 ` Nico Boehr
2024-07-03 10:40 ` Janosch Frank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox