From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Jens Remus <jremus@linux.ibm.com>,
Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>,
Juergen Christ <jchrist@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH 4/9] s390/bug: Introduce and use monitor code macro
Date: Tue, 9 Dec 2025 13:16:56 +0100 [thread overview]
Message-ID: <20251209121701.1856271-5-hca@linux.ibm.com> (raw)
In-Reply-To: <20251209121701.1856271-1-hca@linux.ibm.com>
The first operand address of the monitor call (mc) instruction is the
monitor code. Currently the monitor code is ignored, but this will
change. Therefore add and use MONCODE_BUG instead of a hardcoded zero.
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
arch/s390/include/asm/bug.h | 10 ++++++++--
arch/s390/kernel/traps.c | 5 +++--
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/arch/s390/include/asm/bug.h b/arch/s390/include/asm/bug.h
index 5a635158cbad..1e1dece0eee4 100644
--- a/arch/s390/include/asm/bug.h
+++ b/arch/s390/include/asm/bug.h
@@ -3,7 +3,11 @@
#define _ASM_S390_BUG_H
#include <linux/compiler.h>
+#include <linux/const.h>
+#define MONCODE_BUG _AC(0, U)
+
+#ifndef __ASSEMBLER__
#ifdef CONFIG_BUG
#ifdef CONFIG_DEBUG_BUGVERBOSE
@@ -24,7 +28,7 @@
#define __BUG_ASM(cond_str, flags) \
do { \
asm_inline volatile("\n" \
- "0: mc 0,0\n" \
+ "0: mc %[monc](%%r0),0\n" \
" .section __bug_table,\"aw\"\n" \
"1: .long 0b - . # bug_entry::bug_addr\n" \
__BUG_ENTRY_VERBOSE("%[frmt]", "%[file]", "%[line]") \
@@ -32,7 +36,8 @@ do { \
" .org 1b+%[size]\n" \
" .previous" \
: \
- : [frmt] "i" (WARN_CONDITION_STR(cond_str)), \
+ : [monc] "i" (MONCODE_BUG), \
+ [frmt] "i" (WARN_CONDITION_STR(cond_str)), \
[file] "i" (__FILE__), \
[line] "i" (__LINE__), \
[flgs] "i" (flags), \
@@ -54,6 +59,7 @@ do { \
#define HAVE_ARCH_BUG_FORMAT
#endif /* CONFIG_BUG */
+#endif /* __ASSEMBLER__ */
#include <asm-generic/bug.h>
diff --git a/arch/s390/kernel/traps.c b/arch/s390/kernel/traps.c
index 19687dab32f7..de63e98e724b 100644
--- a/arch/s390/kernel/traps.c
+++ b/arch/s390/kernel/traps.c
@@ -258,11 +258,12 @@ static void __init test_monitor_call(void)
if (!IS_ENABLED(CONFIG_BUG))
return;
asm_inline volatile(
- " mc 0,0\n"
+ " mc %[monc](%%r0),0\n"
"0: lhi %[val],0\n"
"1:\n"
EX_TABLE(0b, 1b)
- : [val] "+d" (val));
+ : [val] "+d" (val)
+ : [monc] "i" (MONCODE_BUG));
if (!val)
panic("Monitor call doesn't work!\n");
}
--
2.51.0
next prev parent reply other threads:[~2025-12-09 12:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 12:16 [PATCH 0/9] s390: Exception based WARN() / WARN_ONCE() Heiko Carstens
2025-12-09 12:16 ` [PATCH 1/9] kbuild: Require gcc-9 for s390 Heiko Carstens
2025-12-09 12:16 ` [PATCH 2/9] s390/bug: Convert to inline assembly with input operands Heiko Carstens
2025-12-09 12:16 ` [PATCH 3/9] s390/bug: Use BUG_FORMAT for DEBUG_BUGVERBOSE_DETAILED Heiko Carstens
2025-12-09 12:16 ` Heiko Carstens [this message]
2025-12-09 12:16 ` [PATCH 5/9] s390/traps: Copy monitor code to pt_regs Heiko Carstens
2025-12-09 12:16 ` [PATCH 6/9] s390/bug: Implement __WARN_printf() Heiko Carstens
2025-12-09 12:35 ` Peter Zijlstra
2025-12-09 14:42 ` Heiko Carstens
2025-12-10 13:09 ` kernel test robot
2025-12-10 14:57 ` kernel test robot
2025-12-09 12:16 ` [PATCH 7/9] s390/bug: Implement WARN_ONCE() Heiko Carstens
2025-12-09 12:17 ` [PATCH 8/9] s390/bug: Skip __WARN_trap() in call traces Heiko Carstens
2025-12-09 12:17 ` [PATCH 9/9] s390/bug: Prevent tail-call optimization Heiko Carstens
2025-12-09 12:47 ` Peter Zijlstra
2025-12-09 12:56 ` [PATCH 0/9] s390: Exception based WARN() / WARN_ONCE() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251209121701.1856271-5-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=jchrist@linux.ibm.com \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=stefansf@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox