From: Peter Zijlstra <peterz@infradead.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Jens Remus <jremus@linux.ibm.com>,
Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>,
Juergen Christ <jchrist@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/9] s390: Exception based WARN() / WARN_ONCE()
Date: Tue, 9 Dec 2025 13:56:27 +0100 [thread overview]
Message-ID: <20251209125627.GG3707837@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251209121701.1856271-1-hca@linux.ibm.com>
On Tue, Dec 09, 2025 at 01:16:52PM +0100, Heiko Carstens wrote:
> Use the generic infrastructure introduced by Peter Zijlstra [1] to implement
> an exception based WARN() and WARN_ONCE() similar to x86.
>
> Due to some compiler oddities on s390 this requires to raise the minimum gcc
> version to 9. Maybe there are ways to avoid this, but I failed to find a
> working solution. Details are in the patch descriptions.
>
> Just posting this now to also get some compile bot testing, since I'm afraid
> there might be some compiler version / config option around where even this
> new approach breaks.
>
> Peter, since you were wondering: your generic infrastructure pieces work very
> nice. Looking at the x86 and s390 implementation: it might be possible to make
> things even more generic since both __WARN_printf(), and WARN_ONCE() are
> identical; it looks like only __WARN_print_arg() needs to be provided.
Nice! and yeah, perhaps we can unify that later.
prev parent reply other threads:[~2025-12-09 12:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 12:16 [PATCH 0/9] s390: Exception based WARN() / WARN_ONCE() Heiko Carstens
2025-12-09 12:16 ` [PATCH 1/9] kbuild: Require gcc-9 for s390 Heiko Carstens
2025-12-09 12:16 ` [PATCH 2/9] s390/bug: Convert to inline assembly with input operands Heiko Carstens
2025-12-09 12:16 ` [PATCH 3/9] s390/bug: Use BUG_FORMAT for DEBUG_BUGVERBOSE_DETAILED Heiko Carstens
2025-12-09 12:16 ` [PATCH 4/9] s390/bug: Introduce and use monitor code macro Heiko Carstens
2025-12-09 12:16 ` [PATCH 5/9] s390/traps: Copy monitor code to pt_regs Heiko Carstens
2025-12-09 12:16 ` [PATCH 6/9] s390/bug: Implement __WARN_printf() Heiko Carstens
2025-12-09 12:35 ` Peter Zijlstra
2025-12-09 14:42 ` Heiko Carstens
2025-12-10 13:09 ` kernel test robot
2025-12-10 14:57 ` kernel test robot
2025-12-09 12:16 ` [PATCH 7/9] s390/bug: Implement WARN_ONCE() Heiko Carstens
2025-12-09 12:17 ` [PATCH 8/9] s390/bug: Skip __WARN_trap() in call traces Heiko Carstens
2025-12-09 12:17 ` [PATCH 9/9] s390/bug: Prevent tail-call optimization Heiko Carstens
2025-12-09 12:47 ` Peter Zijlstra
2025-12-09 12:56 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251209125627.GG3707837@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jchrist@linux.ibm.com \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=stefansf@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox