public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
	borntraeger@linux.ibm.com, nrb@linux.ibm.com
Subject: [kvm-unit-tests 3/5] lib: s390x: sie: Free guest memory on destroy
Date: Wed, 15 Apr 2026 08:45:43 +0000	[thread overview]
Message-ID: <20260415085145.91197-4-frankja@linux.ibm.com> (raw)
In-Reply-To: <20260415085145.91197-1-frankja@linux.ibm.com>

We never freed the memory that the sie library allocates as the guest
ram on destruction of the VM. Most tests reuse the VM or just leak the
memory since the standard allocation is one megabyte and tests only
use single digit numbers of VMs.

It's time to add automatic freeing to the sie library when a VM is
destroyed.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 lib/s390x/sie.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/s390x/sie.c b/lib/s390x/sie.c
index a49c45c7..758ead77 100644
--- a/lib/s390x/sie.c
+++ b/lib/s390x/sie.c
@@ -192,4 +192,5 @@ void sie_guest_destroy(struct vm *vm)
 	free_page(vm->sblk);
 	if (vm->sblk->ecb2 & ECB2_ESCA)
 		free_page(vm->sca);
+	free_pages((void *)virt_to_pte_phys(get_page_root(), vm->guest_mem));
 }
-- 
2.51.0


  parent reply	other threads:[~2026-04-15  8:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  8:45 [kvm-unit-tests 0/5] s390x: Cleanup virtualization library Janosch Frank
2026-04-15  8:45 ` [kvm-unit-tests 1/5] lib: s390x: Add function to get page root Janosch Frank
2026-04-15 11:53   ` Nico Boehr
2026-04-15 12:01     ` Janosch Frank
2026-04-15  8:45 ` [kvm-unit-tests 2/5] lib: s390x: sie: Allocate physical guest memory via memalign Janosch Frank
2026-04-15  8:45 ` Janosch Frank [this message]
2026-04-15 14:21   ` [kvm-unit-tests 3/5] lib: s390x: sie: Free guest memory on destroy Nico Boehr
2026-04-15  8:45 ` [kvm-unit-tests 4/5] lib: s390x: snippet: Add function to create a guest of specific length Janosch Frank
2026-04-15  8:45 ` [kvm-unit-tests 5/5] lib: s390x: Remove kvm s390 prefix from sie control block Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415085145.91197-4-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox