* [PATCH v2 0/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events
@ 2026-04-16 21:39 Ramesh Errabolu
2026-04-16 21:39 ` [PATCH v2 1/1] " Ramesh Errabolu
0 siblings, 1 reply; 2+ messages in thread
From: Ramesh Errabolu @ 2026-04-16 21:39 UTC (permalink / raw)
To: linux-pci
Cc: linux-kernel, linux-s390, Bjorn Helgaas, Lukas Wunner,
Niklas Schnelle, Peter Oberparleiter, Matthew Rosato, Gerd Bayer,
Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Ramesh Errabolu
Hi all,
This is v2 of the patch adding write-only uevent
support for PCI slots. The original v1 was posted
in February 2026 and received valuable feedback from
Leon Romanovsky and others. This v2 addresses the feedback
and is rebased onto the current kernel tree.
Link to v1:
https://lore.kernel.org/all/20260225150815.81268-1-ramesh@linux.ibm.com/
Testing: Tested on s390x with multiple PCI slots
- Write-only uevent attribute is created for each slot
- Writing "add" triggers proper uevent generation
- udevadm-trigger successfully generates slot uevents
- Events are properly received by udev monitoring tools
Changes since v1 (February 2026):
- Improved commit message clarity, per reviewer feedback
- Rebased onto current kernel tree (v7.x)
Ramesh Errabolu (1):
PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events
drivers/pci/hotplug/pci_hotplug_core.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events
2026-04-16 21:39 [PATCH v2 0/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events Ramesh Errabolu
@ 2026-04-16 21:39 ` Ramesh Errabolu
0 siblings, 0 replies; 2+ messages in thread
From: Ramesh Errabolu @ 2026-04-16 21:39 UTC (permalink / raw)
To: linux-pci
Cc: linux-kernel, linux-s390, Bjorn Helgaas, Lukas Wunner,
Niklas Schnelle, Peter Oberparleiter, Matthew Rosato, Gerd Bayer,
Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Ramesh Errabolu
Add a write-only 'uevent' sysfs attribute for synthesizing
uevents for a PCI slot. This extends the existing uevent
support which emits a KOBJ_ADD uevent in pci_hp_add() with
the ability to replay such uevents for cold plugged devices.
As such events are only emitted by hotplug capable PCI slots
so is the support for synthesizing them.
The change was validated by manually triggering 'add' uevent
for a specific hotplug PCI slot:
$ echo "add $(uuidgen)" | sudo tee \
/sys/bus/pci/slots/<slot-id>/uevent
Signed-off-by: Ramesh Errabolu <ramesh@linux.ibm.com>
---
drivers/pci/hotplug/pci_hotplug_core.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index fadcf98a8a66..c3634b1cc7a8 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -176,6 +176,21 @@ static struct pci_slot_attribute hotplug_slot_attr_presence = {
.show = presence_read_file,
};
+static ssize_t uevent_write_file(struct pci_slot *slot,
+ const char *buf, size_t len)
+{
+ int rc;
+
+ rc = kobject_synth_uevent(&slot->kobj, buf, len);
+ return rc ? rc : len;
+}
+
+static struct pci_slot_attribute hotplug_slot_attr_uevent = {
+ .attr = {.name = "uevent", .mode = S_IFREG | 0200},
+ .show = NULL,
+ .store = uevent_write_file
+};
+
static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
size_t count)
{
@@ -254,6 +269,11 @@ static int fs_add_slot(struct hotplug_slot *slot, struct pci_slot *pci_slot)
kobject_put(kobj);
}
+ retval = sysfs_create_file(&pci_slot->kobj,
+ &hotplug_slot_attr_uevent.attr);
+ if (retval)
+ goto exit_uevent;
+
if (has_power_file(slot)) {
retval = sysfs_create_file(&pci_slot->kobj,
&hotplug_slot_attr_power.attr);
@@ -306,6 +326,9 @@ static int fs_add_slot(struct hotplug_slot *slot, struct pci_slot *pci_slot)
if (has_power_file(slot))
sysfs_remove_file(&pci_slot->kobj, &hotplug_slot_attr_power.attr);
exit_power:
+ sysfs_remove_file(&pci_slot->kobj,
+ &hotplug_slot_attr_uevent.attr);
+exit_uevent:
sysfs_remove_link(&pci_slot->kobj, "module");
exit:
return retval;
@@ -313,6 +336,8 @@ static int fs_add_slot(struct hotplug_slot *slot, struct pci_slot *pci_slot)
static void fs_remove_slot(struct hotplug_slot *slot, struct pci_slot *pci_slot)
{
+ sysfs_remove_file(&pci_slot->kobj, &hotplug_slot_attr_uevent.attr);
+
if (has_power_file(slot))
sysfs_remove_file(&pci_slot->kobj, &hotplug_slot_attr_power.attr);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-16 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-16 21:39 [PATCH v2 0/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events Ramesh Errabolu
2026-04-16 21:39 ` [PATCH v2 1/1] " Ramesh Errabolu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox