Re: [PATCH v4 4/4] KVM: s390: vsie: Implement ASTFLEIE facility 2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect offset comment for `fac` array in `struct vsie_page`.
--

commit 533d12a005c16677069ec80d3450892c247155e9
Author: Nina Schoetterl-Glausch <nsg@linux.ibm.com>

KVM: s390: vsie: Implement ASTFLEIE facility 2

This commit implements shadowing of the format-2 facility list when
running in VSIE, introducing ASTFLEIE2 support.

> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index 2ea3bbaf568e5..4c20bd787b8b2 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -65,9 +65,9 @@ struct vsie_page {
>  	gpa_t scb_gpa;				/* 0x0258 */
>  	/* the shadow gmap in use by the vsie_page */
>  	struct gmap_cache gmap_cache;		/* 0x0260 */
> -	__u8 reserved[0x0700 - 0x0278];		/* 0x0278 */
> -	struct kvm_s390_crypto_cb crycb;	/* 0x0700 */
> -	__u8 fac[S390_ARCH_FAC_LIST_SIZE_BYTE];	/* 0x0800 */
> +	__u8 reserved[0x06f8 - 0x0278];		/* 0x0278 */
> +	struct kvm_s390_crypto_cb crycb;	/* 0x06f8 */
> +	__u8 fac[8 + S390_ARCH_FAC_LIST_SIZE_BYTE];/* 0x0800 */

[Severity: Low]
This isn't a bug, but the comment indicating the offset for the fac
array appears to be incorrect after this layout change.

Since crycb was shifted back 8 bytes to start at 0x06f8, and 
struct kvm_s390_crypto_cb is 256 bytes in size (0x0100), the fac array 
now starts at 0x07f8. 

Should this comment be updated to /* 0x07f8 */ to reflect the new offset?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260612-vsie-alter-stfle-fac-v4-0-74f0e1559929@linux.ibm.com?part=4