From: sashiko-bot@kernel.org
To: "Heiko Carstens" <hca@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v2 1/4] s390/crypto: Replace cond_resched() with msleep(1)
Date: Tue, 28 Jul 2026 15:32:06 +0000 [thread overview]
Message-ID: <20260728153207.B69BB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260728150412.3893933-2-hca@linux.ibm.com>
> With [1] cond_resched() is always compiled away and becomes a no-op.
>
> The comments for all cond_resched() calls in crypto code however indicate
> that the current process should be scheduled away to avoid instant
> re-invocation of a callback. This is not what cond_resched() would do or
> did.
>
> Instead of just removing the cond_resched() calls, replace them with
> msleep() calls, as suggested by Holger Dengler. This forces the current
> task to be scheduled away (sleeps) like originally intended.
>
> [1] commit 7dadeaa6e851 ("sched: Further restrict the preemption modes")
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260728150412.3893933-1-hca@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-07-28 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 15:04 [PATCH v2 0/4] s390: Remove or replace cond_resched() calls Heiko Carstens
2026-07-28 15:04 ` [PATCH v2 1/4] s390/crypto: Replace cond_resched() with msleep(1) Heiko Carstens
2026-07-28 15:32 ` sashiko-bot [this message]
2026-07-28 16:12 ` Holger Dengler
2026-07-28 16:13 ` Harald Freudenberger
2026-07-28 15:04 ` [PATCH v2 2/4] KVM: s390: Remove cond_resched() calls Heiko Carstens
2026-07-28 15:38 ` sashiko-bot
2026-07-28 15:04 ` [PATCH v2 3/4] " Heiko Carstens
2026-07-28 15:44 ` sashiko-bot
2026-07-28 15:04 ` [PATCH v2 4/4] s390/cio: " Heiko Carstens
2026-07-28 15:48 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728153207.B69BB1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox