From: Heiko Carstens <hca@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Holger Dengler <dengler@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3 1/4] s390/crypto: Replace cond_resched() with msleep(1)
Date: Fri, 31 Jul 2026 13:56:41 +0200 [thread overview]
Message-ID: <20260731115641.8638C01-hca@linux.ibm.com> (raw)
In-Reply-To: <20260731084027.GE776954@noisy.programming.kicks-ass.net>
On Fri, Jul 31, 2026 at 10:40:27AM +0200, Peter Zijlstra wrote:
> On Fri, Jul 31, 2026 at 09:44:57AM +0200, Holger Dengler wrote:
>
> > > Yes, guest migration is very likely far more disruptive than most
> > > anything else. Perhaps clarify the code comment to include some of this
> > > explanation?
> >
> > I agree, the comment is not telling all main key points. What about the
> > following?
> >
> > /*
> > * Protected key expired due to relocation to another
> > * host. The long runnning re-wrap has no asynchronous
> > * completion notification, so polling is required.
> > * Trigger a re-schedule of this request by returning
> > * -ENOSPC ("hardware queue full") to the crypto engine.
> > * To avoid immediately re-invocation of this callback,
> > * tell scheduler to voluntarily give up the CPU here.
> > */
> >
> > (I would leave it up to Heiko to merge the comment in his series, or let
> > Harald/me do it in a separate patch)
>
> Right, perhaps something like so, avoiding the endless copy/paste ?
I guess there won't be any disagreement. I'll merge your patch, and
add Holger's explanation to the commit message.
Thanks!
next prev parent reply other threads:[~2026-07-31 11:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 5:29 [PATCH v3 0/4] s390: Remove or replace cond_resched() calls Heiko Carstens
2026-07-30 5:29 ` [PATCH v3 1/4] s390/crypto: Replace cond_resched() with msleep(1) Heiko Carstens
2026-07-30 5:57 ` sashiko-bot
2026-07-30 7:47 ` Holger Dengler
2026-07-30 10:11 ` Peter Zijlstra
2026-07-30 11:34 ` Holger Dengler
2026-07-30 12:48 ` Peter Zijlstra
2026-07-31 7:44 ` Holger Dengler
2026-07-31 8:40 ` Peter Zijlstra
2026-07-31 11:56 ` Heiko Carstens [this message]
2026-07-30 5:29 ` [PATCH v3 2/4] KVM: s390: Remove cond_resched() calls Heiko Carstens
2026-07-30 5:36 ` sashiko-bot
2026-07-30 8:51 ` Claudio Imbrenda
2026-07-30 5:29 ` [PATCH v3 3/4] " Heiko Carstens
2026-07-30 5:40 ` sashiko-bot
2026-07-30 5:29 ` [PATCH v3 4/4] s390/cio: " Heiko Carstens
2026-07-30 5:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731115641.8638C01-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@kernel.org \
--cc=dengler@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=imbrenda@linux.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox