From: sashiko-bot@kernel.org
To: "Wilson Felipe Pereira" <wfelipe@google.com>
Cc: linux-s390@vger.kernel.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v2 2/2] init/Kconfig: make config INIT_ENV_ARG_LIMIT user-configurable
Date: Tue, 18 Aug 2026 23:22:54 +0000 [thread overview]
Message-ID: <20260818232254.E42F11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818231646.804507-3-wfelipe@google.com>
> INIT_ENV_ARG_LIMIT is defined without a prompt string (`int`), making it
> a hidden Kconfig symbol that defaults to 32 (or 128 for UML) and cannot
> be configured in `make menuconfig`.
>
> Now that CONFIG_COMMAND_LINE_SIZE is configurable across all architectures,
> users who select larger kernel command lines (e.g., 4096 bytes) may pass
> more than 32 command-line arguments or environment variables (`foo=bar`) to
> `/sbin/init`. If INIT_ENV_ARG_LIMIT remains hardcoded at 32, any argument
> after the 32nd sets the panic_later flag and causes a hard kernel panic
> on boot.
>
> Add a prompt string ("Maximum number of kernel command line arguments") and
> a `range 32 4096` to `config INIT_ENV_ARG_LIMIT` so that users can
> configure their init argument and environment variable limit when needed,
> while preserving the existing default of 32 for standard builds.
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> Signed-off-by: Wilson Felipe Pereira <wfelipe@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818231646.804507-1-wfelipe@google.com?part=2
prev parent reply other threads:[~2026-08-18 23:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 23:16 [PATCH v2 0/2] init, arch: make command line size and init arg limit configurable Wilson Felipe Pereira
2026-08-18 23:16 ` [PATCH v2 1/2] init, arch: make CONFIG_COMMAND_LINE_SIZE globally configurable Wilson Felipe Pereira
2026-08-18 23:23 ` sashiko-bot
2026-08-18 23:16 ` [PATCH v2 2/2] init/Kconfig: make config INIT_ENV_ARG_LIMIT user-configurable Wilson Felipe Pereira
2026-08-18 23:22 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818232254.E42F11F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wfelipe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox