Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wilson Felipe Pereira" <wfelipe@google.com>
Cc: linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v2 1/2] init, arch: make CONFIG_COMMAND_LINE_SIZE globally configurable
Date: Tue, 18 Aug 2026 23:23:15 +0000	[thread overview]
Message-ID: <20260818232315.99F631F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818231646.804507-2-wfelipe@google.com>

> Currently, s390 has the ability to configure the maximum kernel command
> line size via Kconfig (CONFIG_COMMAND_LINE_SIZE). Other architectures
> define a hardcoded COMMAND_LINE_SIZE macro in their setup.h headers.
> 
> In some use cases, such as netboot kernels, rootfs configurations, or
> larger initramfs setups, a larger command line size is required. While
> for embedded workloads, it can be reduced to save memory.
> 
> Move CONFIG_COMMAND_LINE_SIZE out of arch/s390/Kconfig and into
> init/Kconfig under General setup, and update every architecture's setup.h
> header to define COMMAND_LINE_SIZE as CONFIG_COMMAND_LINE_SIZE.
> 
> For user-space API (uapi) headers, wrap the definition in an
> `#ifdef __KERNEL__` guard and retain the historical hardcoded default in
> the `#else` block. When user-space headers are installed via
> [ ... ]
> architectures are capped at 4096 bytes to prevent unreasonable
> allocations.
> 
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> Signed-off-by: Wilson Felipe Pereira <wfelipe@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818231646.804507-1-wfelipe@google.com?part=1


  reply	other threads:[~2026-08-18 23:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 23:16 [PATCH v2 0/2] init, arch: make command line size and init arg limit configurable Wilson Felipe Pereira
2026-08-18 23:16 ` [PATCH v2 1/2] init, arch: make CONFIG_COMMAND_LINE_SIZE globally configurable Wilson Felipe Pereira
2026-08-18 23:23   ` sashiko-bot [this message]
2026-08-18 23:16 ` [PATCH v2 2/2] init/Kconfig: make config INIT_ENV_ARG_LIMIT user-configurable Wilson Felipe Pereira
2026-08-18 23:22   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818232315.99F631F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wfelipe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox