Re: [PATCH v6 08/13] mips: Get rid of custom mips ABIs for syscall tables

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] MIPS syscall table modifications and renames break perf ABI tracking.
--

commit a8e9328861b9ab6474113d3cd1414e8d440494b3
Author: André Almeida <andrealmeid@igalia.com>
Subject: mips: Get rid of custom mips ABIs for syscall tables

This commit replaces the MIPS-exclusive ABI names (n32, o32, n64) with
"common" across the syscall tables to simplify and unify them. There are
no functional changes intended.

> diff --git a/arch/mips/kernel/syscalls/syscall_n64.tbl b/arch/mips/kernel/syscalls/syscall_n64.tbl
> index 83dc93a0712f1..4341b2fd96dad 100644
> --- a/arch/mips/kernel/syscalls/syscall_n64.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_n64.tbl
> @@ -5,385 +5,385 @@
>  # The format is:
>  # <number> <abi> <name> <entry point>
>  #
> -# The <abi> is always "n64" for this file.
> +# The <abi> is always "common" for this file.
>  #
> -0	n64	read				sys_read
> +0	common	read				sys_read

[Severity: Medium]
Will this change cause a 'Kernel ABI header differences' warning when
building perf?

Running make in tools/perf/ checks the kernel's syscall_n64.tbl against
its own vendored copy in tools/perf/arch/mips/entry/syscalls/. Because
this patch updates the ABI field to common without synchronizing the
tools/perf/ copy, the two will fall out of sync.

Additionally, if this file is later renamed or replaced in the series
(for example, unified into syscall_n.tbl), will tools/perf/check-headers.sh
also need to be updated to track the new name? If the check script silently
skips missing original files, perf might permanently lose tracking and fall
back to using an outdated copy of the table, failing to decode any new
MIPS syscalls added in the future.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828-tonyk-syscall_table-v6-0-fdd358456cf1@igalia.com?part=8