Re: [PATCH v6 10/13] syscalls: Add an option for offsetting the common table

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The script `scripts/syscalltbl.sh` inadvertently includes dead code checking for an uninitialized `$offset` variable, which can break the build if inherited from the environment.
--

commit 4e263c69abbb8a963d9217a6ad52a5803ed295f2
Author: André Almeida <andrealmeid@igalia.com>

syscalls: Add an option for offsetting the common table

This commit adds a --common-offset option to the scripts generating syscall
headers and tables. This allows the common syscall table to be offset by a
specified value. It is intended to help architectures like alpha reuse the
common table.

> diff --git a/scripts/syscalltbl.sh b/scripts/syscalltbl.sh
> index f5b95b19ac92d..eaad7be4c3936 100755
> --- a/scripts/syscalltbl.sh
> +++ b/scripts/syscalltbl.sh
[ ... ]
> @@ -59,14 +64,23 @@ outfile="$2"
>  
>  nxt=0
>  
> -# gen_tbl(infile)
> +# gen_tbl(infile, offset_nr)
>  gen_tbl() {
>  	input=$1
>  	tmpfile=$(mktemp -p .)
> +	offset_nr=$2
>  
>  	grep -E "^[0-9A-Fa-fXx]+[[:space:]]+$abis" "$input" > $tmpfile
>  	while read nr abi name native compat noreturn; do
>  
> +                if [ -n "$offset_nr" ]; then
> +                        nr=$((nr + offset_nr))
> +                fi
> +
> +		if [ -n "$offset" ]; then
> +			nr="($offset + $nr)"
> +		fi

[Severity: Low]
Does this code inadvertently use an uninitialized $offset variable?

The script scripts/syscalltbl.sh does not initialize the $offset variable
like scripts/syscallhdr.sh does. If an offset environment variable happens
to be exported by the user or CI, this condition evaluates to true, and nr
is modified into a string.

The subsequent check [ $nxt -gt $nr ] strictly requires an integer and would
fail with a shell syntax error, halting the build.

Was this block copied from scripts/syscallhdr.sh by mistake?

> +
>  		if [ $nxt -gt $nr ]; then
>  			echo "error: $input: syscall table is not sorted or duplicates the same syscall number" >&2
>  			exit 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828-tonyk-syscall_table-v6-0-fdd358456cf1@igalia.com?part=10