Re: [PATCH v7 16/23] KVM: s390: arm64: Introduce host definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The vCPU Hypervisor Configuration Register is named `hcr_elz` instead of `hcr_el2`, introducing a confusing typo/naming anomaly.
--

commit 22fd1b09d8ddab9e5e022c14adc2bbf3373594b6
Author: Steffen Eiden <seiden@linux.ibm.com>

KVM: s390: arm64: Introduce host definitions

Add all basic definitions the arm on s390 KVM host requires. This includes
struct kvm*arch definitions, various functions, and macros to run arm64
guests, and updates asm/kvm_host.h to use the new header if KVM_S390_ARM64
is defined.

> diff --git a/arch/s390/include/asm/kvm_host_arm64.h b/arch/s390/include/asm/kvm_host_arm64.h
> new file mode 100644
> index 0000000000000..b8a689c649bd8
> --- /dev/null
> +++ b/arch/s390/include/asm/kvm_host_arm64.h
[ ... ]
> @@ -0,0 +1,211 @@
[ ... ]
> +struct kvm_vcpu_arch {
> +	struct kvm_sae_block sae_block;
> +	struct kvm_sae_save_area save_area;
> +	struct kvm_cpu_context ctxt;
> +
> +	u32 host_acrs[NUM_ACRS];
> +
> +	/* Hypervisor Configuration Register */
> +	u64 hcr_elz;

[Severity: Low]
Is hcr_elz intended to be hcr_el2 here?

While this might be an intentional pun and does not break compilation 
because shared ARM64 KVM logic compiled under ARM64_S390_COMMON does not 
currently access vcpu->arch.hcr_el2, naming this register hcr_elz departs 
from standard ARM64 architectural nomenclature. 

Could this cause confusion for future development trying to match ARM64 
architectural registers?

> +
> +	/* Configuration flags, set once and for all before the vcpu can run */
> +	u8 cflags;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831144802.834315-1-seiden@linux.ibm.com?part=16