From: sashiko-bot@kernel.org
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v2 03/15] asm-generic: add an in-kernel auxvec.h header
Date: Thu, 03 Sep 2026 07:51:58 +0000 [thread overview]
Message-ID: <20260903075159.390771F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903-at-vector-size-arch-v2-3-5bc32a71e3d8@linutronix.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect include guard name in `include/asm-generic/auxvec.h`.
--
commit a6c0fee565d771a1d46c4c885fe6773f26339df1
Author: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
asm-generic: add an in-kernel auxvec.h header
This commit adds asm-generic infrastructure to handle fallbacks for
architectures which are not migrated yet and those which won't require
their own definition of auxvec.h. It also extends linux/auxvec.h to
cover all potential low-level auxvec.h headers.
> diff --git a/include/asm-generic/auxvec.h b/include/asm-generic/auxvec.h
> new file mode 100644
> index 0000000000000..e4abd2a8c5ed3
> --- /dev/null
> +++ b/include/asm-generic/auxvec.h
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __ASM_GENERIC_AUXVAL_H__
> +#define __ASM_GENERIC_AUXVAL_H__
[Severity: Low]
This isn't a bug, but there appears to be a typo in the include guard. The
macro name __ASM_GENERIC_AUXVAL_H__ does not match the filename auxvec.h.
Should this be named __ASM_GENERIC_AUXVEC_H__ instead?
> +
> +#define AT_VECTOR_SIZE_ARCH 0
> +
> +#endif
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-at-vector-size-arch-v2-0-5bc32a71e3d8@linutronix.de?part=3
next prev parent reply other threads:[~2026-09-03 7:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:41 [PATCH v2 00/15] exec: Remove AT_VECTOR_SIZE_ARCH from UAPI Thomas Weißschuh
2026-09-03 7:41 ` [PATCH v2 01/15] MAINTAINERS: exec: Add more auxvec.h variants Thomas Weißschuh
2026-09-03 7:41 ` [PATCH v2 02/15] auxvec.h: Move AT_VECTOR_SIZE definitions to linux/auxvec.h Thomas Weißschuh
2026-09-03 7:53 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 03/15] asm-generic: add an in-kernel auxvec.h header Thomas Weißschuh
2026-09-03 7:51 ` sashiko-bot [this message]
2026-09-03 7:41 ` [PATCH v2 04/15] ARM: drop custom asm/auxvec.h Thomas Weißschuh
2026-09-03 7:56 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 05/15] x86: Remove AT_VECTOR_SIZE_ARCH from UAPI Thomas Weißschuh
2026-09-03 7:57 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 06/15] arm64: " Thomas Weißschuh
2026-09-03 8:15 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 07/15] RISC-V: " Thomas Weißschuh
2026-09-03 7:59 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 08/15] LoongArch: " Thomas Weißschuh
2026-09-03 7:59 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 09/15] s390: " Thomas Weißschuh
2026-09-03 8:02 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 10/15] powerpc: " Thomas Weißschuh
2026-09-03 8:10 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 11/15] MIPS: " Thomas Weißschuh
2026-09-03 8:04 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 12/15] sparc: " Thomas Weißschuh
2026-09-03 8:12 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 13/15] sh: " Thomas Weißschuh
2026-09-03 8:12 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 14/15] alpha: remove " Thomas Weißschuh
2026-09-03 8:18 ` sashiko-bot
2026-09-03 7:41 ` [PATCH v2 15/15] auxvec.h: Drop fallback AT_VECTOR_SIZE_ARCH Thomas Weißschuh
2026-09-03 8:33 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903075159.390771F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox