Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
	linux-s390@vger.kernel.org,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v2 07/15] RISC-V: Remove AT_VECTOR_SIZE_ARCH from UAPI
Date: Thu, 03 Sep 2026 07:59:27 +0000	[thread overview]
Message-ID: <20260903075928.4040C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903-at-vector-size-arch-v2-7-5bc32a71e3d8@linutronix.de>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Copy-paste error in header guard comment.
--

commit 720f0a96cf858b439bf53a700bc4833d17fac31f
Author: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

RISC-V: Remove AT_VECTOR_SIZE_ARCH from UAPI

This commit removes AT_VECTOR_SIZE_ARCH from the RISC-V UAPI headers since 
it is not used by userspace. It moves the symbol to a newly created 
kernel-internal header instead.

> diff --git a/arch/riscv/include/asm/auxvec.h b/arch/riscv/include/asm/auxvec.h
> new file mode 100644
> index 0000000000000..fb4233445276a
> --- /dev/null
> +++ b/arch/riscv/include/asm/auxvec.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (C) 2012 ARM Ltd.
> + * Copyright (C) 2015 Regents of the University of California
> + */
> +
> +#ifndef _ASM_RISCV_AUXVEC_H
> +#define _ASM_RISCV_AUXVEC_H
> +
> +/* entries in ARCH_DLINFO */
> +#define AT_VECTOR_SIZE_ARCH	10
> +
> +#endif /* _UAPI_ASM_RISCV_AUXVEC_H */

[Severity: Low]
This isn't a bug, but should this #endif comment match the newly defined 
_ASM_RISCV_AUXVEC_H guard at the top of the file instead of referencing 
the old UAPI header guard?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-at-vector-size-arch-v2-0-5bc32a71e3d8@linutronix.de?part=7

  reply	other threads:[~2026-09-03  7:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  7:41 [PATCH v2 00/15] exec: Remove AT_VECTOR_SIZE_ARCH from UAPI Thomas Weißschuh
2026-09-03  7:41 ` [PATCH v2 01/15] MAINTAINERS: exec: Add more auxvec.h variants Thomas Weißschuh
2026-09-03  7:41 ` [PATCH v2 02/15] auxvec.h: Move AT_VECTOR_SIZE definitions to linux/auxvec.h Thomas Weißschuh
2026-09-03  7:53   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 03/15] asm-generic: add an in-kernel auxvec.h header Thomas Weißschuh
2026-09-03  7:51   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 04/15] ARM: drop custom asm/auxvec.h Thomas Weißschuh
2026-09-03  7:56   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 05/15] x86: Remove AT_VECTOR_SIZE_ARCH from UAPI Thomas Weißschuh
2026-09-03  7:57   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 06/15] arm64: " Thomas Weißschuh
2026-09-03  8:15   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 07/15] RISC-V: " Thomas Weißschuh
2026-09-03  7:59   ` sashiko-bot [this message]
2026-09-03  7:41 ` [PATCH v2 08/15] LoongArch: " Thomas Weißschuh
2026-09-03  7:59   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 09/15] s390: " Thomas Weißschuh
2026-09-03  8:02   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 10/15] powerpc: " Thomas Weißschuh
2026-09-03  8:10   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 11/15] MIPS: " Thomas Weißschuh
2026-09-03  8:04   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 12/15] sparc: " Thomas Weißschuh
2026-09-03  8:12   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 13/15] sh: " Thomas Weißschuh
2026-09-03  8:12   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 14/15] alpha: remove " Thomas Weißschuh
2026-09-03  8:18   ` sashiko-bot
2026-09-03  7:41 ` [PATCH v2 15/15] auxvec.h: Drop fallback AT_VECTOR_SIZE_ARCH Thomas Weißschuh
2026-09-03  8:33   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903075928.4040C1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox