Linux s390 Architecture development
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: "Mike Rapoport (Microsoft)" <rppt@kernel.org>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc()
Date: Wed, 18 Nov 2026 11:09:09 +0100	[thread overview]
Message-ID: <20261118100909.14542A04-hca@linux.ibm.com> (raw)
In-Reply-To: <20261118091126.25efaea8@pumpkin>

On Wed, Nov 18, 2026 at 09:11:26AM +0000, David Laight wrote:
> On Mon, 16 Nov 2026 16:22:16 +0100
> Heiko Carstens <hca@linux.ibm.com> wrote:
> > It is a bit subtle that this really works. EXT_SCCB_READ_CPU is 3 * PAGE_SIZE,
> > so we end up with a guaranteed 4k alignment from the slab cache, which is
> > indeed sufficient here. But this is really not obvious, and not as stable as
> > before, IMHO.
> > 
> > I'd prefer to have this changed to:
> > 
> > 	sccb = kzalloc(PAGE_SIZE << get_order(length), GFP_KERNEL | GFP_DMA);
> > 
> > which comes with the same alignment guarantees as before.
> 
> Would it be better (more obvious) to round up EXT_SCCB_READ_CPU ?

Mike sent already a new version; this is now good enough.

  reply	other threads:[~2026-11-18 10:09 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  8:58 [PATCH 00/14] s390/sclp: replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 01/14] s390/sclp_vt220: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 02/14] s390/sclp_config: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 03/14] s390/sclp_pci: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 04/14] s390/sclp_ctl: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 05/14] s390/sclp_con: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 06/14] s390/sclp_tty: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 07/14] s390/sclp: Replace __get_free_page() with kmalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 08/14] s390/sclp_sdias: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 09/14] s390/sclp_sd: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-16 15:12   ` Alexander Gordeev
2026-11-17 13:08     ` Mike Rapoport
2026-11-16 15:22   ` Heiko Carstens
2026-11-17 13:08     ` Mike Rapoport
2026-11-18  9:11     ` David Laight
2026-11-18 10:09       ` Heiko Carstens [this message]
2026-11-08  8:58 ` [PATCH 11/14] s390/sclp_cpi: Replace get_zeroed_page() " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 12/14] s390/sclp_ftp: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-16 15:26   ` Heiko Carstens
2026-11-17 13:09     ` Mike Rapoport
2026-11-16 15:27   ` Alexander Gordeev
2026-11-08  8:58 ` [PATCH 13/14] s390/sclp_mem: Replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 14/14] s390/sclp_ap: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-16 15:28 ` [PATCH 00/14] s390/sclp: replace page allocator calls with k[mz]alloc() Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118100909.14542A04-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david.laight.linux@gmail.com \
    --cc=david@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox