public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v1 2/2] s390x: add cmm migration test
Date: Tue, 10 May 2022 16:13:17 +0200	[thread overview]
Message-ID: <3c9561c190a61869ae55b7d762407379faed968c.camel@linux.ibm.com> (raw)
In-Reply-To: <20220510154520.52274a76@p-imbrenda>

On Tue, 2022-05-10 at 15:45 +0200, Claudio Imbrenda wrote:
> ok, next less ugly thing: unroll the loop
> 
> for (i = 0; i < NUM_PAGES; i += 4) {
>         essa(ESSA_SET_STABLE, (unsigned long)pagebuf[i]);
>         essa(ESSA_SET_UNUSED, (unsigned long)pagebuf[i + 1]);
>         ... etc
> }
> 
> maybe assert(NUM_PAGES % 4 == 0) before that, just for good measure

That's nicer, thanks, fixed.

  reply	other threads:[~2022-05-10 14:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 12:08 [kvm-unit-tests PATCH v1 0/2] s390x: add migration test for CMM Nico Boehr
2022-05-09 12:08 ` [kvm-unit-tests PATCH v1 1/2] lib: s390x: add header for CMM related defines Nico Boehr
2022-05-09 12:08 ` [kvm-unit-tests PATCH v1 2/2] s390x: add cmm migration test Nico Boehr
2022-05-09 13:58   ` Claudio Imbrenda
2022-05-10 13:25     ` Nico Boehr
2022-05-10 13:45       ` Claudio Imbrenda
2022-05-10 14:13         ` Nico Boehr [this message]
2022-05-09 14:00 ` [kvm-unit-tests PATCH v1 0/2] s390x: add migration test for CMM Claudio Imbrenda
2022-05-10 10:58   ` Nico Boehr
2022-05-10 12:47     ` Janosch Frank
2022-05-11  8:59       ` Nico Boehr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c9561c190a61869ae55b7d762407379faed968c.camel@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox