public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v1 0/2] s390x: add migration test for CMM
Date: Tue, 10 May 2022 12:58:14 +0200	[thread overview]
Message-ID: <aaf93deff51ccac5d17d8a6d38c399745ecf30c1.camel@linux.ibm.com> (raw)
In-Reply-To: <20220509160009.3d90cbe4@p-imbrenda>

On Mon, 2022-05-09 at 16:00 +0200, Claudio Imbrenda wrote:
> I wonder if we are going to have more of these "split" tests.
> 
> is there a way to make sure migration prerequisites are always
> present?

We could not run _any_ tests if netcat is not installed, which seems
like a bad idea. 

> or rewrite things so that we don't need them?

We need ncat to communicate with the QEMU QMP over unix socket. I am
not aware of a way to use unix sockets in Bash, but no expert either.

We could ship our own version of netcat and build it for the host,
which adds additional complexity and maintenance burden. 

I honestly can't think of a good way.

Or we just put all cmm tests in a single file and accept the fact that
if you don't have all the migration related requirements installed, you
don't get all the tests - even some which are not at all related to
migration. I did not like that so I went with the extra file.

  reply	other threads:[~2022-05-10 10:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 12:08 [kvm-unit-tests PATCH v1 0/2] s390x: add migration test for CMM Nico Boehr
2022-05-09 12:08 ` [kvm-unit-tests PATCH v1 1/2] lib: s390x: add header for CMM related defines Nico Boehr
2022-05-09 12:08 ` [kvm-unit-tests PATCH v1 2/2] s390x: add cmm migration test Nico Boehr
2022-05-09 13:58   ` Claudio Imbrenda
2022-05-10 13:25     ` Nico Boehr
2022-05-10 13:45       ` Claudio Imbrenda
2022-05-10 14:13         ` Nico Boehr
2022-05-09 14:00 ` [kvm-unit-tests PATCH v1 0/2] s390x: add migration test for CMM Claudio Imbrenda
2022-05-10 10:58   ` Nico Boehr [this message]
2022-05-10 12:47     ` Janosch Frank
2022-05-11  8:59       ` Nico Boehr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaf93deff51ccac5d17d8a6d38c399745ecf30c1.camel@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox