From: Harald Freudenberger <freude@linux.ibm.com>
To: linux-s390@vger.kernel.org
Subject: Re: potential bufferovflows in drivers/s390/crypto/
Date: Tue, 26 Jun 2018 07:25:42 +0000 [thread overview]
Message-ID: <41c73b2c-7030-a908-6e9f-fa06f7af8a03@linux.ibm.com> (raw)
In-Reply-To: <20180626072220.GG4299@osiris>
On 26.06.2018 09:22, Heiko Carstens wrote:
> On Tue, Jun 26, 2018 at 09:37:01AM +0300, Georgi Guninski wrote:
>> On Tue, Jun 26, 2018 at 08:05:47AM +0200, Heiko Carstens wrote:
>>> This is actually already the third time that somebody reports a potential
>>> buffer overflow for this function. Could you please add a comment in the
>>> code to avoid future confusion?
>> This also confuses static analyzers and they don't read comments.
>> In one of the functions (alive in kernel 3.20) adding check is possible.
> Adding an extra, but superfluous, check would be fine with me as
> well. Given that it is obviously non-trivial to tell that this code isn't
> broken.
I'll add checks and comments. However, I will not do any backports for older kernels.
parent reply other threads:[~2018-06-26 7:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180626072220.GG4299@osiris>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41c73b2c-7030-a908-6e9f-fa06f7af8a03@linux.ibm.com \
--to=freude@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox