* Re: potential bufferovflows in drivers/s390/crypto/
[not found] <20180626072220.GG4299@osiris>
@ 2018-06-26 7:25 ` Harald Freudenberger
0 siblings, 0 replies; only message in thread
From: Harald Freudenberger @ 2018-06-26 7:25 UTC (permalink / raw)
To: linux-s390
On 26.06.2018 09:22, Heiko Carstens wrote:
> On Tue, Jun 26, 2018 at 09:37:01AM +0300, Georgi Guninski wrote:
>> On Tue, Jun 26, 2018 at 08:05:47AM +0200, Heiko Carstens wrote:
>>> This is actually already the third time that somebody reports a potential
>>> buffer overflow for this function. Could you please add a comment in the
>>> code to avoid future confusion?
>> This also confuses static analyzers and they don't read comments.
>> In one of the functions (alive in kernel 3.20) adding check is possible.
> Adding an extra, but superfluous, check would be fine with me as
> well. Given that it is obviously non-trivial to tell that this code isn't
> broken.
I'll add checks and comments. However, I will not do any backports for older kernels.
^ permalink raw reply [flat|nested] only message in thread