From: Eric Farman <farman@linux.ibm.com>
To: Farhan Ali <alifm@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
pmorel@linux.ibm.com
Subject: Re: [PATCH v3 1/1] vfio-ccw: Prevent quiesce function going into an infinite loop
Date: Tue, 23 Apr 2019 16:37:36 -0400 [thread overview]
Message-ID: <55061641-439f-8964-48e1-fa70f5c4b490@linux.ibm.com> (raw)
In-Reply-To: <a2618478-4b98-a2c2-5f14-a91b193ebf53@linux.ibm.com>
On 4/23/19 3:41 PM, Farhan Ali wrote:
>
>
> On 04/23/2019 01:42 PM, Halil Pasic wrote:
...snip...
>> TL;DR:
>>
>> I welcome this batch (with an r-b) but I would like the commit message
>> and the comment changed so that the misleading 'flush all I/O in the
>> workqueue'.
>>
>> I think 'vfio-ccw: fix cio_cancel_halt_clear() usage' would reflect the
>> content of this patch better, because reasoning about the upper limit,
>> and what happens if this upper limit is hit is not what this patch is
>> about. It is about a client code bug that rendered iretry ineffective.
>>
>
> I politely disagree with the change in subject line. I think the current
> subject line describe what we are trying to prevent with this patch. But
> again if anyone else feels otherwise, I will go ahead and change :)
I think the entire patch is fine as-is.
Reviewed-by: Eric Farman <farman@linux.ibm.com>
>
> Thanks
> Farhan
>
>
>> Regards,
>> Halil
>>
>>
next prev parent reply other threads:[~2019-04-23 20:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1555449329.git.alifm@linux.ibm.com>
2019-04-16 21:23 ` [PATCH v3 1/1] vfio-ccw: Prevent quiesce function going into an infinite loop Farhan Ali
2019-04-17 9:03 ` Cornelia Huck
2019-04-17 13:58 ` Eric Farman
2019-04-17 15:13 ` Halil Pasic
2019-04-17 15:18 ` Farhan Ali
2019-04-19 20:12 ` Halil Pasic
2019-04-22 14:01 ` Farhan Ali
2019-04-23 17:42 ` Halil Pasic
2019-04-23 19:41 ` Farhan Ali
2019-04-23 20:37 ` Eric Farman [this message]
2019-04-24 7:09 ` Cornelia Huck
2019-04-24 10:02 ` Halil Pasic
2019-04-24 10:21 ` Halil Pasic
2019-04-18 14:36 ` Cornelia Huck
2019-04-17 14:02 ` Farhan Ali
2019-04-24 16:35 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55061641-439f-8964-48e1-fa70f5c4b490@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox