From: Farhan Ali <alifm@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
pmorel@linux.ibm.com
Subject: Re: [PATCH v3 1/1] vfio-ccw: Prevent quiesce function going into an infinite loop
Date: Wed, 17 Apr 2019 11:18:19 -0400 [thread overview]
Message-ID: <f457d63a-69b9-43da-c425-5c34fb0d9dd4@linux.ibm.com> (raw)
In-Reply-To: <20190417171311.3478402b@oc2783563651>
On 04/17/2019 11:13 AM, Halil Pasic wrote:
>>> Otherwise, looks good to me. Will queue when I get some ack/r-b.
>>>
>> I like it, but I feel weird giving an r-b to something I suggested:
>>
>> Acked-by: Eric Farman<farman@linux.ibm.com>
>>
> I think r-b is fine. You did verify both the design and the
> implementation I guess. So I don't see why not.
>
> How urgent is this. I could give this some love till the end of the
> week. Should I @Connie,@Farhan?
Having more people review it is always a good thing :)
This patch (and other patches in the original series) are queued for
5.2, and 5.1 is not released yet. I would say we have some time.
>
> I was mostly ignoring these patches so I can't capitalize on my
> understanding from reviewing the previous versions and need some time to
> say something about it.
>
> Regards,
> Halil
>
next prev parent reply other threads:[~2019-04-17 15:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1555449329.git.alifm@linux.ibm.com>
2019-04-16 21:23 ` [PATCH v3 1/1] vfio-ccw: Prevent quiesce function going into an infinite loop Farhan Ali
2019-04-17 9:03 ` Cornelia Huck
2019-04-17 13:58 ` Eric Farman
2019-04-17 15:13 ` Halil Pasic
2019-04-17 15:18 ` Farhan Ali [this message]
2019-04-19 20:12 ` Halil Pasic
2019-04-22 14:01 ` Farhan Ali
2019-04-23 17:42 ` Halil Pasic
2019-04-23 19:41 ` Farhan Ali
2019-04-23 20:37 ` Eric Farman
2019-04-24 7:09 ` Cornelia Huck
2019-04-24 10:02 ` Halil Pasic
2019-04-24 10:21 ` Halil Pasic
2019-04-18 14:36 ` Cornelia Huck
2019-04-17 14:02 ` Farhan Ali
2019-04-24 16:35 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f457d63a-69b9-43da-c425-5c34fb0d9dd4@linux.ibm.com \
--to=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox