* [PATCH 2/7] s390: replace cc-option-yn uses with cc-option [not found] <20210817002109.2736222-1-ndesaulniers@google.com> @ 2021-08-17 0:21 ` Nick Desaulniers 2021-08-17 2:03 ` Nathan Chancellor 2021-08-23 17:43 ` Heiko Carstens 0 siblings, 2 replies; 4+ messages in thread From: Nick Desaulniers @ 2021-08-17 0:21 UTC (permalink / raw) To: Masahiro Yamada Cc: linux-kbuild, clang-built-linux, Nick Desaulniers, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390 cc-option-yn can be replaced with cc-option. ie. Checking for support: ifeq ($(call cc-option-yn,$(FLAG)),y) becomes: ifneq ($(call cc-option,$(FLAG)),) Checking for lack of support: ifeq ($(call cc-option-yn,$(FLAG)),n) becomes: ifeq ($(call cc-option,$(FLAG)),) This allows us to pursue removing cc-option-yn. Cc: Heiko Carstens <hca@linux.ibm.com> Cc: Vasily Gorbik <gor@linux.ibm.com> Cc: Christian Borntraeger <borntraeger@de.ibm.com> Cc: linux-s390@vger.kernel.org Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/s390/Makefile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/s390/Makefile b/arch/s390/Makefile index 17dc4f1ac4fa..a3cf33ad009f 100644 --- a/arch/s390/Makefile +++ b/arch/s390/Makefile @@ -70,7 +70,7 @@ cflags-y += -Wa,-I$(srctree)/arch/$(ARCH)/include # cflags-$(CONFIG_FRAME_POINTER) += -fno-optimize-sibling-calls -ifeq ($(call cc-option-yn,-mpacked-stack -mbackchain -msoft-float),y) +ifneq ($(call cc-option,-mpacked-stack -mbackchain -msoft-float),) cflags-$(CONFIG_PACK_STACK) += -mpacked-stack -D__PACK_STACK aflags-$(CONFIG_PACK_STACK) += -D__PACK_STACK endif @@ -78,22 +78,22 @@ endif KBUILD_AFLAGS_DECOMPRESSOR += $(aflags-y) KBUILD_CFLAGS_DECOMPRESSOR += $(cflags-y) -ifeq ($(call cc-option-yn,-mstack-size=8192 -mstack-guard=128),y) +ifneq ($(call cc-option,-mstack-size=8192 -mstack-guard=128),) cflags-$(CONFIG_CHECK_STACK) += -mstack-size=$(STACK_SIZE) -ifneq ($(call cc-option-yn,-mstack-size=8192),y) +ifeq ($(call cc-option,-mstack-size=8192),) cflags-$(CONFIG_CHECK_STACK) += -mstack-guard=$(CONFIG_STACK_GUARD) endif endif ifdef CONFIG_WARN_DYNAMIC_STACK - ifeq ($(call cc-option-yn,-mwarn-dynamicstack),y) + ifneq ($(call cc-option,-mwarn-dynamicstack),) KBUILD_CFLAGS += -mwarn-dynamicstack KBUILD_CFLAGS_DECOMPRESSOR += -mwarn-dynamicstack endif endif ifdef CONFIG_EXPOLINE - ifeq ($(call cc-option-yn,$(CC_FLAGS_MARCH) -mindirect-branch=thunk),y) + ifneq ($(call cc-option,$(CC_FLAGS_MARCH) -mindirect-branch=thunk),) CC_FLAGS_EXPOLINE := -mindirect-branch=thunk CC_FLAGS_EXPOLINE += -mfunction-return=thunk CC_FLAGS_EXPOLINE += -mindirect-branch-table @@ -104,10 +104,10 @@ ifdef CONFIG_EXPOLINE endif ifdef CONFIG_FUNCTION_TRACER - ifeq ($(call cc-option-yn,-mfentry -mnop-mcount),n) + ifeq ($(call cc-option,-mfentry -mnop-mcount),) # make use of hotpatch feature if the compiler supports it cc_hotpatch := -mhotpatch=0,3 - ifeq ($(call cc-option-yn,$(cc_hotpatch)),y) + ifneq ($(call cc-option,$(cc_hotpatch)),) CC_FLAGS_FTRACE := $(cc_hotpatch) KBUILD_AFLAGS += -DCC_USING_HOTPATCH KBUILD_CFLAGS += -DCC_USING_HOTPATCH -- 2.33.0.rc1.237.g0d66db33f3-goog ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/7] s390: replace cc-option-yn uses with cc-option 2021-08-17 0:21 ` [PATCH 2/7] s390: replace cc-option-yn uses with cc-option Nick Desaulniers @ 2021-08-17 2:03 ` Nathan Chancellor 2021-08-23 17:43 ` Heiko Carstens 1 sibling, 0 replies; 4+ messages in thread From: Nathan Chancellor @ 2021-08-17 2:03 UTC (permalink / raw) To: Nick Desaulniers, Masahiro Yamada Cc: linux-kbuild, clang-built-linux, Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390 On 8/16/2021 5:21 PM, 'Nick Desaulniers' via Clang Built Linux wrote: > cc-option-yn can be replaced with cc-option. ie. > Checking for support: > ifeq ($(call cc-option-yn,$(FLAG)),y) > becomes: > ifneq ($(call cc-option,$(FLAG)),) > > Checking for lack of support: > ifeq ($(call cc-option-yn,$(FLAG)),n) > becomes: > ifeq ($(call cc-option,$(FLAG)),) > > This allows us to pursue removing cc-option-yn. > > Cc: Heiko Carstens <hca@linux.ibm.com> > Cc: Vasily Gorbik <gor@linux.ibm.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: linux-s390@vger.kernel.org > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > arch/s390/Makefile | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/s390/Makefile b/arch/s390/Makefile > index 17dc4f1ac4fa..a3cf33ad009f 100644 > --- a/arch/s390/Makefile > +++ b/arch/s390/Makefile > @@ -70,7 +70,7 @@ cflags-y += -Wa,-I$(srctree)/arch/$(ARCH)/include > # > cflags-$(CONFIG_FRAME_POINTER) += -fno-optimize-sibling-calls > > -ifeq ($(call cc-option-yn,-mpacked-stack -mbackchain -msoft-float),y) > +ifneq ($(call cc-option,-mpacked-stack -mbackchain -msoft-float),) > cflags-$(CONFIG_PACK_STACK) += -mpacked-stack -D__PACK_STACK > aflags-$(CONFIG_PACK_STACK) += -D__PACK_STACK > endif > @@ -78,22 +78,22 @@ endif > KBUILD_AFLAGS_DECOMPRESSOR += $(aflags-y) > KBUILD_CFLAGS_DECOMPRESSOR += $(cflags-y) > > -ifeq ($(call cc-option-yn,-mstack-size=8192 -mstack-guard=128),y) > +ifneq ($(call cc-option,-mstack-size=8192 -mstack-guard=128),) > cflags-$(CONFIG_CHECK_STACK) += -mstack-size=$(STACK_SIZE) > -ifneq ($(call cc-option-yn,-mstack-size=8192),y) > +ifeq ($(call cc-option,-mstack-size=8192),) > cflags-$(CONFIG_CHECK_STACK) += -mstack-guard=$(CONFIG_STACK_GUARD) > endif > endif > > ifdef CONFIG_WARN_DYNAMIC_STACK > - ifeq ($(call cc-option-yn,-mwarn-dynamicstack),y) > + ifneq ($(call cc-option,-mwarn-dynamicstack),) > KBUILD_CFLAGS += -mwarn-dynamicstack > KBUILD_CFLAGS_DECOMPRESSOR += -mwarn-dynamicstack > endif > endif > > ifdef CONFIG_EXPOLINE > - ifeq ($(call cc-option-yn,$(CC_FLAGS_MARCH) -mindirect-branch=thunk),y) > + ifneq ($(call cc-option,$(CC_FLAGS_MARCH) -mindirect-branch=thunk),) > CC_FLAGS_EXPOLINE := -mindirect-branch=thunk > CC_FLAGS_EXPOLINE += -mfunction-return=thunk > CC_FLAGS_EXPOLINE += -mindirect-branch-table > @@ -104,10 +104,10 @@ ifdef CONFIG_EXPOLINE > endif > > ifdef CONFIG_FUNCTION_TRACER > - ifeq ($(call cc-option-yn,-mfentry -mnop-mcount),n) > + ifeq ($(call cc-option,-mfentry -mnop-mcount),) > # make use of hotpatch feature if the compiler supports it > cc_hotpatch := -mhotpatch=0,3 > - ifeq ($(call cc-option-yn,$(cc_hotpatch)),y) > + ifneq ($(call cc-option,$(cc_hotpatch)),) > CC_FLAGS_FTRACE := $(cc_hotpatch) > KBUILD_AFLAGS += -DCC_USING_HOTPATCH > KBUILD_CFLAGS += -DCC_USING_HOTPATCH > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/7] s390: replace cc-option-yn uses with cc-option 2021-08-17 0:21 ` [PATCH 2/7] s390: replace cc-option-yn uses with cc-option Nick Desaulniers 2021-08-17 2:03 ` Nathan Chancellor @ 2021-08-23 17:43 ` Heiko Carstens 2021-08-25 4:37 ` Masahiro Yamada 1 sibling, 1 reply; 4+ messages in thread From: Heiko Carstens @ 2021-08-23 17:43 UTC (permalink / raw) To: Nick Desaulniers Cc: Masahiro Yamada, linux-kbuild, clang-built-linux, Vasily Gorbik, Christian Borntraeger, linux-s390 On Mon, Aug 16, 2021 at 05:21:04PM -0700, Nick Desaulniers wrote: > cc-option-yn can be replaced with cc-option. ie. > Checking for support: > ifeq ($(call cc-option-yn,$(FLAG)),y) > becomes: > ifneq ($(call cc-option,$(FLAG)),) > > Checking for lack of support: > ifeq ($(call cc-option-yn,$(FLAG)),n) > becomes: > ifeq ($(call cc-option,$(FLAG)),) > > This allows us to pursue removing cc-option-yn. > > Cc: Heiko Carstens <hca@linux.ibm.com> > Cc: Vasily Gorbik <gor@linux.ibm.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: linux-s390@vger.kernel.org > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/s390/Makefile | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Acked-by: Heiko Carstens <hca@linux.ibm.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/7] s390: replace cc-option-yn uses with cc-option 2021-08-23 17:43 ` Heiko Carstens @ 2021-08-25 4:37 ` Masahiro Yamada 0 siblings, 0 replies; 4+ messages in thread From: Masahiro Yamada @ 2021-08-25 4:37 UTC (permalink / raw) To: Heiko Carstens Cc: Nick Desaulniers, Linux Kbuild mailing list, clang-built-linux, Vasily Gorbik, Christian Borntraeger, linux-s390 On Tue, Aug 24, 2021 at 2:43 AM Heiko Carstens <hca@linux.ibm.com> wrote: > > On Mon, Aug 16, 2021 at 05:21:04PM -0700, Nick Desaulniers wrote: > > cc-option-yn can be replaced with cc-option. ie. > > Checking for support: > > ifeq ($(call cc-option-yn,$(FLAG)),y) > > becomes: > > ifneq ($(call cc-option,$(FLAG)),) > > > > Checking for lack of support: > > ifeq ($(call cc-option-yn,$(FLAG)),n) > > becomes: > > ifeq ($(call cc-option,$(FLAG)),) > > > > This allows us to pursue removing cc-option-yn. > > > > Cc: Heiko Carstens <hca@linux.ibm.com> > > Cc: Vasily Gorbik <gor@linux.ibm.com> > > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > > Cc: linux-s390@vger.kernel.org > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > --- > > arch/s390/Makefile | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > Acked-by: Heiko Carstens <hca@linux.ibm.com> Applied to linux-kbuild. -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-25 4:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210817002109.2736222-1-ndesaulniers@google.com>
2021-08-17 0:21 ` [PATCH 2/7] s390: replace cc-option-yn uses with cc-option Nick Desaulniers
2021-08-17 2:03 ` Nathan Chancellor
2021-08-23 17:43 ` Heiko Carstens
2021-08-25 4:37 ` Masahiro Yamada
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox