From: Janosch Frank <frankja@linux.ibm.com>
To: Christoph Schlameuss <schlameuss@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Cc: "Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>,
"David Hildenbrand" <david@kernel.org>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v4 4/6] s390x: sclp: Use sclp_feat_check directly to read DIAG318 feature bit
Date: Thu, 23 Apr 2026 16:46:48 +0200 [thread overview]
Message-ID: <60a126c1-3eea-4cfa-86ef-c4c66b1350df@linux.ibm.com> (raw)
In-Reply-To: <20260423-vsie-stfle-fac-v4-4-32943fe43394@linux.ibm.com>
On 4/23/26 16:26, Christoph Schlameuss wrote:
> The additional entry in struct ReadInfo is only used to set sclp_facilities
> where we are aware where these bits actually are in _read_info. So it is
> more readable to directly check the bit here.
>
> While at it order feat checks by byte and bit.
>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2026-04-23 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 14:26 [kvm-unit-tests PATCH v4 0/6] s390x: Add test for STFLE interpretive execution (format-2) Christoph Schlameuss
2026-04-23 14:26 ` [kvm-unit-tests PATCH v4 1/6] s390x: snippets: Add reset_guest() to lib Christoph Schlameuss
2026-04-23 14:26 ` [kvm-unit-tests PATCH v4 2/6] s390x: sclp: Remove unnecessary padding from struct sclp_facilities Christoph Schlameuss
2026-04-23 14:26 ` [kvm-unit-tests PATCH v4 3/6] s390x: sclp: Check sclp byte before reading feature bits Christoph Schlameuss
2026-04-23 14:26 ` [kvm-unit-tests PATCH v4 4/6] s390x: sclp: Use sclp_feat_check directly to read DIAG318 feature bit Christoph Schlameuss
2026-04-23 14:46 ` Janosch Frank [this message]
2026-04-23 14:26 ` [kvm-unit-tests PATCH v4 5/6] s390x: sclp: Add detection of alternate STFLE facilities Christoph Schlameuss
2026-04-23 14:45 ` Janosch Frank
2026-04-23 14:26 ` [kvm-unit-tests PATCH v4 6/6] s390x: Add test for STFLE interpretive execution (format-2) Christoph Schlameuss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a126c1-3eea-4cfa-86ef-c4c66b1350df@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@kernel.org \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=schlameuss@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox