* [kvm-unit-tests PATCH v1] s390x: Fix integer literal in skey.c
@ 2023-01-04 17:59 Nina Schoetterl-Glausch
2023-01-04 18:05 ` Nina Schoetterl-Glausch
2023-01-05 10:05 ` Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: Nina Schoetterl-Glausch @ 2023-01-04 17:59 UTC (permalink / raw)
To: Thomas Huth, Janosch Frank, Claudio Imbrenda
Cc: Nina Schoetterl-Glausch, David Hildenbrand, kvm, linux-s390
The code is a 64bit number of which the upper 48 bits must be 0.
Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
---
s390x/skey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/skey.c b/s390x/skey.c
index 1167e4d3..7c7a8090 100644
--- a/s390x/skey.c
+++ b/s390x/skey.c
@@ -320,7 +320,7 @@ static void test_diag_308(void)
"lr %[response],%%r3\n"
: [response] "=d" (response)
: [ipib] "d" (ipib),
- [code] "d" (5)
+ [code] "d" (5L)
: "%r2", "%r3"
);
report(response == 0x402, "no exception on fetch, response: invalid IPIB");
base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [kvm-unit-tests PATCH v1] s390x: Fix integer literal in skey.c
2023-01-04 17:59 [kvm-unit-tests PATCH v1] s390x: Fix integer literal in skey.c Nina Schoetterl-Glausch
@ 2023-01-04 18:05 ` Nina Schoetterl-Glausch
2023-01-05 10:05 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Nina Schoetterl-Glausch @ 2023-01-04 18:05 UTC (permalink / raw)
To: Thomas Huth, Janosch Frank, Claudio Imbrenda
Cc: David Hildenbrand, kvm, linux-s390
I forgot:
Fixes: 965e38a0 ("s390x: Test effect of storage keys on diag 308")
On Wed, 2023-01-04 at 18:59 +0100, Nina Schoetterl-Glausch wrote:
> The code is a 64bit number of which the upper 48 bits must be 0.
>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> ---
> s390x/skey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/skey.c b/s390x/skey.c
> index 1167e4d3..7c7a8090 100644
> --- a/s390x/skey.c
> +++ b/s390x/skey.c
> @@ -320,7 +320,7 @@ static void test_diag_308(void)
> "lr %[response],%%r3\n"
> : [response] "=d" (response)
> : [ipib] "d" (ipib),
> - [code] "d" (5)
> + [code] "d" (5L)
> : "%r2", "%r3"
> );
> report(response == 0x402, "no exception on fetch, response: invalid IPIB");
>
> base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [kvm-unit-tests PATCH v1] s390x: Fix integer literal in skey.c
2023-01-04 17:59 [kvm-unit-tests PATCH v1] s390x: Fix integer literal in skey.c Nina Schoetterl-Glausch
2023-01-04 18:05 ` Nina Schoetterl-Glausch
@ 2023-01-05 10:05 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2023-01-05 10:05 UTC (permalink / raw)
To: Nina Schoetterl-Glausch, Janosch Frank, Claudio Imbrenda
Cc: David Hildenbrand, kvm, linux-s390
On 04/01/2023 18.59, Nina Schoetterl-Glausch wrote:
> The code is a 64bit number of which the upper 48 bits must be 0.
>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> ---
> s390x/skey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/skey.c b/s390x/skey.c
> index 1167e4d3..7c7a8090 100644
> --- a/s390x/skey.c
> +++ b/s390x/skey.c
> @@ -320,7 +320,7 @@ static void test_diag_308(void)
> "lr %[response],%%r3\n"
> : [response] "=d" (response)
> : [ipib] "d" (ipib),
> - [code] "d" (5)
> + [code] "d" (5L)
> : "%r2", "%r3"
> );
> report(response == 0x402, "no exception on fetch, response: invalid IPIB");
>
> base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea
Thanks, I've pushed it directly as a trivial fix.
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-05 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-04 17:59 [kvm-unit-tests PATCH v1] s390x: Fix integer literal in skey.c Nina Schoetterl-Glausch
2023-01-04 18:05 ` Nina Schoetterl-Glausch
2023-01-05 10:05 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox