From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Mike Snitzer <snitzer@redhat.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Mikulas Patocka <mpatocka@redhat.com>,
Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: md: dm-writeback: add __noreturn to BUG-ging function
Date: Wed, 18 Nov 2020 17:35:49 +0100 [thread overview]
Message-ID: <7ae2b73e-e6e5-3357-11e4-efd93e93ba35@de.ibm.com> (raw)
In-Reply-To: <20201118160748.GA754@redhat.com>
On 18.11.20 17:07, Mike Snitzer wrote:
> On Wed, Nov 18 2020 at 10:49am -0500,
> Mike Snitzer <snitzer@redhat.com> wrote:
>
>> I don't think my suggestion will help.. given it'd still leave
>> persistent_memory_claim() without a return statement.
>>
>> Think it worthwhile to just add a dummy 'return 0;' after the BUG().
>
> Decided to go with this, now staged for 5.11:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.11&id=a1e4865b4dda7071f3707f7e551289ead66e38b1
>
Looks like a sane solution. Thank you for following up.
next prev parent reply other threads:[~2020-11-18 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 22:52 [PATCH] md: dm-writeback: add __noreturn to BUG-ging function Randy Dunlap
2020-11-16 7:30 ` Christian Borntraeger
2020-11-16 23:00 ` Randy Dunlap
2020-11-17 16:31 ` Mike Snitzer
2020-11-18 15:49 ` Mike Snitzer
2020-11-18 16:07 ` Mike Snitzer
2020-11-18 16:35 ` Christian Borntraeger [this message]
2020-11-18 16:38 ` Randy Dunlap
2020-11-18 21:24 ` Mikulas Patocka
2020-11-20 14:08 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ae2b73e-e6e5-3357-11e4-efd93e93ba35@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=rdunlap@infradead.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox