[PATCH] s390/pci: Use irq_data_get_msi_desc()

[PATCH] s390/pci: Use irq_data_get_msi_desc()

[Thomas Gleixner]

No point in doing another lookup of irq_data, it's already provided as
an argument.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/s390/pci/pci_irq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/s390/pci/pci_irq.c
+++ b/arch/s390/pci/pci_irq.c
@@ -132,7 +132,7 @@ static int zpci_clear_irq(struct zpci_de
 static int zpci_set_irq_affinity(struct irq_data *data, const struct cpumask *dest,
 				 bool force)
 {
-	struct msi_desc *entry = irq_get_msi_desc(data->irq);
+	struct msi_desc *entry = irq_data_get_msi_desc(data);
 	struct msi_msg msg = entry->msg;
 	int cpu_addr = smp_cpu_get_cpu_address(cpumask_first(dest));
 

Re: [PATCH] s390/pci: Use irq_data_get_msi_desc()

[Niklas Schnelle]

On Sat, 2022-11-12 at 19:47 +0100, Thomas Gleixner wrote:
> No point in doing another lookup of irq_data, it's already provided as
> an argument.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/s390/pci/pci_irq.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/s390/pci/pci_irq.c
> +++ b/arch/s390/pci/pci_irq.c
> @@ -132,7 +132,7 @@ static int zpci_clear_irq(struct zpci_de
>  static int zpci_set_irq_affinity(struct irq_data *data, const struct cpumask *dest,
>  				 bool force)
>  {
> -	struct msi_desc *entry = irq_get_msi_desc(data->irq);
> +	struct msi_desc *entry = irq_data_get_msi_desc(data);
>  	struct msi_msg msg = entry->msg;
>  	int cpu_addr = smp_cpu_get_cpu_address(cpumask_first(dest));
>  

Thanks for the patch, makes sense to me so have my:

Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>

That said it must be noted that this function is only called when using
directed PCI IRQs which is a hardware feature that has not made it to
any released hardware. Nevertheless no point int doing things more
complicated than necessary even for that case.

If there are no objections I'll apply this to our internal tree and it
will then go upstream via the s390 tree.

Re: [PATCH] s390/pci: Use irq_data_get_msi_desc()

[Thomas Gleixner]

On Mon, Nov 14 2022 at 09:55, Niklas Schnelle wrote:
> On Sat, 2022-11-12 at 19:47 +0100, Thomas Gleixner wrote:
> That said it must be noted that this function is only called when using
> directed PCI IRQs which is a hardware feature that has not made it to
> any released hardware. Nevertheless no point int doing things more
> complicated than necessary even for that case.
>
> If there are no objections I'll apply this to our internal tree and it
> will then go upstream via the s390 tree.

Sure. It has no dependencies. I just stumbled over it when doing a tree
wide inspection of (PCI)MSI code.

Thanks,

        tglx

Re: [PATCH] s390/pci: Use irq_data_get_msi_desc()

[Alexander Gordeev]

On Sat, Nov 12, 2022 at 07:47:52PM +0100, Thomas Gleixner wrote:
> No point in doing another lookup of irq_data, it's already provided as
> an argument.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/s390/pci/pci_irq.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/s390/pci/pci_irq.c
> +++ b/arch/s390/pci/pci_irq.c
> @@ -132,7 +132,7 @@ static int zpci_clear_irq(struct zpci_de
>  static int zpci_set_irq_affinity(struct irq_data *data, const struct cpumask *dest,
>  				 bool force)
>  {
> -	struct msi_desc *entry = irq_get_msi_desc(data->irq);
> +	struct msi_desc *entry = irq_data_get_msi_desc(data);
>  	struct msi_msg msg = entry->msg;
>  	int cpu_addr = smp_cpu_get_cpu_address(cpumask_first(dest));

Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com>