* [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs
[not found] <1236095764-19325-1-git-send-email-danms@us.ibm.com>
@ 2009-03-03 15:56 ` Dan Smith
2009-03-03 16:08 ` Dave Hansen
0 siblings, 1 reply; 5+ messages in thread
From: Dan Smith @ 2009-03-03 15:56 UTC (permalink / raw)
To: containers; +Cc: linux-kernel, linux-s390
We need to use this value in the checkpoint/restart code and would like to
have a constant instead of a magic '3'.
Signed-off-by: Dan Smith <danms@us.ibm.com>
Cc: linux-s390@vger.kernel.org
---
arch/s390/include/asm/ptrace.h | 2 ++
arch/s390/kernel/compat_ptrace.h | 3 ++-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/s390/include/asm/ptrace.h b/arch/s390/include/asm/ptrace.h
index 5396f9f..d5b0781 100644
--- a/arch/s390/include/asm/ptrace.h
+++ b/arch/s390/include/asm/ptrace.h
@@ -172,6 +172,8 @@
#define NUM_CRS 16
#define NUM_ACRS 16
+#define NUM_CR_WORDS 3
+
#define FPR_SIZE 8
#define FPC_SIZE 4
#define FPC_PAD_SIZE 4 /* gcc insists on aligning the fpregs */
diff --git a/arch/s390/kernel/compat_ptrace.h b/arch/s390/kernel/compat_ptrace.h
index a2be3a9..123dd66 100644
--- a/arch/s390/kernel/compat_ptrace.h
+++ b/arch/s390/kernel/compat_ptrace.h
@@ -1,10 +1,11 @@
#ifndef _PTRACE32_H
#define _PTRACE32_H
+#include <asm/ptrace.h> /* needed for NUM_CR_WORDS */
#include "compat_linux.h" /* needed for psw_compat_t */
typedef struct {
- __u32 cr[3];
+ __u32 cr[NUM_CR_WORDS];
} per_cr_words32;
typedef struct {
--
1.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs
2009-03-03 15:56 ` [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs Dan Smith
@ 2009-03-03 16:08 ` Dave Hansen
2009-03-04 0:56 ` Dan Smith
0 siblings, 1 reply; 5+ messages in thread
From: Dave Hansen @ 2009-03-03 16:08 UTC (permalink / raw)
To: Dan Smith; +Cc: containers, linux-s390, linux-kernel
On Tue, 2009-03-03 at 10:56 -0500, Dan Smith wrote:
> We need to use this value in the checkpoint/restart code and would like to
> have a constant instead of a magic '3'.
This doesn't do a lot of good unless it gets used in the base s390 code.
Otherwise, why not just define it near its use in the c/r code?
-- Dave
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs
2009-03-03 16:08 ` Dave Hansen
@ 2009-03-04 0:56 ` Dan Smith
2009-03-04 0:59 ` Dave Hansen
0 siblings, 1 reply; 5+ messages in thread
From: Dan Smith @ 2009-03-04 0:56 UTC (permalink / raw)
To: Dave Hansen; +Cc: containers, linux-s390, linux-kernel
DH> This doesn't do a lot of good unless it gets used in the base s390
DH> code. Otherwise, why not just define it near its use in the c/r
DH> code?
I intended to replace all uses, but I just found one place I missed,
but I think that's it. If you know of other places that it's used in
the s390 code, other than in compat_ptrace.h and ptrace.h please point
them out.
--
Dan Smith
IBM Linux Technology Center
email: danms@us.ibm.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs
2009-03-04 0:56 ` Dan Smith
@ 2009-03-04 0:59 ` Dave Hansen
0 siblings, 0 replies; 5+ messages in thread
From: Dave Hansen @ 2009-03-04 0:59 UTC (permalink / raw)
To: Dan Smith; +Cc: containers, linux-s390, linux-kernel
On Tue, 2009-03-03 at 16:56 -0800, Dan Smith wrote:
> DH> This doesn't do a lot of good unless it gets used in the base s390
> DH> code. Otherwise, why not just define it near its use in the c/r
> DH> code?
>
> I intended to replace all uses, but I just found one place I missed,
> but I think that's it. If you know of other places that it's used in
> the s390 code, other than in compat_ptrace.h and ptrace.h please point
> them out.
My only knowledge of where else it was used came from you. :)
-- Dave
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs
@ 2009-02-25 18:12 Dan Smith
0 siblings, 0 replies; 5+ messages in thread
From: Dan Smith @ 2009-02-25 18:12 UTC (permalink / raw)
To: linux-s390
We need to use this value in the checkpoint/restart code and would like to
have a constant instead of a magic '3'.
Signed-off-by: Dan Smith <danms@us.ibm.com>
Cc: linux-s390@vger.kernel.org
---
arch/s390/include/asm/ptrace.h | 2 ++
arch/s390/kernel/compat_ptrace.h | 3 ++-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/s390/include/asm/ptrace.h b/arch/s390/include/asm/ptrace.h
index 5396f9f..d5b0781 100644
--- a/arch/s390/include/asm/ptrace.h
+++ b/arch/s390/include/asm/ptrace.h
@@ -172,6 +172,8 @@
#define NUM_CRS 16
#define NUM_ACRS 16
+#define NUM_CR_WORDS 3
+
#define FPR_SIZE 8
#define FPC_SIZE 4
#define FPC_PAD_SIZE 4 /* gcc insists on aligning the fpregs */
diff --git a/arch/s390/kernel/compat_ptrace.h b/arch/s390/kernel/compat_ptrace.h
index a2be3a9..123dd66 100644
--- a/arch/s390/kernel/compat_ptrace.h
+++ b/arch/s390/kernel/compat_ptrace.h
@@ -1,10 +1,11 @@
#ifndef _PTRACE32_H
#define _PTRACE32_H
+#include <asm/ptrace.h> /* needed for NUM_CR_WORDS */
#include "compat_linux.h" /* needed for psw_compat_t */
typedef struct {
- __u32 cr[3];
+ __u32 cr[NUM_CR_WORDS];
} per_cr_words32;
typedef struct {
--
1.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-04 0:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1236095764-19325-1-git-send-email-danms@us.ibm.com>
2009-03-03 15:56 ` [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs Dan Smith
2009-03-03 16:08 ` Dave Hansen
2009-03-04 0:56 ` Dan Smith
2009-03-04 0:59 ` Dave Hansen
2009-02-25 18:12 Dan Smith
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox