* Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper
[not found] ` <1462285994-31983-1-git-send-email-fw@strlen.de>
@ 2016-05-04 8:14 ` Felipe Balbi
2016-05-04 11:33 ` Mugunthan V N
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2016-05-04 8:14 UTC (permalink / raw)
To: netdev
Cc: devel, linux-xtensa, linux-omap, linux-scsi,
user-mode-linux-devel, linux-s390, linux-rdma, linux-wireless,
linux-usb, Florian Westphal, linux-can, linux-bluetooth,
linux-parisc, b.a.t.m.a.n, linux-hams, linux1394-devel,
MPT-FusionLinux.pdl
[-- Attachment #1.1: Type: text/plain, Size: 1517 bytes --]
Hi,
Florian Westphal <fw@strlen.de> writes:
> Replace all trans_start updates with netif_trans_update helper.
> change was done via spatch:
>
> struct net_device *d;
> @@
> - d->trans_start = jiffies
> + netif_trans_update(d)
>
> Compile tested only.
>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: linux-xtensa@linux-xtensa.org
> Cc: linux1394-devel@lists.sourceforge.net
> Cc: linux-rdma@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: MPT-FusionLinux.pdl@broadcom.com
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-hams@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-s390@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: b.a.t.m.a.n@lists.open-mesh.org
> Cc: linux-bluetooth@vger.kernel.org
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
for u_ether.c:
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
> index 637809e..a3f7e7c 100644
> --- a/drivers/usb/gadget/function/u_ether.c
> +++ b/drivers/usb/gadget/function/u_ether.c
> @@ -597,7 +597,7 @@ static netdev_tx_t eth_start_xmit(struct sk_buff *skb,
> DBG(dev, "tx queue err %d\n", retval);
> break;
> case 0:
> - net->trans_start = jiffies;
> + netif_trans_update(net);
> atomic_inc(&dev->tx_qlen);
> }
--
balbi
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper
[not found] ` <1462285994-31983-1-git-send-email-fw@strlen.de>
2016-05-04 8:14 ` [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper Felipe Balbi
@ 2016-05-04 11:33 ` Mugunthan V N
2016-05-04 17:20 ` Antonio Quartulli
2016-05-12 19:40 ` Doug Ledford
3 siblings, 0 replies; 4+ messages in thread
From: Mugunthan V N @ 2016-05-04 11:33 UTC (permalink / raw)
To: Florian Westphal, netdev
Cc: user-mode-linux-devel, linux-xtensa, linux1394-devel, linux-rdma,
MPT-FusionLinux.pdl, linux-scsi, linux-can, linux-parisc,
linux-omap, linux-hams, linux-usb, linux-wireless, linux-s390,
devel, b.a.t.m.a.n, linux-bluetooth
On Tuesday 03 May 2016 08:03 PM, Florian Westphal wrote:
> Replace all trans_start updates with netif_trans_update helper.
> change was done via spatch:
>
> struct net_device *d;
> @@
> - d->trans_start = jiffies
> + netif_trans_update(d)
>
> Compile tested only.
>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: linux-xtensa@linux-xtensa.org
> Cc: linux1394-devel@lists.sourceforge.net
> Cc: linux-rdma@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: MPT-FusionLinux.pdl@broadcom.com
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-hams@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-s390@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: b.a.t.m.a.n@lists.open-mesh.org
> Cc: linux-bluetooth@vger.kernel.org
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
snip...
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 0fa75a8..3d4662d 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1381,7 +1381,7 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb,
> struct cpsw_priv *priv = netdev_priv(ndev);
> int ret;
>
> - ndev->trans_start = jiffies;
> + netif_trans_update(ndev);
>
> if (skb_padto(skb, CPSW_MIN_PACKET_SIZE)) {
> cpsw_err(priv, tx_err, "packet pad failed\n");
for cpsw
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper
[not found] ` <1462285994-31983-1-git-send-email-fw@strlen.de>
2016-05-04 8:14 ` [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper Felipe Balbi
2016-05-04 11:33 ` Mugunthan V N
@ 2016-05-04 17:20 ` Antonio Quartulli
2016-05-12 19:40 ` Doug Ledford
3 siblings, 0 replies; 4+ messages in thread
From: Antonio Quartulli @ 2016-05-04 17:20 UTC (permalink / raw)
To: Florian Westphal
Cc: netdev, user-mode-linux-devel, linux-xtensa, linux1394-devel,
linux-rdma, MPT-FusionLinux.pdl, linux-scsi, linux-can,
linux-parisc, linux-omap, linux-hams, linux-usb, linux-wireless,
linux-s390, devel, b.a.t.m.a.n, linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
On Tue, May 03, 2016 at 04:33:13PM +0200, Florian Westphal wrote:
> Replace all trans_start updates with netif_trans_update helper.
> change was done via spatch:
>
> struct net_device *d;
> @@
> - d->trans_start = jiffies
> + netif_trans_update(d)
>
> Compile tested only.
>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: linux-xtensa@linux-xtensa.org
> Cc: linux1394-devel@lists.sourceforge.net
> Cc: linux-rdma@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: MPT-FusionLinux.pdl@broadcom.com
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-hams@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-s390@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: b.a.t.m.a.n@lists.open-mesh.org
> Cc: linux-bluetooth@vger.kernel.org
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
[...]
> net/batman-adv/soft-interface.c | 2 +-
[...]
> diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
> index 0710379..bae1397 100644
> --- a/net/batman-adv/soft-interface.c
> +++ b/net/batman-adv/soft-interface.c
> @@ -208,7 +208,7 @@ static int batadv_interface_tx(struct sk_buff *skb,
> if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE)
> goto dropped;
>
> - soft_iface->trans_start = jiffies;
> + netif_trans_update(soft_iface);
> vid = batadv_get_vid(skb, 0);
> ethhdr = eth_hdr(skb);
>
Acked-by: Antonio Quartulli <a@unstable.cc>
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper
[not found] ` <1462285994-31983-1-git-send-email-fw@strlen.de>
` (2 preceding siblings ...)
2016-05-04 17:20 ` Antonio Quartulli
@ 2016-05-12 19:40 ` Doug Ledford
3 siblings, 0 replies; 4+ messages in thread
From: Doug Ledford @ 2016-05-12 19:40 UTC (permalink / raw)
To: Florian Westphal, netdev
Cc: user-mode-linux-devel, linux-xtensa, linux1394-devel, linux-rdma,
mpt-fusionlinux.pdl, linux-scsi, linux-can, linux-parisc,
linux-omap, linux-hams, linux-usb, linux-wireless, linux-s390,
devel, b.a.t.m.a.n, linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
On 05/03/2016 10:33 AM, Florian Westphal wrote:
> Replace all trans_start updates with netif_trans_update helper.
> change was done via spatch:
>
> struct net_device *d;
> @@
> - d->trans_start = jiffies
> + netif_trans_update(d)
>
> Compile tested only.
>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: linux-xtensa@linux-xtensa.org
> Cc: linux1394-devel@lists.sourceforge.net
> Cc: linux-rdma@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: MPT-FusionLinux.pdl@broadcom.com
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-hams@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-s390@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: b.a.t.m.a.n@lists.open-mesh.org
> Cc: linux-bluetooth@vger.kernel.org
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Checkpatch complains about whitespace damage, but
> this extra whitespace already exists before this patch.
>
> drivers/infiniband/hw/nes/nes_nic.c | 2 +-
> drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 +-
> drivers/infiniband/ulp/ipoib/ipoib_ib.c | 2 +-
For InfiniBand bits,
Acked-by: Doug Ledford <dledford@redhat.com>
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread