Re: [kvm-unit-tests PATCH] (arm|powerpc|s390x): Makefile: add `%.aux.o` target

["Marc Hartmayer" <mhartmay@linux.ibm.com>]

On Thu, Feb 01, 2024 at 01:09 PM +0100, Thomas Huth <thuth@redhat.com> wrote:
> On 25/01/2024 16.11, Marc Hartmayer wrote:
>> It's unusual to create multiple files in one target rule, therefore create an
>> extra target for `%.aux.o` and list it as prerequisite. As a side effect, this
>> change fixes the dependency tracking of the prerequisites of
>> `.aux.o` (`lib/auxinfo.c` was missing).
>> 
>> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
>> ---
>>   arm/Makefile.common     | 23 ++++++++++++-----------
>>   powerpc/Makefile.common | 10 +++++-----
>>   s390x/Makefile          |  9 +++++----
>>   3 files changed, 22 insertions(+), 20 deletions(-)
>
> Patch looks sane to me, so I went ahead and pushed it to the git repo.
> Thanks!

Thanks.

>
> By the way, unrelated to your modifications, but while testing it, I noticed 
> that "make distclean" leaves some files behind for the s390x build:
>
>   ./configure --arch=s390x --cross-prefix=s390x-linux-gnu-
>   make -j$(nproc)
>   make distclean
>   git status --ignored
>
> On branch master
> Your branch is up to date with 'origin/master'.
>
> Ignored files:
>    (use "git add -f <file>..." to include in what will be committed)
> 	.mvpg-snippet.d
> 	.sie-dat.d
> 	.spec_ex.d

> 	lib/auxinfo.o

At least, this file is related to this patch. Before it was always
deleted, now it’s only removed if the “Makefile semantics” enforce it.

[…snip]

-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294