From: Thomas Huth <thuth@redhat.com>
To: Marc Hartmayer <mhartmay@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>,
Eric Auger <eric.auger@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] (arm|powerpc|s390x): Makefile: add `%.aux.o` target
Date: Thu, 1 Feb 2024 13:09:10 +0100 [thread overview]
Message-ID: <db6ac7f8-5a1e-4119-a48c-6c4b4e05cb27@redhat.com> (raw)
In-Reply-To: <20240125151127.94798-1-mhartmay@linux.ibm.com>
On 25/01/2024 16.11, Marc Hartmayer wrote:
> It's unusual to create multiple files in one target rule, therefore create an
> extra target for `%.aux.o` and list it as prerequisite. As a side effect, this
> change fixes the dependency tracking of the prerequisites of
> `.aux.o` (`lib/auxinfo.c` was missing).
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
> arm/Makefile.common | 23 ++++++++++++-----------
> powerpc/Makefile.common | 10 +++++-----
> s390x/Makefile | 9 +++++----
> 3 files changed, 22 insertions(+), 20 deletions(-)
Patch looks sane to me, so I went ahead and pushed it to the git repo. Thanks!
By the way, unrelated to your modifications, but while testing it, I noticed
that "make distclean" leaves some files behind for the s390x build:
./configure --arch=s390x --cross-prefix=s390x-linux-gnu-
make -j$(nproc)
make distclean
git status --ignored
On branch master
Your branch is up to date with 'origin/master'.
Ignored files:
(use "git add -f <file>..." to include in what will be committed)
.mvpg-snippet.d
.sie-dat.d
.spec_ex.d
lib/auxinfo.o
s390x/snippets/c/.cstart.d
s390x/snippets/c/.flat.d
... in case someone wants to have a look ...
Thomas
next prev parent reply other threads:[~2024-02-01 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 15:11 [kvm-unit-tests PATCH] (arm|powerpc|s390x): Makefile: add `%.aux.o` target Marc Hartmayer
2024-01-25 15:30 ` Marc Hartmayer
2024-02-01 12:09 ` Thomas Huth [this message]
2024-02-01 13:55 ` Andrew Jones
2024-02-01 14:16 ` Marc Hartmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db6ac7f8-5a1e-4119-a48c-6c4b4e05cb27@redhat.com \
--to=thuth@redhat.com \
--cc=eric.auger@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox