From: David Hildenbrand <david@redhat.com>
To: linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v1 1/2] KVM: s390: vsie: fix < 8k check for the itdba
Date: Wed, 02 May 2018 14:30:29 +0000 [thread overview]
Message-ID: <99860769-ef66-3000-0caf-e27bba76e587@redhat.com> (raw)
In-Reply-To: <a4bffd7f-4f54-c856-3ca2-3c362fdda8d9@de.ibm.com>
On 02.05.2018 14:34, Christian Borntraeger wrote:
>
>
> On 05/02/2018 01:08 PM, David Hildenbrand wrote:
>> By missing an "L", we might detect some addresses to be <8k,
>> although they are not.
>>
>> e.g. for itdba = 100001fff
>> !(gpa & ~0x1fffU) -> 1
>> !(gpa & ~0x1fffUL) -> 0
>>
>> So we would report a SIE validity intercept although everything is fine.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Should be cc stable as is might break vsie if for some reason the block is
> aligned by 4G.
The only known user is KVM itself. As it has an offset in the sie_page,
this scenario can at least never happen with KVMs we know.
So I'll leave this decision to you. Thanks!
>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
--
Thanks,
David / dhildenb
parent reply other threads:[~2018-05-02 14:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <a4bffd7f-4f54-c856-3ca2-3c362fdda8d9@de.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99860769-ef66-3000-0caf-e27bba76e587@redhat.com \
--to=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox