* Re: [PATCH v1 1/2] KVM: s390: vsie: fix < 8k check for the itdba
[not found] <a4bffd7f-4f54-c856-3ca2-3c362fdda8d9@de.ibm.com>
@ 2018-05-02 14:30 ` David Hildenbrand
0 siblings, 0 replies; only message in thread
From: David Hildenbrand @ 2018-05-02 14:30 UTC (permalink / raw)
To: linux-s390, kvm
On 02.05.2018 14:34, Christian Borntraeger wrote:
>
>
> On 05/02/2018 01:08 PM, David Hildenbrand wrote:
>> By missing an "L", we might detect some addresses to be <8k,
>> although they are not.
>>
>> e.g. for itdba = 100001fff
>> !(gpa & ~0x1fffU) -> 1
>> !(gpa & ~0x1fffUL) -> 0
>>
>> So we would report a SIE validity intercept although everything is fine.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Should be cc stable as is might break vsie if for some reason the block is
> aligned by 4G.
The only known user is KVM itself. As it has an offset in the sie_page,
this scenario can at least never happen with KVMs we know.
So I'll leave this decision to you. Thanks!
>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-05-02 14:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <a4bffd7f-4f54-c856-3ca2-3c362fdda8d9@de.ibm.com>
2018-05-02 14:30 ` [PATCH v1 1/2] KVM: s390: vsie: fix < 8k check for the itdba David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox