From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Gordeev <agordeev@linux.ibm.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Guenter Roeck <linux@roeck-us.net>,
Heiko Carstens <hca@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] lib/test_bitmap: increment failure counter properly
Date: Wed, 1 Mar 2023 17:11:32 +0200 [thread overview]
Message-ID: <Y/9rJFJ9Pmzf6Waz@smile.fi.intel.com> (raw)
In-Reply-To: <Y/1ruRmnY4eU536Q@yury-laptop>
On Mon, Feb 27, 2023 at 06:49:29PM -0800, Yury Norov wrote:
> On Tue, Feb 28, 2023 at 12:55:05AM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 27, 2023 at 01:45:23PM -0800, Yury Norov wrote:
> > > The tests that don't use expect_eq() macro to determine that a test is
> > > failured must increment failed_tests explicitly.
> >
> > ...
> >
> > > pr_err("bitmap_copy_arr32(nbits == %d:"
> > > " tail is not safely cleared: %d\n",
> >
> > Usually we don't split string literals (since checkpatch doesn't complain on a
> > looong lines with them at the end of the line),
> >
> > ...
> >
> > > pr_err("bitmap_copy_arr64(nbits == %d:"
> > > " tail is not safely cleared: %d\n", nbits, next_bit);
> >
> > Ditto.
> >
> > P.S. Seems a material for another patch.
>
> If you're OK with this patch, can you give your review tag please?
I'm fine with the series,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-03-01 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 21:45 [PATCH 1/2] lib/test_bitmap: increment failure counter properly Yury Norov
2023-02-27 21:45 ` [PATCH 2/2] lib/bitmap: drop optimization of bitmap_{from,to}_arr64 Yury Norov
2023-02-28 10:45 ` Alexander Lobakin
2023-02-27 22:55 ` [PATCH 1/2] lib/test_bitmap: increment failure counter properly Andy Shevchenko
2023-02-28 2:49 ` Yury Norov
2023-03-01 15:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9rJFJ9Pmzf6Waz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agordeev@linux.ibm.com \
--cc=aleksander.lobakin@intel.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=svens@linux.ibm.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox