From: Heiko Carstens <hca@linux.ibm.com>
To: Shaomin Deng <dengshaomin@cdjrlc.com>
Cc: gor@linux.ibm.com, agordeev@linux.ibm.com,
linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
svens@linux.ibm.com
Subject: Re: [PATCH] s390/appldata: Do not initialise statics to 0
Date: Mon, 29 Aug 2022 10:31:02 +0200 [thread overview]
Message-ID: <Ywx5Rpe/Lkso/tQn@osiris> (raw)
In-Reply-To: <20220827162230.19611-1-dengshaomin@cdjrlc.com>
On Sat, Aug 27, 2022 at 12:22:30PM -0400, Shaomin Deng wrote:
> No need to do the initialization of statics to 0 or NULL.
>
> Signed-off-by: Shaomin Deng <dengshaomin@cdjrlc.com>
> ---
> arch/s390/appldata/appldata_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c
> index d74a4c7d5df6..e1721e2dd89e 100644
> --- a/arch/s390/appldata/appldata_base.c
> +++ b/arch/s390/appldata/appldata_base.c
> @@ -88,7 +88,7 @@ static struct vtimer_list appldata_timer;
> static DEFINE_SPINLOCK(appldata_timer_lock);
> static int appldata_interval = APPLDATA_CPU_INTERVAL;
> static int appldata_timer_active;
> -static int appldata_timer_suspended = 0;
> +static int appldata_timer_suspended;
Why do you think its worth spending your and all the recipient's time
on such patches? What does this improve?
prev parent reply other threads:[~2022-08-29 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 16:22 [PATCH] s390/appldata: Do not initialise statics to 0 Shaomin Deng
2022-08-29 8:31 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywx5Rpe/Lkso/tQn@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=dengshaomin@cdjrlc.com \
--cc=gor@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox