* [PATCH] s390/appldata: Do not initialise statics to 0
@ 2022-08-27 16:22 Shaomin Deng
2022-08-29 8:31 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Shaomin Deng @ 2022-08-27 16:22 UTC (permalink / raw)
To: hca, gor, agordeev, linux-s390; +Cc: borntraeger, svens, Shaomin Deng
No need to do the initialization of statics to 0 or NULL.
Signed-off-by: Shaomin Deng <dengshaomin@cdjrlc.com>
---
arch/s390/appldata/appldata_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c
index d74a4c7d5df6..e1721e2dd89e 100644
--- a/arch/s390/appldata/appldata_base.c
+++ b/arch/s390/appldata/appldata_base.c
@@ -88,7 +88,7 @@ static struct vtimer_list appldata_timer;
static DEFINE_SPINLOCK(appldata_timer_lock);
static int appldata_interval = APPLDATA_CPU_INTERVAL;
static int appldata_timer_active;
-static int appldata_timer_suspended = 0;
+static int appldata_timer_suspended;
/*
* Work queue
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/appldata: Do not initialise statics to 0
2022-08-27 16:22 [PATCH] s390/appldata: Do not initialise statics to 0 Shaomin Deng
@ 2022-08-29 8:31 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2022-08-29 8:31 UTC (permalink / raw)
To: Shaomin Deng; +Cc: gor, agordeev, linux-s390, borntraeger, svens
On Sat, Aug 27, 2022 at 12:22:30PM -0400, Shaomin Deng wrote:
> No need to do the initialization of statics to 0 or NULL.
>
> Signed-off-by: Shaomin Deng <dengshaomin@cdjrlc.com>
> ---
> arch/s390/appldata/appldata_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c
> index d74a4c7d5df6..e1721e2dd89e 100644
> --- a/arch/s390/appldata/appldata_base.c
> +++ b/arch/s390/appldata/appldata_base.c
> @@ -88,7 +88,7 @@ static struct vtimer_list appldata_timer;
> static DEFINE_SPINLOCK(appldata_timer_lock);
> static int appldata_interval = APPLDATA_CPU_INTERVAL;
> static int appldata_timer_active;
> -static int appldata_timer_suspended = 0;
> +static int appldata_timer_suspended;
Why do you think its worth spending your and all the recipient's time
on such patches? What does this improve?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-29 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-27 16:22 [PATCH] s390/appldata: Do not initialise statics to 0 Shaomin Deng
2022-08-29 8:31 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox