From: Christoph Hellwig <hch@infradead.org>
To: Ma Ke <make24@iscas.ac.cn>
Cc: wintera@linux.ibm.com, twinkler@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
davem@davemloft.net, ubraun@linux.ibm.com, sebott@linux.ibm.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/ism: Add check for dma_set_max_seg_size in ism_probe()
Date: Thu, 27 Jun 2024 22:50:18 -0700 [thread overview]
Message-ID: <Zn5PGjhkzFumxDjv@infradead.org> (raw)
In-Reply-To: <20240626081215.2824627-1-make24@iscas.ac.cn>
On Wed, Jun 26, 2024 at 04:12:15PM +0800, Ma Ke wrote:
> As the possible failure of the dma_set_max_seg_size(), we should better
> check the return value of the dma_set_max_seg_size().
As I told you last time these checks are stupid, and I asked you to
instead send a patch to remove the return value.
Each and every of those patches just makes that removal harder.
Please stop this now and I'll prepare the removal for the next
merge window.
prev parent reply other threads:[~2024-06-28 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 8:12 [PATCH] s390/ism: Add check for dma_set_max_seg_size in ism_probe() Ma Ke
2024-06-26 12:48 ` Gerd Bayer
2024-06-26 14:00 ` Markus Elfring
2024-06-26 14:26 ` Niklas Schnelle
2024-06-28 5:50 ` Christoph Hellwig
2024-06-26 14:52 ` Markus Elfring
2024-06-28 5:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn5PGjhkzFumxDjv@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=netdev@vger.kernel.org \
--cc=sebott@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=ubraun@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox