From: Christoph Hellwig <hch@infradead.org>
To: Gerd Bayer <gbayer@linux.ibm.com>
Cc: Ma Ke <make24@iscas.ac.cn>,
wintera@linux.ibm.com, twinkler@linux.ibm.com,
Niklas Schnelle <schnelle@linux.ibm.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
davem@davemloft.net, Stefan Raspl <raspl@linux.ibm.com>
Subject: Re: [PATCH] s390/ism: Add check for dma_set_max_seg_size in ism_probe()
Date: Thu, 27 Jun 2024 22:50:50 -0700 [thread overview]
Message-ID: <Zn5POphJ8pckZ3hY@infradead.org> (raw)
In-Reply-To: <4ab328297c12d1c286c56dbc01d611b77ea2da03.camel@linux.ibm.com>
On Wed, Jun 26, 2024 at 02:48:30PM +0200, Gerd Bayer wrote:
>
> However, since ISM devices are PCI attached (and will remain PCI
> attached I believe) we can take the existance of dev->dma_parms for
> granted since pci_device_add() (in drivers/pci/probe.c) will make that
> point to the pci_dev's dma_parms for every PCI device.
>
> So I'm not sure how important this fix is.
It's not just important, it is stupid and I told them to stop sending
these kinds of crap patches.
next prev parent reply other threads:[~2024-06-28 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 8:12 [PATCH] s390/ism: Add check for dma_set_max_seg_size in ism_probe() Ma Ke
2024-06-26 12:48 ` Gerd Bayer
2024-06-26 14:00 ` Markus Elfring
2024-06-26 14:26 ` Niklas Schnelle
2024-06-28 5:50 ` Christoph Hellwig [this message]
2024-06-26 14:52 ` Markus Elfring
2024-06-28 5:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn5POphJ8pckZ3hY@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=gbayer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox