From: Janosch Frank <frankja@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>, Thomas Huth <thuth@redhat.com>
Cc: "Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Andrew Jones" <andrew.jones@linux.dev>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/2] s390x: Fix misspelt variable name in func.bash
Date: Thu, 18 Apr 2024 13:10:38 +0200 [thread overview]
Message-ID: <a4276b73-0b35-4f33-9879-65be1881c293@linux.ibm.com> (raw)
In-Reply-To: <D0L6YKP6KN2Q.SLUJM0FJ3H85@gmail.com>
On 4/16/24 04:29, Nicholas Piggin wrote:
> On Thu Apr 11, 2024 at 7:40 PM AEST, Janosch Frank wrote:
>> On 4/10/24 06:35, Nicholas Piggin wrote:
>>> On Mon Apr 8, 2024 at 9:59 PM AEST, Janosch Frank wrote:
>>>> On 4/6/24 14:24, Nicholas Piggin wrote:
>>>>> The if statement is intended to run non-migration tests with PV on KVM.
>>>>> With the misspelling, they are run on KVM or TCG.
>>>>>
>>>>
>>>> It's not misspelt, is it?
>>>> It's in the wrong case.
>>>
>>> Yes, that's the right word.
>>>
>>>>
>>>>
>>>> I'm fine with the code though.
>>>
>>> Thanks, I'll take that as an Acked-by: you
>>
>> Could you send out a fixed version that I can pick or do you want me to
>> fix that up?
>
> I was going to at some point, but was juggling a bunch of other
> things and have some travel and vacation. You are welcome to take
> over them if you like it would be helpful.
>
Same here, I'll be on vacation starting next week so I've prepared a
branch with your patches for Nico and Claudio which they can send out
when I'm on vacation.
https://gitlab.com/frankja/kvm-unit-tests/-/commits/queue/?ref_type=heads
next prev parent reply other threads:[~2024-04-18 11:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 12:24 [kvm-unit-tests PATCH 0/2] s390x: run script fixes for PV tests Nicholas Piggin
2024-04-06 12:24 ` [kvm-unit-tests PATCH 1/2] s390x: Fix misspelt variable name in func.bash Nicholas Piggin
2024-04-08 11:59 ` Janosch Frank
2024-04-10 4:35 ` Nicholas Piggin
2024-04-11 9:40 ` Janosch Frank
2024-04-16 2:29 ` Nicholas Piggin
2024-04-18 11:10 ` Janosch Frank [this message]
2024-04-06 12:24 ` [kvm-unit-tests PATCH 2/2] s390x: Fix is_pv check in run script Nicholas Piggin
2024-04-08 11:36 ` Claudio Imbrenda
2024-04-10 4:34 ` Nicholas Piggin
2024-04-10 17:18 ` Claudio Imbrenda
2024-04-08 11:46 ` Janosch Frank
2024-04-10 4:34 ` Nicholas Piggin
2024-04-08 11:23 ` [kvm-unit-tests PATCH 0/2] s390x: run script fixes for PV tests Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4276b73-0b35-4f33-9879-65be1881c293@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox