From: Janosch Frank <frankja@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>, Thomas Huth <thuth@redhat.com>
Cc: "Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Andrew Jones" <andrew.jones@linux.dev>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 0/2] s390x: run script fixes for PV tests
Date: Mon, 8 Apr 2024 13:23:45 +0200 [thread overview]
Message-ID: <6d83b8b6-6008-4bfe-99a2-63562d500456@linux.ibm.com> (raw)
In-Reply-To: <20240406122456.405139-1-npiggin@gmail.com>
On 4/6/24 14:24, Nicholas Piggin wrote:
> Shellcheck caught what looks like two bugs. May not have been too
> noticable because one just seems like it allows TCG to run PV tests
> which fails (and might be guarded out later anyway), and the other
> might only affect running and individual .pv.bin test with s390x-run
> and not unittests runs.
>
> I don't know about running PV tests or have a system with KVM to try,
> so these are not tested beyond gitlab CI. That might run some PV tests
> with s390x-kvm, but I don't know so please test/review/ack/nack if
> possible.
>
> Thanks,
> Nick
Hey Nick, thanks for cleaning this up.
The changes work on my machine and I've thrown them into our CI.
Give me a sec to check the patches itself.
prev parent reply other threads:[~2024-04-08 11:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 12:24 [kvm-unit-tests PATCH 0/2] s390x: run script fixes for PV tests Nicholas Piggin
2024-04-06 12:24 ` [kvm-unit-tests PATCH 1/2] s390x: Fix misspelt variable name in func.bash Nicholas Piggin
2024-04-08 11:59 ` Janosch Frank
2024-04-10 4:35 ` Nicholas Piggin
2024-04-11 9:40 ` Janosch Frank
2024-04-16 2:29 ` Nicholas Piggin
2024-04-18 11:10 ` Janosch Frank
2024-04-06 12:24 ` [kvm-unit-tests PATCH 2/2] s390x: Fix is_pv check in run script Nicholas Piggin
2024-04-08 11:36 ` Claudio Imbrenda
2024-04-10 4:34 ` Nicholas Piggin
2024-04-10 17:18 ` Claudio Imbrenda
2024-04-08 11:46 ` Janosch Frank
2024-04-10 4:34 ` Nicholas Piggin
2024-04-08 11:23 ` Janosch Frank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d83b8b6-6008-4bfe-99a2-63562d500456@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox