Linux s390 Architecture development
 help / color / mirror / Atom feed
* [PATCH] s390/vfio: Allow untainted use of driver_override
       [not found] <DMYH4ED3GWDO.29DGXPK4M82VR@kernel.org>
@ 2026-11-19  5:15 ` Alex Williamson
  2026-11-19  5:22   ` sashiko-bot
  2026-11-19 12:14   ` Anthony Krowiak
  0 siblings, 2 replies; 4+ messages in thread
From: Alex Williamson @ 2026-11-19  5:15 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Alex Williamson, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
	Randy Dunlap, Rafael J . Wysocki, Danilo Krummrich, Johan Hovold,
	Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	David Lechner, Armin Wolf, Thierry Reding, Mike Rapoport,
	Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton, Petr Mladek,
	Pnina Feder, Mete Durlu, Aaron Tomlin, Rio, Feng Tang, linux-doc,
	linux-kernel, driver-core, linux-trace-kernel, Mark Brown,
	Bjorn Helgaas, Tony Krowiak, Jason Herne, Eric Farman,
	Matthew Rosato, Halil Pasic, linux-s390

The vfio_ap and vfio_ccw drivers bind devices through driver_override.
With the introduction of the support_driver_override flag in the core
driver struct, it's now required for drivers to declare themselves as
driver_override compatible, otherwise driver_override bindings will be
denied or generate a kernel taint.

Set the support_driver_override flag on the vfio_ap and vfio_ccw driver
structs.

Cc: Tony Krowiak <akrowiak@linux.ibm.com>
Cc: Jason Herne <jjherne@linux.ibm.com>
Cc: Eric Farman <farman@linux.ibm.com>
Cc: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Alex Williamson <alex@shazbot.org>
---

Uwe, this should complete the vfio drivers needing driver override,
covering the s390 specific drivers.  Thanks,

Alex

 drivers/s390/cio/vfio_ccw_drv.c   | 1 +
 drivers/s390/crypto/vfio_ap_drv.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 7546bd137e4e..77765cde87f7 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
 	.drv = {
 		.name = "vfio_ccw",
 		.owner = THIS_MODULE,
+		.support_driver_override = true,
 	},
 	.subchannel_type = vfio_ccw_sch_ids,
 	.irq = vfio_ccw_sch_irq,
diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 8e69ed286bb9..2d47dc643269 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
 	.on_config_changed = vfio_ap_on_cfg_changed,
 	.on_scan_complete = vfio_ap_on_scan_complete,
 	.ids = ap_queue_ids,
+	.driver.support_driver_override = true,
 };
 
 static void vfio_ap_matrix_dev_release(struct device *dev)
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
@ 2026-11-19  5:22   ` sashiko-bot
  2026-11-19 12:14   ` Anthony Krowiak
  1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-11-19  5:22 UTC (permalink / raw)
  To: Alex Williamson
  Cc: linux-trace-kernel, linux-s390, Heiko Carstens, Vasily Gorbik,
	Alexander Gordeev, Christian Borntraeger

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] s390/vfio: unknown field support_driver_override in struct
  device_driver
--

commit a91edca560e83afe4c0101413f2c0a4218259662
Author: Alex Williamson <alex@shazbot.org>

s390/vfio: Allow untainted use of driver_override

This commit sets the support_driver_override flag on the vfio_ccw_sch_driver
and vfio_ap_drv driver structs.

> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 7546bd137e4e1..77765cde87f78 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
>  	.drv = {
>  		.name = "vfio_ccw",
>  		.owner = THIS_MODULE,
> +		.support_driver_override = true,
>  	},
>  	.subchannel_type = vfio_ccw_sch_ids,
>  	.irq = vfio_ccw_sch_irq,
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 8e69ed286bb9c..2d47dc6432698 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
>  	.on_config_changed = vfio_ap_on_cfg_changed,
>  	.on_scan_complete = vfio_ap_on_scan_complete,
>  	.ids = ap_queue_ids,
> +	.driver.support_driver_override = true,
>  };

[Severity: High]
Does struct device_driver have a support_driver_override member in this
tree?  Without the driver-core prerequisite adding that field to struct
device_driver in include/linux/device/driver.h, building vfio_ccw_drv.c or
vfio_ap_drv.c fails with an unknown field error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119051507.3306075-1-alex@shazbot.org?part=1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
  2026-11-19  5:22   ` sashiko-bot
@ 2026-11-19 12:14   ` Anthony Krowiak
  2026-11-19 18:03     ` Uwe Kleine-König
  1 sibling, 1 reply; 4+ messages in thread
From: Anthony Krowiak @ 2026-11-19 12:14 UTC (permalink / raw)
  To: Alex Williamson, Uwe Kleine-König
  Cc: Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan, Randy Dunlap,
	Rafael J . Wysocki, Danilo Krummrich, Johan Hovold,
	Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	David Lechner, Armin Wolf, Thierry Reding, Mike Rapoport,
	Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton, Petr Mladek,
	Pnina Feder, Mete Durlu, Aaron Tomlin, Rio, Feng Tang, linux-doc,
	linux-kernel, driver-core, linux-trace-kernel, Mark Brown,
	Bjorn Helgaas, Jason Herne, Eric Farman, Matthew Rosato,
	Halil Pasic, linux-s390



On 11/19/26 12:15 AM, Alex Williamson wrote:
> The vfio_ap and vfio_ccw drivers bind devices through driver_override.
> With the introduction of the support_driver_override flag in the core
> driver struct, it's now required for drivers to declare themselves as
> driver_override compatible, otherwise driver_override bindings will be
> denied or generate a kernel taint.
> 
> Set the support_driver_override flag on the vfio_ap and vfio_ccw driver
> structs.
> 
> Cc: Tony Krowiak <akrowiak@linux.ibm.com>
> Cc: Jason Herne <jjherne@linux.ibm.com>
> Cc: Eric Farman <farman@linux.ibm.com>
> Cc: Matthew Rosato <mjrosato@linux.ibm.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> Signed-off-by: Alex Williamson <alex@shazbot.org>
> ---
> 
> Uwe, this should complete the vfio drivers needing driver override,
> covering the s390 specific drivers.  Thanks,
> 
> Alex
> 
>   drivers/s390/cio/vfio_ccw_drv.c   | 1 +
>   drivers/s390/crypto/vfio_ap_drv.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 7546bd137e4e..77765cde87f7 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
>   	.drv = {
>   		.name = "vfio_ccw",
>   		.owner = THIS_MODULE,
> +		.support_driver_override = true,
>   	},
>   	.subchannel_type = vfio_ccw_sch_ids,
>   	.irq = vfio_ccw_sch_irq,
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 8e69ed286bb9..2d47dc643269 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
>   	.on_config_changed = vfio_ap_on_cfg_changed,
>   	.on_scan_complete = vfio_ap_on_scan_complete,
>   	.ids = ap_queue_ids,
> +	.driver.support_driver_override = true,

Does this really belong here? Shouldn't it be in struct ap_driver
since driver_override is supported in the AP bus?

>   };
>   
>   static void vfio_ap_matrix_dev_release(struct device *dev)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19 12:14   ` Anthony Krowiak
@ 2026-11-19 18:03     ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2026-11-19 18:03 UTC (permalink / raw)
  To: Anthony Krowiak
  Cc: Alex Williamson, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
	Randy Dunlap, Rafael J . Wysocki, Danilo Krummrich, Johan Hovold,
	Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	David Lechner, Armin Wolf, Thierry Reding, Mike Rapoport,
	Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton, Petr Mladek,
	Pnina Feder, Mete Durlu, Aaron Tomlin, Rio, Feng Tang, linux-doc,
	linux-kernel, driver-core, linux-trace-kernel, Mark Brown,
	Bjorn Helgaas, Jason Herne, Eric Farman, Matthew Rosato,
	Halil Pasic, linux-s390

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

Hello,

On Thu, Nov 19, 2026 at 07:14:47AM -0500, Anthony Krowiak wrote:
> On 11/19/26 12:15 AM, Alex Williamson wrote:
> > diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> > index 8e69ed286bb9..2d47dc643269 100644
> > --- a/drivers/s390/crypto/vfio_ap_drv.c
> > +++ b/drivers/s390/crypto/vfio_ap_drv.c
> > @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
> >   	.on_config_changed = vfio_ap_on_cfg_changed,
> >   	.on_scan_complete = vfio_ap_on_scan_complete,
> >   	.ids = ap_queue_ids,
> > +	.driver.support_driver_override = true,
> 
> Does this really belong here? Shouldn't it be in struct ap_driver
> since driver_override is supported in the AP bus?

ap_device_probe() calls device_match_driver_override with
drv=&ap_drv->driver. So I think the assignment is fine.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-19 18:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <DMYH4ED3GWDO.29DGXPK4M82VR@kernel.org>
2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
2026-11-19  5:22   ` sashiko-bot
2026-11-19 12:14   ` Anthony Krowiak
2026-11-19 18:03     ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox