Re: [PATCH rdma-next v2 03/14] RDMA/core: Support renaming a device when changing its net namespace

[Jiri Pirko <jiri@resnulli.us>]

Wed, Jul 15, 2026 at 04:30:37PM +0200, sashiko-bot@kernel.org wrote:
>Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>- [High] Unreachable feature and silent failure in netlink handler for RDMA namespace moves
>--
>
>--- Patch [3]: [PATCH rdma-next v2 03/14] RDMA/core: Support renaming a device when changing its net namespace ---
>commit 4056da04c986796c81666352d7fa9e90d5591d4e
>Author: Jiri Pirko <jiri@nvidia.com>
>
>RDMA/core: Support renaming a device when changing its net namespace
>
>This commit introduces support for renaming an RDMA device when moving
>it to a new network namespace. It preserves the literal-name path for
>user requests and keeps the fallback naming on the teardown path.
>
>> diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
>> index 32b6c4d68ca0a..77a7580801486 100644
>> --- a/drivers/infiniband/core/nldev.c
>> +++ b/drivers/infiniband/core/nldev.c
>[ ... ]
>> @@ -1195,7 +1195,7 @@ static int nldev_set_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
>>  		u32 ns_fd;
>>  
>>  		ns_fd = nla_get_u32(tb[RDMA_NLDEV_NET_NS_FD]);
>> -		err = ib_device_set_netns_put(skb, device, ns_fd);
>> +		err = ib_device_set_netns_put(skb, device, ns_fd, NULL);
>
>[Severity: High]
>Does hardcoding NULL here make the newly introduced naming feature
>unreachable from user space?

False positive. "RDMA/nldev: Allow setting the device name while
changing net namespace" adds this.